Spec URL: https://gist.github.com/xanderlent/57ac05a193805095e6d3e971ee9f3dcd/raw/f75f58c44a7bafba8b3dd43adee6fadb0611e42a/rust-cursive-macros.spec SRPM URL: https://gist.github.com/xanderlent/57ac05a193805095e6d3e971ee9f3dcd/raw/f75f58c44a7bafba8b3dd43adee6fadb0611e42a/rust-cursive-macros-0.1.0-1.fc43.src.rpm Description: Proc-macros for the cursive TUI library. Fedora Account System Username: xanderlent Please also review the rust2rpm.toml file used in the generation of the specfile: https://gist.github.com/xanderlent/57ac05a193805095e6d3e971ee9f3dcd/raw/f75f58c44a7bafba8b3dd43adee6fadb0611e42a/rust2rpm.toml This new package is a requirement for upgrading rust-cursive and rust-cursive_core to the latest versions. It's generated from the same source tree and seems to be something of an exposed implementation detail.
Copr build: https://copr.fedorainfracloud.org/coprs/build/8800138 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2353989-rust-cursive-macros/fedora-rawhide-x86_64/08800138-rust-cursive-macros/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
> cp -pav %{SOURCE2} %{buildroot}/%{crate_instdir}/LICENSE This is only necessary because the crate has a wrong "package.include" setting: > include = ["src/**/*"] So while it's great that you already sent a PR upstream to fix this issue, it was incomplete - since the "LICENSE" file is not covered by that glob. It will need to be changed to something like `include = ["/src/**/*", "/LICENSE"]`, otherwise published crates won't include the file.
Oh, okay. Now I understand the issue: The metadata also lists what files should be bundled in the crate. I'll submit an upstream PR and rework this package. Thanks for the feedback!
Spec URL: https://gist.github.com/xanderlent/57ac05a193805095e6d3e971ee9f3dcd/raw/81eb9062d91f59ecb7877a9fb1fa251aad669791/rust-cursive-macros.spec SRPM URL: https://gist.github.com/xanderlent/57ac05a193805095e6d3e971ee9f3dcd/raw/81eb9062d91f59ecb7877a9fb1fa251aad669791/rust-cursive-macros-0.1.0-1.fc43.src.rpm See also the rust2rpm.toml and patch files: https://gist.github.com/xanderlent/57ac05a193805095e6d3e971ee9f3dcd/raw/81eb9062d91f59ecb7877a9fb1fa251aad669791/cursive-macros-fix-metadata.diff https://gist.github.com/xanderlent/57ac05a193805095e6d3e971ee9f3dcd/raw/81eb9062d91f59ecb7877a9fb1fa251aad669791/rust2rpm.toml I believe that this should address the initial round of review comments. Thanks for being patient while I learn how the crate ecosystem works.
Created attachment 2085112 [details] The .spec file difference from Copr build 8800138 to 8908523
Copr build: https://copr.fedorainfracloud.org/coprs/build/8908523 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2353989-rust-cursive-macros/fedora-rawhide-x86_64/08908523-rust-cursive-macros/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Thank you, looks good to me now! You can automate the things you needed to change from the defaults with a rust2rpm.toml config file like this, if you haven't already: ``` [package] cargo-toml-patch-comments = [ "LICENSE not in sources fixed upstream: https://github.com/gyscos/cursive/pull/818", ] license-files = ["LICENSE"] [[package.extra-sources]] number = 2 file = "https://github.com/gyscos/cursive/raw/main/LICENSE" comments = ["Missing LICENSE file is fixed upstream: https://github.com/gyscos/cursive/pull/814"] [scripts] prep.post = ["cp -pav %{SOURCE2} ."] ``` This also prevents the "no license files detected" error without passing the "-I" flag to rust2rpm. === Package was generated with rust2rpm, simplifying the review. ✅ package contains only permissible content ✅ package builds and installs without errors on rawhide ✅ test suite is run and all unit tests pass ✅ latest version of the crate is packaged ✅ license matches upstream specification and is acceptable for Fedora 🫤 license file is included with %license in %files (included manually from upstream for now, will be resolved with the next version) ✅ package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter (*NOT* pre-release filter): alpha;beta;rc;pre distro: Fedora Package: rust-$crate - set bugzilla assignee overrides to @rust-sig (optional)
BTW: It looks like this is your first Rust package - if you have any questions, feel free to ask in the #rust room on Matrix :)
Thanks, I am going to introduce this package into Fedora as a first step to handling the uprev of rust-cursive.
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-cursive-macros
FEDORA-2025-690da816e8 (rust-cursive-macros-0.1.0-1.fc43) has been submitted as an update to Fedora 43. https://bodhi.fedoraproject.org/updates/FEDORA-2025-690da816e8
FEDORA-2025-690da816e8 (rust-cursive-macros-0.1.0-1.fc43) has been pushed to the Fedora 43 stable repository. If problem still persists, please make note of it in this bug report.