Bug 235401 - rm can segfault when racing another rm to delete a directory
rm can segfault when racing another rm to delete a directory
Status: CLOSED ERRATA
Product: Fedora
Classification: Fedora
Component: coreutils (Show other bugs)
6
All Linux
medium Severity medium
: ---
: ---
Assigned To: Tim Waugh
:
Depends On:
Blocks: FC6Update
  Show dependency treegraph
 
Reported: 2007-04-05 11:54 EDT by David Shaw
Modified: 2007-11-30 17:12 EST (History)
1 user (show)

See Also:
Fixed In Version: 5.97-12.5.fc6
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2007-04-19 04:25:06 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)
Patch to fix rm segfault (270 bytes, patch)
2007-04-05 11:54 EDT, David Shaw
no flags Details | Diff

  None (edit)
Description David Shaw 2007-04-05 11:54:17 EDT
Description of problem:

When deleting a deep directory tree from two different instances of "rm -rf"
simultaneously, one of the instances may segfault.

Version-Release number of selected component (if applicable):

coreutils-5.97-12.3.fc6

Steps to Reproduce:
1. Create a deep directory tree (I used 10 levels deep)
2. From two different command lines, rm -rf the parent directory of the tree
3. Repeat (it requires tricky timing so may not always happen)
  
Actual results:

One of the 'rm's will segfault.

Expected results:

Neither of the 'rm's would segfault.

Additional info:

The problem seems to be in remove.c:remove_cwd_entries(), where opendir is
called on ".".  If this fails for reason of ENOENT, the function calls readdir
on the NULL dirp.

Patch attached.
Comment 1 David Shaw 2007-04-05 11:54:17 EDT
Created attachment 151772 [details]
Patch to fix rm segfault
Comment 2 Tim Waugh 2007-04-11 07:33:16 EDT
Thanks for the patch.
Comment 3 Fedora Update System 2007-04-18 18:37:45 EDT
Fixed in update: coreutils-5.97-12.5.fc6

Note You need to log in before you can comment on or make changes to this bug.