Spec URL: https://ngompa.fedorapeople.org/for-review/python-pillow-jxl-plugin.spec SRPM URL: https://ngompa.fedorapeople.org/for-review/python-pillow-jxl-plugin-1.3.2-1.fc41.src.rpm Description: Pillow plugin for JPEG-XL, using Rust for bindings. Fedora Account System Username: ngompa
Package looks ok to me, but we need to determine whether the test images in test/images/ are redistributable.
Copr build: https://copr.fedorainfracloud.org/coprs/build/8804300 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2354261-python-pillow-jxl-plugin/fedora-rawhide-x86_64/08804300-python-pillow-jxl-plugin/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
(In reply to Fabio Valentini from comment #1) > Package looks ok to me, but we need to determine whether the test images in > test/images/ are redistributable. I've requested a clarification: https://github.com/Isotr0py/pillow-jpegxl-plugin/issues/97
The clarifications have been made, I've pulled them in and updated the package accordingly. Spec URL: https://ngompa.fedorapeople.org/for-review/python-pillow-jxl-plugin.spec SRPM URL: https://ngompa.fedorapeople.org/for-review/python-pillow-jxl-plugin-1.3.2-1.fc41.src.rpm
Created attachment 2081487 [details] The .spec file difference from Copr build 8804300 to 8806380
Copr build: https://copr.fedorainfracloud.org/coprs/build/8806380 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2354261-python-pillow-jxl-plugin/fedora-rawhide-x86_64/08806380-python-pillow-jxl-plugin/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Thank you, this looks good to me now. Note that I haven't verified that this plugin actually works. I don't use any programs that use Pillow for loading images. :) ============== Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: Package must own all directories that it creates. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 2252 bytes in 1 files. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [-]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. [x]: Package should compile and build into binary rpms on all supported architectures. [~]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python3-pillow-jxl-plugin-1.3.2-1.fc43.x86_64.rpm python-pillow-jxl-plugin-1.3.2-1.fc43.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpfg5kz8e5')] checks: 32, packages: 2 2 packages and 0 specfiles checked; 0 errors, 0 warnings, 7 filtered, 0 badness; has taken 0.3 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 3 filtered, 0 badness; has taken 0.1 s Unversioned so-files -------------------- python3-pillow-jxl-plugin: /usr/lib64/python3.13/site-packages/pillow_jxl/pillow_jxl.cpython-313-x86_64-linux-gnu.so Source checksums ---------------- https://files.pythonhosted.org/packages/source/p/pillow_jxl_plugin/pillow_jxl_plugin-1.3.2.tar.gz : CHECKSUM(SHA256) this package : 79f0687a4f3250547e02b852e79966f45d9786467bfc8dc6b1271011ef14ff62 CHECKSUM(SHA256) upstream package : 79f0687a4f3250547e02b852e79966f45d9786467bfc8dc6b1271011ef14ff62 Requires -------- python3-pillow-jxl-plugin (rpmlib, GLIBC filtered): ld-linux-x86-64.so.2()(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3)(64bit) libgcc_s.so.1(GCC_4.2.0)(64bit) libjxl.so.0.11()(64bit) libjxl.so.0.11(JXL_0)(64bit) libjxl_threads.so.0.11()(64bit) libjxl_threads.so.0.11(JXL_0)(64bit) python(abi) python3.13dist(packaging) python3.13dist(pillow) rtld(GNU_HASH) Provides -------- python3-pillow-jxl-plugin: python-pillow-jxl-plugin python3-pillow-jxl-plugin python3-pillow-jxl-plugin(x86-64) python3.13-pillow-jxl-plugin python3.13dist(pillow-jxl-plugin) python3dist(pillow-jxl-plugin)
The Pagure repository was created at https://src.fedoraproject.org/rpms/python-pillow-jxl-plugin
FEDORA-2025-5d660686f4 (python-pillow-jxl-plugin-1.3.2-1.fc43) has been submitted as an update to Fedora 43. https://bodhi.fedoraproject.org/updates/FEDORA-2025-5d660686f4
FEDORA-2025-cf5a053d32 (python-pillow-jxl-plugin-1.3.2-1.fc42) has been submitted as an update to Fedora 42. https://bodhi.fedoraproject.org/updates/FEDORA-2025-cf5a053d32
FEDORA-2025-5d660686f4 (python-pillow-jxl-plugin-1.3.2-1.fc43) has been pushed to the Fedora 43 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2025-cf5a053d32 (python-pillow-jxl-plugin-1.3.2-1.fc42) has been pushed to the Fedora 42 stable repository. If problem still persists, please make note of it in this bug report.