Documentation is disabled until I have the time to bring the missing package in Fedora through another review.

Copr build:
https://copr.fedorainfracloud.org/coprs/build/8823838
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2355085-lcevcdec/fedora-rawhide-x86_64/08823838-LCEVCdec/fedora-review/review.txt

Found issues:

- Not a valid SPDX expression 'BSD-3-Clause-Clear'.
  Read more: https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_1

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Approved.

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
=======
- The License field must be a valid SPDX expression.
  Note: Not a valid SPDX expression 'BSD-3-Clause-Clear'.
  See: https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_1

The license seems valid

https://spdx.org/licenses/BSD-3-Clause-Clear.html


===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: If your application is a C or C++ application you must list a
     BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig not called in %post and %postun for Fedora 28 and later.
[x]: Package does not contain any libtool archives (.la)
[x]: Package contains no static executables.
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "BSD 3-Clause Clear License", "BSD
     3-Clause License", "MIT License and/or University of Illinois/NCSA
     Open Source License", "MIT License". 64 files have unknown license.
     Detailed output of licensecheck in
     /home/leigh/Desktop/2355085-LCEVCdec/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[ ]: Package consistently uses macros (instead of hard-coded directory
 x   names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: Static libraries in -static or -devel subpackage, providing -devel if
     present.
     Note: Package has .a files: LCEVCdec-static.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 1534 bytes in 1 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[?]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
     LCEVCdec-static , LCEVCdec-samples
[?]: Package functions as described.
[?]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Patches link to upstream bugs/comments/lists or are otherwise
     justified.
[?]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[?]: Package should compile and build into binary rpms on all supported
     architectures.
[?]: %check is present and all tests pass.
[?]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: The placement of pkgconfig(.pc) files are correct.
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on debuginfo package(s).
     Note: There are rpmlint messages (see attachment).
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: LCEVCdec-3.3.5-1.fc43.x86_64.rpm
          LCEVCdec-devel-3.3.5-1.fc43.x86_64.rpm
          LCEVCdec-static-3.3.5-1.fc43.x86_64.rpm
          LCEVCdec-samples-3.3.5-1.fc43.x86_64.rpm
          LCEVCdec-3.3.5-1.fc43.src.rpm
============================ rpmlint session starts ============================
rpmlint: 2.7.0
configuration:
    /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmpzehhmt3_')]
checks: 32, packages: 5

LCEVCdec-static.x86_64: E: static-library-without-debuginfo /usr/lib64/liblcevc_dec_api_utility.a
LCEVCdec-static.x86_64: E: static-library-without-debuginfo /usr/lib64/liblcevc_dec_core_sequencing.a
LCEVCdec-static.x86_64: E: static-library-without-debuginfo /usr/lib64/liblcevc_dec_unit_test_utilities.a
LCEVCdec-static.x86_64: E: static-library-without-debuginfo /usr/lib64/liblcevc_dec_utility.a
LCEVCdec.src: E: spelling-error ('bitstreams', '%description -l en_US bitstreams -> bit streams, bit-streams, streams')
LCEVCdec.src: E: spelling-error ('colour', '%description -l en_US colour -> color, co lour, co-lour')
LCEVCdec.x86_64: E: spelling-error ('bitstreams', '%description -l en_US bitstreams -> bit streams, bit-streams, streams')
LCEVCdec.x86_64: E: spelling-error ('colour', '%description -l en_US colour -> color, co lour, co-lour')
LCEVCdec-samples.x86_64: W: no-manual-page-for-binary lcevc_core_sequencing_test_unit
LCEVCdec-samples.x86_64: W: no-manual-page-for-binary lcevc_core_test_unit
LCEVCdec-samples.x86_64: W: no-manual-page-for-binary lcevc_dec_sample
LCEVCdec-samples.x86_64: W: no-manual-page-for-binary lcevc_dec_test_harness
LCEVCdec-samples.x86_64: W: no-manual-page-for-binary lcevc_dec_test_unit
LCEVCdec-samples.x86_64: W: no-manual-page-for-binary lcevc_dec_utility_test_unit
LCEVCdec-devel.x86_64: W: no-documentation
LCEVCdec-samples.x86_64: W: no-documentation
LCEVCdec-static.x86_64: W: no-documentation
LCEVCdec.src: W: invalid-license BSD-3-Clause-Clear
LCEVCdec.x86_64: W: invalid-license BSD-3-Clause-Clear
LCEVCdec-devel.x86_64: W: invalid-license BSD-3-Clause-Clear
LCEVCdec-samples.x86_64: W: invalid-license BSD-3-Clause-Clear
LCEVCdec-static.x86_64: W: invalid-license BSD-3-Clause-Clear
 5 packages and 0 specfiles checked; 8 errors, 14 warnings, 34 filtered, 8 badness; has taken 1.3 s 




Rpmlint (debuginfo)
-------------------
Checking: LCEVCdec-debuginfo-3.3.5-1.fc43.x86_64.rpm
          LCEVCdec-samples-debuginfo-3.3.5-1.fc43.x86_64.rpm
============================ rpmlint session starts ============================
rpmlint: 2.7.0
configuration:
    /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmpp0x09xxw')]
checks: 32, packages: 2

LCEVCdec-debuginfo.x86_64: W: invalid-license BSD-3-Clause-Clear
LCEVCdec-samples-debuginfo.x86_64: W: invalid-license BSD-3-Clause-Clear
 2 packages and 0 specfiles checked; 0 errors, 2 warnings, 28 filtered, 0 badness; has taken 1.6 s 





Rpmlint (installed packages)
----------------------------
============================ rpmlint session starts ============================
rpmlint: 2.7.0
configuration:
    /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 6

LCEVCdec.x86_64: E: unused-direct-shlib-dependency /usr/lib64/liblcevc_dec_api.so.3.3.5 /lib64/libm.so.6
LCEVCdec.x86_64: E: undefined-non-weak-symbol /usr/lib64/liblcevc_dec_core.so.3.3.5 log	(/usr/lib64/liblcevc_dec_core.so.3.3.5)
LCEVCdec-static.x86_64: E: static-library-without-debuginfo /usr/lib64/liblcevc_dec_api_utility.a
LCEVCdec-static.x86_64: E: static-library-without-debuginfo /usr/lib64/liblcevc_dec_core_sequencing.a
LCEVCdec-static.x86_64: E: static-library-without-debuginfo /usr/lib64/liblcevc_dec_unit_test_utilities.a
LCEVCdec-static.x86_64: E: static-library-without-debuginfo /usr/lib64/liblcevc_dec_utility.a
LCEVCdec.x86_64: E: spelling-error ('bitstreams', '%description -l en_US bitstreams -> bit streams, bit-streams, streams')
LCEVCdec.x86_64: E: spelling-error ('colour', '%description -l en_US colour -> color, co lour, co-lour')
LCEVCdec-samples.x86_64: W: no-manual-page-for-binary lcevc_core_sequencing_test_unit
LCEVCdec-samples.x86_64: W: no-manual-page-for-binary lcevc_core_test_unit
LCEVCdec-samples.x86_64: W: no-manual-page-for-binary lcevc_dec_sample
LCEVCdec-samples.x86_64: W: no-manual-page-for-binary lcevc_dec_test_harness
LCEVCdec-samples.x86_64: W: no-manual-page-for-binary lcevc_dec_test_unit
LCEVCdec-samples.x86_64: W: no-manual-page-for-binary lcevc_dec_utility_test_unit
LCEVCdec-samples.x86_64: W: no-documentation
LCEVCdec-devel.x86_64: W: no-documentation
LCEVCdec-static.x86_64: W: no-documentation
LCEVCdec-samples.x86_64: W: invalid-license BSD-3-Clause-Clear
LCEVCdec-samples-debuginfo.x86_64: W: invalid-license BSD-3-Clause-Clear
LCEVCdec-devel.x86_64: W: invalid-license BSD-3-Clause-Clear
LCEVCdec-static.x86_64: W: invalid-license BSD-3-Clause-Clear
LCEVCdec-debuginfo.x86_64: W: invalid-license BSD-3-Clause-Clear
LCEVCdec.x86_64: W: invalid-license BSD-3-Clause-Clear
 6 packages and 0 specfiles checked; 8 errors, 15 warnings, 64 filtered, 8 badness; has taken 2.0 s 



Source checksums
----------------
https://github.com/v-novaltd/LCEVCdec/archive/3.3.5.tar.gz#/LCEVCdec-3.3.5.tar.gz :
  CHECKSUM(SHA256) this package     : 91bdbdaf104095d432f6f34954a342e216d088ad498c856407e3accf74bab7a2
  CHECKSUM(SHA256) upstream package : 91bdbdaf104095d432f6f34954a342e216d088ad498c856407e3accf74bab7a2


Requires
--------
LCEVCdec (rpmlib, GLIBC filtered):
    libc.so.6()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libgcc_s.so.1(GCC_3.3.1)(64bit)
    liblcevc_dec_core.so.3()(64bit)
    libm.so.6()(64bit)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    libstdc++.so.6(CXXABI_1.3.5)(64bit)
    libstdc++.so.6(CXXABI_1.3.9)(64bit)
    rtld(GNU_HASH)

LCEVCdec-devel (rpmlib, GLIBC filtered):
    /usr/bin/pkg-config
    LCEVCdec(x86-64)
    liblcevc_dec_api.so.3()(64bit)
    liblcevc_dec_core.so.3()(64bit)
    plutovg-devel(x86-64)

LCEVCdec-static (rpmlib, GLIBC filtered):
    LCEVCdec-devel(x86-64)

LCEVCdec-samples (rpmlib, GLIBC filtered):
    libavcodec.so.61()(64bit)
    libavcodec.so.61(LIBAVCODEC_61)(64bit)
    libavfilter.so.10()(64bit)
    libavfilter.so.10(LIBAVFILTER_10)(64bit)
    libavformat.so.61()(64bit)
    libavformat.so.61(LIBAVFORMAT_61)(64bit)
    libavutil.so.59()(64bit)
    libavutil.so.59(LIBAVUTIL_59)(64bit)
    libc.so.6()(64bit)
    libfmt.so.11()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libgcc_s.so.1(GCC_3.3.1)(64bit)
    libgtest.so.1.15.2()(64bit)
    libgtest_main.so.1.15.2()(64bit)
    liblcevc_dec_api.so.3()(64bit)
    liblcevc_dec_core.so.3()(64bit)
    libm.so.6()(64bit)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    libstdc++.so.6(CXXABI_1.3.11)(64bit)
    libstdc++.so.6(CXXABI_1.3.13)(64bit)
    libstdc++.so.6(CXXABI_1.3.15)(64bit)
    libstdc++.so.6(CXXABI_1.3.2)(64bit)
    libstdc++.so.6(CXXABI_1.3.3)(64bit)
    libstdc++.so.6(CXXABI_1.3.5)(64bit)
    libstdc++.so.6(CXXABI_1.3.9)(64bit)
    libxxhash.so.0()(64bit)
    rtld(GNU_HASH)



Provides
--------
LCEVCdec:
    LCEVCdec
    LCEVCdec(x86-64)
    liblcevc_dec_api.so.3()(64bit)
    liblcevc_dec_core.so.3()(64bit)

LCEVCdec-devel:
    LCEVCdec-devel
    LCEVCdec-devel(x86-64)
    pkgconfig(lcevc_dec)

LCEVCdec-static:
    LCEVCdec-static
    LCEVCdec-static(x86-64)

LCEVCdec-samples:
    LCEVCdec-samples
    LCEVCdec-samples(x86-64)



Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24
Command line :/usr/bin/fedora-review -b 2355085
Buildroot used: fedora-rawhide-x86_64
Active plugins: C/C++, Generic, Shell-api
Disabled plugins: R, Python, fonts, PHP, Perl, SugarActivity, Ocaml, Java, Haskell
Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH

The Pagure repository was created at https://src.fedoraproject.org/rpms/LCEVCdec

Bummer, I just noticed now that the license is explicitly, in the not allowed list. This is a no go. Thanks anyway.

https://docs.fedoraproject.org/en-US/legal/not-allowed-licenses/