Bug 2355945 - Review Request: cargs - command line argument library for C/C++
Summary: Review Request: cargs - command line argument library for C/C++
Keywords:
Status: NEW
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2025-03-29 16:24 UTC by zuhhaga
Modified: 2025-05-21 17:29 UTC (History)
4 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed:
Type: ---
Embargoed:


Attachments (Terms of Use)

Description zuhhaga 2025-03-29 16:24:54 UTC
Spec URL: https://download.copr.fedorainfracloud.org/results/huakim/kde-plasma/srpm-builds/08832392/cargs.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/huakim/kde-plasma/srpm-builds/08832392/cargs-1.2.0-01.src.rpm
Description: This is a lighweight C command line argument library which does not require any malloc. It is currently compiled and tested under Linux, FreeBSD, macOS and Windows.
Fedora Account System Username: huakim

Comment 1 Benson Muite 2025-03-29 16:34:06 UTC
Consider enabling tests.

Can the documentation be packaged?

Add a changelog, if using %autorelease macro, please also use %autochangelog

Comment 2 Artur Frenszek-Iwicki 2025-03-29 17:40:30 UTC
> License:        LGPL
Looking at LICENSE.md, this should be "MIT".
Please also add the file to %files (and mark as %license).
https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text

> Summary:        A lightweight cross-platform getopt alternative that is tested on Linux, Windows, FreeBSD and macOS..
1. The summary should be no longer than 80 characters.
2. Do not end the summary with a period.
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_summary_and_description

The %description should be wrapped to a maximum of 80 characters per line, as well.

Comment 3 zuhhaga 2025-03-29 19:10:54 UTC
Spec URL: https://download.copr.fedorainfracloud.org/results/huakim/kde-plasma/srpm-builds/08832561/cargs.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/huakim/kde-plasma/srpm-builds/08832561/cargs-1.2.0-01.src.rpm
Description: This is a lighweight C command line argument library which does not require any malloc. It is currently compiled and tested under Linux, FreeBSD, macOS and Windows.
Fedora Account System Username: huakim

Comment 4 zuhhaga 2025-03-29 19:11:30 UTC
(In reply to Artur Frenszek-Iwicki from comment #2)
> > License:        LGPL
> Looking at LICENSE.md, this should be "MIT".
> Please also add the file to %files (and mark as %license).
> https://docs.fedoraproject.org/en-US/packaging-guidelines/
> LicensingGuidelines/#_license_text
> 
> > Summary:        A lightweight cross-platform getopt alternative that is tested on Linux, Windows, FreeBSD and macOS..
> 1. The summary should be no longer than 80 characters.
> 2. Do not end the summary with a period.
> https://docs.fedoraproject.org/en-US/packaging-guidelines/
> #_summary_and_description
> 
> The %description should be wrapped to a maximum of 80 characters per line,
> as well.

I edited at https://download.copr.fedorainfracloud.org/results/huakim/kde-plasma/srpm-builds/08832561/cargs.spec

Comment 5 zuhhaga 2025-03-29 19:12:29 UTC
(In reply to Benson Muite from comment #1)
> Consider enabling tests.
> 
> Can the documentation be packaged?
> 
> Add a changelog, if using %autorelease macro, please also use %autochangelog

I added changelog, documentation package and enabled tests at https://download.copr.fedorainfracloud.org/results/huakim/kde-plasma/srpm-builds/08832561/cargs.spec

Comment 6 Petr Menšík 2025-05-21 17:29:34 UTC
Please upload spec and srpm to fedorapeople.org or other permanent place. Current links do not lead to to a valid target and therefore are blocking the review.

Also please include both links on every update. That would make fedora-review tool pick the latest spec and srpms. I admit it is annoying, but most reviews are done by that tool.


Note You need to log in before you can comment on or make changes to this bug.