Spec URL: https://download.copr.fedorainfracloud.org/results/huakim/kde-plasma/srpm-builds/08832392/cargs.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/huakim/kde-plasma/srpm-builds/08832392/cargs-1.2.0-01.src.rpm Description: This is a lighweight C command line argument library which does not require any malloc. It is currently compiled and tested under Linux, FreeBSD, macOS and Windows. Fedora Account System Username: huakim
Consider enabling tests. Can the documentation be packaged? Add a changelog, if using %autorelease macro, please also use %autochangelog
> License: LGPL Looking at LICENSE.md, this should be "MIT". Please also add the file to %files (and mark as %license). https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text > Summary: A lightweight cross-platform getopt alternative that is tested on Linux, Windows, FreeBSD and macOS.. 1. The summary should be no longer than 80 characters. 2. Do not end the summary with a period. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_summary_and_description The %description should be wrapped to a maximum of 80 characters per line, as well.
Spec URL: https://download.copr.fedorainfracloud.org/results/huakim/kde-plasma/srpm-builds/08832561/cargs.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/huakim/kde-plasma/srpm-builds/08832561/cargs-1.2.0-01.src.rpm Description: This is a lighweight C command line argument library which does not require any malloc. It is currently compiled and tested under Linux, FreeBSD, macOS and Windows. Fedora Account System Username: huakim
(In reply to Artur Frenszek-Iwicki from comment #2) > > License: LGPL > Looking at LICENSE.md, this should be "MIT". > Please also add the file to %files (and mark as %license). > https://docs.fedoraproject.org/en-US/packaging-guidelines/ > LicensingGuidelines/#_license_text > > > Summary: A lightweight cross-platform getopt alternative that is tested on Linux, Windows, FreeBSD and macOS.. > 1. The summary should be no longer than 80 characters. > 2. Do not end the summary with a period. > https://docs.fedoraproject.org/en-US/packaging-guidelines/ > #_summary_and_description > > The %description should be wrapped to a maximum of 80 characters per line, > as well. I edited at https://download.copr.fedorainfracloud.org/results/huakim/kde-plasma/srpm-builds/08832561/cargs.spec
(In reply to Benson Muite from comment #1) > Consider enabling tests. > > Can the documentation be packaged? > > Add a changelog, if using %autorelease macro, please also use %autochangelog I added changelog, documentation package and enabled tests at https://download.copr.fedorainfracloud.org/results/huakim/kde-plasma/srpm-builds/08832561/cargs.spec
Please upload spec and srpm to fedorapeople.org or other permanent place. Current links do not lead to to a valid target and therefore are blocking the review. Also please include both links on every update. That would make fedora-review tool pick the latest spec and srpms. I admit it is annoying, but most reviews are done by that tool.