Spec URL: https://jplesnik.fedorapeople.org/perl-Crypt-URandom-Token/perl-Crypt-URandom-Token.spec SRPM URL: https://jplesnik.fedorapeople.org/perl-Crypt-URandom-Token/perl-Crypt-URandom-Token-0.003-1.fc43.noarch.rpm Description: This module provides a secure way to generate a random token for passwords and similar using Crypt::URandom as the source of random bits. Fedora Account System Username: jplesnik
@jplesnik Some nits * The dependency on coreutils is not needed. Sure? * There are two "NO_PACKLIST=1" * Regarding the module versions and Perl version used. There are >>use v5.20;<<, >>"Crypt::URandom" => "0.40"<< and >>"Test::Exception" => "0.43"<<. Isn't it better to present them in the spec file? I understand that we don't hit this issue, but for common use, it could be better.
(In reply to Michal Josef Spacek from comment #1) > @jplesnik > > Some nits > * The dependency on coreutils is not needed. Sure? It is required for %{_fixperms}, it uses 'chmod'. > * There are two "NO_PACKLIST=1" Good catch, I missed it. > * Regarding the module versions and Perl version used. There are >>use > v5.20;<<, >>"Crypt::URandom" => "0.40"<< and >>"Test::Exception" => > "0.43"<<. Isn't it better to present them in the spec file? I understand > that we don't hit this issue, but for common use, it could be better. I added the version constrain. Updated files are on the same link
Source file is not present, but I think that's ok Summary is ok License is ok Description is ok URL and Source0 are ok All tests passed BuildRequires are ok $ rpm -qp --requires perl-Crypt-URandom-Token-0.003-1.fc43.noarch.rpm | sort | uniq -c | grep -v rpmlib 1 perl(Carp) 1 perl(Crypt::URandom) >= 0.40 1 perl(Exporter) 1 perl-libs 1 perl(strict) 1 perl(:VERSION) >= 5.20.0 1 perl(warnings) Binary requires are Ok. $ rpm -qp --provides perl-Crypt-URandom-Token-0.003-1.fc43.noarch.rpm | sort | uniq -c 1 perl(Crypt::URandom::Token) 1 perl-Crypt-URandom-Token = 0.003-1.fc43 Binary provides are Ok. $ rpmlint ./perl-Crypt-URandom-Token* 2 packages and 1 specfiles checked; 0 errors, 0 warnings, 8 filtered, 0 badness; has taken 0.2 s Rpmlint is ok The package is in line with Fedora and Perl packaging guide lines. Resolution: Approved
The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Crypt-URandom-Token
Thank you for review.