Bug 235679 - Review Request: weechat - Portable, fast, light and extensible IRC client
Review Request: weechat - Portable, fast, light and extensible IRC client
Status: CLOSED NEXTRELEASE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Šimon Lukašík
Fedora Package Reviews List
:
: 238518 (view as bug list)
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2007-04-09 11:40 EDT by Paul P Komkoff Jr
Modified: 2009-05-20 01:32 EDT (History)
3 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2007-05-26 18:47:12 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
lukasim: fedora‑review+
kevin: fedora‑cvs+


Attachments (Terms of Use)

  None (edit)
Description Paul P Komkoff Jr 2007-04-09 11:40:17 EDT
Spec URL: http://palevo.sgu.ru/mockbuild/6/SPECS/weechat.spec
SRPM URL: http://palevo.sgu.ru/mockbuild/6/SRPMS/weechat-0.2.4-2.fc6.src.rpm
Description:
WeeChat (Wee Enhanced Environment for Chat) is a portable, fast, light and
extensible IRC client. Everything can be done with a keyboard.
It is customizable and extensible with scripts.
Comment 1 Šimon Lukašík 2007-05-24 15:39:01 EDT
* MUST: rpmlint must be run on every package. The output should be posted in the
review.
        OK, clear
* MUST: The package must be named according to the Package Naming Guidelines.
        OK
* MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption on Package Naming Guidelines.
        OK
* MUST: The package must meet the Packaging Guidelines.
        OK
* MUST: The package must be licensed with an open-source compatible license and
meet other legal requirements as defined in the legal section of Packaging
Guidelines.
        OK; GPL
* MUST: The License field in the package spec file must match the actual license.
        OK; GPL 2, June 1991
* MUST: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s) for the
package must be included in %doc.
        OK; COPYING
* MUST: The spec file must be written in American English.
        OK
* MUST: The spec file for the package MUST be legible.
        OK
* MUST: The sources used to build the package must match the upstream source, as
provided in the spec URL.
        OK; md5 - c7c7f89d6dac502ad31d12198a8836c1
* MUST: The package must successfully compile and build into binary rpms on at
least one supported architecture.
        OK; i386
* MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in ExcludeArch.
        OK; no ExcluseArch meanwhile; no notice from upstream.
* MUST: All build dependencies must be listed in BuildRequires.
        OK
* MUST: The spec file MUST handle locales properly.
        OK
* MUST: Every binary RPM package which stores shared library files (not just
symlinks) in any of the dynamic linker's default paths, must call ldconfig in
%post and %postun. If the package has multiple subpackages with libraries, each
subpackage should also have a %post/%postun section that calls /sbin/ldconfig.
        OK
* MUST: If the package is designed to be relocatable, the packager must state
this fact in the request for review, along with the rationalization for
relocation of that specific package. Without this, use of Prefix: /usr is
considered a blocker.
        OK
* MUST: A package must own all directories that it creates.
        OK
* MUST: A package must not contain any duplicate files in the %files listing.
        OK
* MUST: Permissions on files must be set properly. Executables should be set
with executable permissions, for example. Every %files section must include a
%defattr(...) line.
        OK
* MUST: Each package must have a %clean section, which contains rm -rf
%{buildroot} (or $RPM_BUILD_ROOT).
        OK
* MUST: Each package must consistently use macros, as described in the macros
section of Packaging Guidelines.
        OK
* MUST: The package must contain code, or permissable content. This is described
in detail in the code vs. content section of Packaging Guidelines.
        OK
* MUST: Large documentation files should go in a -doc subpackage.
        OK
* MUST: If a package includes something as %doc, it must not affect the runtime
of the application.
        OK
* MUST: Header files must be in a -devel package.
        OK; There is no header files in telepathy-idle package.
* MUST: Static libraries must be in a -static package.
        Ok
* MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'
        OK
* MUST: If a package contains library files with a suffix (e.g. libfoo.so.1.1),
then library files that end in .so (without suffix) must go in a -devel package.
        OK, *.so here are symlinks
* MUST: In the vast majority of cases, devel packages must require the base
package using a fully versioned dependency.
        OK; Not devel
* MUST: Packages must NOT contain any .la libtool archives, these should be
removed in the spec.
        OK
* MUST: Packages containing GUI applications must include a %{name}.desktop
file, and that file must be properly installed with desktop-file-install in the
%install section.
        OK; No GUI.
* MUST: Packages must not own files or directories already owned by other packages.
        OK
* MUST: At the beginning of %install, each package MUST run rm -rf %{buildroot}
(or $RPM_BUILD_ROOT).
        OK
* MUST: All filenames in rpm packages must be valid UTF-8.
        OK
-----------------------------------------------------------
APPROVED
-----------------------------------------------------------
Looks fine; Maybe in description/summary there can (not must, I think) be
something about curses(or terminal) environment...
Comment 2 Paul P Komkoff Jr 2007-05-25 01:24:40 EDT
New Package CVS Request
=======================
Package Name: weechat
Short Description: Portable, fast, light and extensible IRC client
Owners: i@stingr.net
Branches: F-6 F-7
InitialCC: 
Comment 3 Nigel Jones 2007-05-25 06:50:21 EDT
*** Bug 238518 has been marked as a duplicate of this bug. ***
Comment 4 Šimon Lukašík 2007-05-25 08:38:03 EDT
Hello, I know it's late, but for next time:

In spec file:

> BuildRoot: %{_tmppath}/%{name}-%{version}-buildroot

Should be:

BuildRoot %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)

It's recommended, see also: "Build root tag" in Fedora wiki
http://fedoraproject.org/wiki/Packaging/Guidelines#head-b4fdd45fa76cbf54c885ef0836361319ab962473

Thanks.

Comment 5 Tom "spot" Callaway 2007-05-25 09:52:43 EDT
cvs done
Comment 6 Ray Van Dolson 2009-05-18 16:10:51 EDT
Package Change Request
======================
Package Name: weechat
New Branches: EL-4 EL-5
Owners: rayvd
Comment 7 Kevin Fenzi 2009-05-18 19:40:06 EDT
Ray: Have you asked Paul if he wants to maintain this in epel and/or has no interest in doing so?
Comment 8 Ray Van Dolson 2009-05-18 20:25:22 EDT
Yes.  Via email.  And he should be CC'd on this in case he wants to pipe up. :-)
Comment 9 Kevin Fenzi 2009-05-20 01:32:27 EDT
ok. 
cvs done.

Note You need to log in before you can comment on or make changes to this bug.