Spec URL: https://samcday.fedorapeople.org/libssc.spec SRPM URL: https://samcday.fedorapeople.org/libssc-0.2.2-1.fc43.src.rpm Description: libssc is a library to expose the sensors managed by the Qualcomm Sensor Core found in many Qualcomm System-on-Chips (SoCs) from 2018 and onwards. Fedora Account System Username: samcday
This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=131021395
Copr build: https://copr.fedorainfracloud.org/coprs/build/8853208 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2356939-libssc/fedora-rawhide-x86_64/08853208-libssc/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Spec URL: https://download.copr.fedorainfracloud.org/results/@mobility/sdm845/fedora-rawhide-aarch64/08854895-libssc/libssc.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/@mobility/sdm845/fedora-rawhide-aarch64/08854895-libssc/libssc-0.2.2-1743670809.fc43.src.rpm --- Added %license
f-r-s was dead, but should be alive again... Spec URL: https://download.copr.fedorainfracloud.org/results/@mobility/sdm845/fedora-rawhide-aarch64/08854895-libssc/libssc.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/@mobility/sdm845/fedora-rawhide-aarch64/08854895-libssc/libssc-0.2.2-1743670809.fc43.src.rpm
Copr build: https://copr.fedorainfracloud.org/coprs/build/8857611 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2356939-libssc/fedora-rawhide-x86_64/08857611-libssc/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Copr build: https://copr.fedorainfracloud.org/coprs/build/8857606 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2356939-libssc/fedora-rawhide-x86_64/08857606-libssc/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GNU Affero General Public License v3.0 or later and/or GNU General Public License, Version 3", "GNU Affero General Public License v3.0 or later". 20 files have unknown license. Detailed output of licensecheck in /home/fedora- packaging/reviews/libssc/2356939-libssc/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/python3.13/site- packages/__pycache__, /usr/lib/python3.13, /usr/lib/python3.13/site- packages Error in fedora-review, these should be owned by python [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [-]: Python eggs must not download any dependencies during the build process. [-]: A package which is used by another package via an egg interface should provide egg info. [ ]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [!]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: The placement of pkgconfig(.pc) files are correct. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: libssc-0.2.2-1743670809.fc43.x86_64.rpm libssc-devel-0.2.2-1743670809.fc43.x86_64.rpm python3-ssc-0.2.2-1743670809.fc43.x86_64.rpm libssc-0.2.2-1743670809.fc43.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.6.1 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp0wgxgq60')] checks: 32, packages: 4 libssc.src: E: spelling-error ('onwards', '%description -l en_US onwards -> inwards, onward, on wards') libssc.x86_64: E: spelling-error ('onwards', '%description -l en_US onwards -> inwards, onward, on wards') python3-ssc.x86_64: E: spelling-error ('libssc', 'Summary(en_US) libssc -> limbless') python3-ssc.x86_64: E: spelling-error ('libssc', '%description -l en_US libssc -> limbless') python3-ssc.x86_64: E: non-executable-script /usr/lib/python3.13/site-packages/qmi.py 644 /usr/bin/env python3 python3-ssc.x86_64: E: non-executable-script /usr/lib/python3.13/site-packages/ssc.py 644 /usr/bin/env python3 libssc.x86_64: W: no-manual-page-for-binary ssc-server libssc.x86_64: W: no-manual-page-for-binary ssc-server-tests libssc.x86_64: W: no-manual-page-for-binary ssccli python3-ssc.x86_64: W: no-documentation python3-ssc.x86_64: E: no-binary libssc.spec: W: no-%check-section libssc.spec:26: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 26) 4 packages and 0 specfiles checked; 7 errors, 6 warnings, 28 filtered, 7 badness; has taken 0.6 s Rpmlint (debuginfo) ------------------- Checking: libssc-debuginfo-0.2.2-1743670809.fc43.x86_64.rpm ============================ rpmlint session starts ============================ rpmlint: 2.6.1 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpuajritp9')] checks: 32, packages: 1 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 11 filtered, 0 badness; has taken 0.3 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 4 libssc.x86_64: E: spelling-error ('onwards', '%description -l en_US onwards -> inwards, onward, on wards') python3-ssc.x86_64: E: spelling-error ('libssc', 'Summary(en_US) libssc -> limbless') python3-ssc.x86_64: E: spelling-error ('libssc', '%description -l en_US libssc -> limbless') python3-ssc.x86_64: E: non-executable-script /usr/lib/python3.13/site-packages/qmi.py 644 /usr/bin/env python3 python3-ssc.x86_64: E: non-executable-script /usr/lib/python3.13/site-packages/ssc.py 644 /usr/bin/env python3 libssc.x86_64: W: no-manual-page-for-binary ssc-server libssc.x86_64: W: no-manual-page-for-binary ssc-server-tests libssc.x86_64: W: no-manual-page-for-binary ssccli python3-ssc.x86_64: W: no-documentation python3-ssc.x86_64: E: no-binary 4 packages and 0 specfiles checked; 6 errors, 4 warnings, 37 filtered, 6 badness; has taken 0.9 s Source checksums ---------------- https://codeberg.org/DylanVanAssche/libssc/archive/v0.2.2.tar.gz : CHECKSUM(SHA256) this package : 4d9e2ae4b0548f19ad53a56d365d72e31d2bb72b4ce7b234a2b69875bc24268f CHECKSUM(SHA256) upstream package : 4d9e2ae4b0548f19ad53a56d365d72e31d2bb72b4ce7b234a2b69875bc24268f Requires -------- libssc (rpmlib, GLIBC filtered): /usr/bin/python3 libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libm.so.6()(64bit) libprotobuf-c.so.1()(64bit) libprotobuf-c.so.1(LIBPROTOBUF_C_1.0.0)(64bit) libqmi-glib.so.5()(64bit) libqrtr-glib.so.0()(64bit) libssc.so.0()(64bit) rtld(GNU_HASH) libssc-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config libssc(x86-64) libssc.so.0()(64bit) pkgconfig(gio-2.0) pkgconfig(glib-2.0) pkgconfig(gobject-2.0) pkgconfig(libprotobuf-c) pkgconfig(qmi-glib) python3-ssc (rpmlib, GLIBC filtered): libssc(x86-64) python(abi) Provides -------- libssc: libssc libssc(x86-64) libssc.so.0()(64bit) libssc-devel: libssc-devel libssc-devel(x86-64) pkgconfig(libssc) python3-ssc: python-ssc python3-ssc python3-ssc(x86-64) python3.13-ssc Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2356939 Buildroot used: fedora-rawhide-x86_64 Active plugins: Python, Generic, C/C++, Shell-api Disabled plugins: PHP, Java, Haskell, R, Ocaml, SugarActivity, Perl, fonts Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH Comments: a) Python package may conflict with: https://pypi.org/project/ssc/ Consider asking upstream to register a name on pypi and use that to create a subdirectory in %{python3_sitelib} b) Consider using help2man o create man pages if possible. Not a must, but nice to have. c) Consider using %autorelease, to match %autochangelog d) Many files contain AGPL-3.0-or-later not GPL-3.0-or-later, check with upstream on correct license. If AGPL-3.0-or-later please get upstream to add this e) Can some of the tests be run? f) Can documentation be packaged?