This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=131021522

Copr build:
https://copr.fedorainfracloud.org/coprs/build/8853223
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2356940-bootmac/fedora-rawhide-x86_64/08853223-bootmac/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Hi!

I tried taking a look at this package as a non-binding review. I am not a Fedora Packager yet, but as part of the pre-requisites to become one I am trying to review existing packages in the queue to get familiar with the basics and some of the philosophy behind various design decisions.

I spotted a few things so far in the current SPEC:

The line:
```
%global debug_package %{nil}
```

Should not be needed as the package is a `noarch` package without any ELF objects with debuginfo, so there can be no debuginfo.

The `-p` flag should be used for `install` arguments to preserve timestamps, e.g.:

```
install -Dpm755 bootmac -t %{buildroot}%{_bindir}/
```

At a package level, I'm not too familiar with the codebase here but I'm wondering if there's a particular reason why the `bootmac-wifi.rules` from upstream have been included, but the `bootmac-bluetooth.rules` equivalent for Bluetooth has not?

This is an automatic check from review-stats script.

This review request ticket hasn't been updated for some time. We're sorry
it is taking so long. If you're still interested in packaging this software
into Fedora repositories, please respond to this comment clearing the
NEEDINFO flag.

You may want to update the specfile and the src.rpm to the latest version
available and to propose a review swap on Fedora devel mailing list to increase
chances to have your package reviewed. If this is your first package and you
need a sponsor, you may want to post some informal reviews. Read more at
https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group.

Without any reply, this request will shortly be considered abandoned
and will be closed.
Thank you for your patience.

Thanks for taking a look at this, Alex.

I've decided to drop this review request, as I've since discovered a better approach (`local-bd-addr`/`local-mac-address` FDT patching from bootloader) that has less legacy baggage attached as bootmac does.