Bugzilla (bugzilla.redhat.com) will be under maintenance for infrastructure upgrades and will not be unavailable on July 31st between 12:30 AM - 05:30 AM UTC. We appreciate your understanding and patience. You can follow status.redhat.com for details.
Bug 235731 - Review Request: openbsd-malloc - Alternative malloc() implementation
Summary: Review Request: openbsd-malloc - Alternative malloc() implementation
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Package Reviews List
URL:
Whiteboard:
Depends On:
Blocks: FE-DEADREVIEW
TreeView+ depends on / blocked
 
Reported: 2007-04-09 20:19 UTC by Peter Lemenkov
Modified: 2008-06-22 17:14 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2008-06-22 04:32:49 UTC
Type: ---

Attachments (Terms of Use)
Add an attachment (proposed patch, testcase, etc.)

Description Peter Lemenkov 2007-04-09 20:19:44 UTC 
Spec URL: http://lemenkov.googlepages.com/openbsd-malloc.spec
SRPM URL: http://lemenkov.googlepages.com/openbsd-malloc-0-1.src.rpm

Description: This package contains experimental alternative to glibc
implementation of malloc() which is prone to heap fragmentation
due to use of deprecated brk() syscall; one might find it useful
to reduce e.g. Firefox memory consumption (though reportedly
won't work with e.g. Emacs).

Use openbsd-malloc some-program to run some-program this way.
Comment 1 Peter Gordon 2007-04-09 20:49:41 UTC 
Please ensure that your build honors the RPM build flags by adding %{optflags}
(or $RPM_OPT_FLAGS) to the gcc invocation:

%build
gcc -shared -fPIC %{optflags} %{SOURCE0} -o malloc.so
Comment 2 Peter Lemenkov 2007-04-10 04:45:53 UTC 
(In reply to comment #1)
> Please ensure that your build honors the RPM build flags by adding %{optflags}
> (or $RPM_OPT_FLAGS) to the gcc invocation:
> 
> %build
> gcc -shared -fPIC %{optflags} %{SOURCE0} -o malloc.so

Done.

http://lemenkov.googlepages.com/openbsd-malloc.spec
http://lemenkov.googlepages.com/openbsd-malloc-0-2.src.rpm
Comment 3 Peter Lemenkov 2007-04-11 06:00:57 UTC 
New version:

http://lemenkov.googlepages.com/openbsd-malloc.spec
http://lemenkov.googlepages.com/openbsd-malloc-0-3.src.rpm
Comment 4 Ralf Corsepius 2007-04-11 06:34:09 UTC 
Some remarks:

1. MUSTFIX:

This spec doesn't apply $RPM_BUILD_ROOT. It compiles and places its files
directly into */BUILD.

One way to approach this:
%setup -c -T

2. Is there an agreement with the glibc developers upon using the name
libmalloc.*? To me, this name appears as too general.

3. http://mr.himki.net/index-alloc.html is in a Cyrillan written language
(Russian?). An English version would be helpful, because except of the source
code there doesn't seem to be any other documentation.

4. The source file seems to be intended to be used as a preloaded module:

From the source code:
 * Compilation: gcc -shared -fPIC -O2 OpenBSD_malloc_Linux.c -o malloc.so   
 * Launching: LD_PRELOAD=/path/to/malloc.so firefox

I am not sure if packaging it as a library is a wise decision.
Comment 5 Peter Lemenkov 2007-05-12 16:11:07 UTC 
(In reply to comment #4)

> 1. MUSTFIX:
> 
> This spec doesn't apply $RPM_BUILD_ROOT. It compiles and places its files
> directly into */BUILD.
> 
> One way to approach this:
> %setup -c -T

Done.
> 
> 2. Is there an agreement with the glibc developers upon using the name
> libmalloc.*? To me, this name appears as too general.

Renamed.
 
> 3. http://mr.himki.net/index-alloc.html109 is in a Cyrillan written language
> (Russian?). An English version would be helpful, because except of the source
> code there doesn't seem to be any other documentation.

OK, I'll try to add something more valuable docs.

> 4. The source file seems to be intended to be used as a preloaded module:
> I am not sure if packaging it as a library is a wise decision.

Hmmm. Are any recomendations about handling of preloaded libraries?

http://lemenkov.googlepages.com/openbsd-malloc.spec
http://lemenkov.googlepages.com/openbsd-malloc-0-4.src.rpm
Comment 6 Jason Tibbitts 2008-01-28 00:57:46 UTC 
Note that this built for me in mock on rawhide but did not install:

mock: /usr/bin/yum --installroot /mock/fedora-development-x86_64/root/  install
/mock/fedora-development-x86_64/result/openbsd-malloc-0-4.fc9.x86_64.rpm
/mock/fedora-development-x86_64/result/openbsd-malloc-debuginfo-0-4.fc9.x86_64.rpm
Error: Missing Dependency: ld-linux-x86-64.so.2(GLIBC_PRIVATE)(64bit) is needed
by package openbsd-malloc
Comment 7 Peter Lemenkov 2008-06-22 04:32:49 UTC 
I'm no longer interested in packaging this.
Note You need to log in before you can comment on or make changes to this bug.