Bug 2357920 (rust-uefi-macros) - Review Request: rust-uefi-macros - Procedural macros for the uefi crate
Summary: Review Request: rust-uefi-macros - Procedural macros for the uefi crate
Keywords:
Status: CLOSED ERRATA
Alias: rust-uefi-macros
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/uefi-macros
Whiteboard:
Depends On: rust-uefi-raw
Blocks: rust-uefi
TreeView+ depends on / blocked
 
Reported: 2025-04-07 14:43 UTC by Gerd Hoffmann
Modified: 2025-05-21 02:16 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2025-05-21 02:04:57 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)
The .spec file difference from Copr build 8867891 to 8891279 (481 bytes, patch)
2025-04-11 13:49 UTC, Fedora Review Service
no flags Details | Diff
The .spec file difference from Copr build 8891279 to 9010546 (329 bytes, patch)
2025-05-08 08:39 UTC, Fedora Review Service
no flags Details | Diff

Comment 1 Fedora Review Service 2025-04-07 14:56:18 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8867891
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2357920-rust-uefi-macros/fedora-rawhide-x86_64/08867891-rust-uefi-macros/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Fedora Review Service 2025-04-11 13:49:40 UTC
Created attachment 2084437 [details]
The .spec file difference from Copr build 8867891 to 8891279

Comment 4 Fedora Review Service 2025-04-11 13:49:42 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8891279
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2357920-rust-uefi-macros/fedora-rawhide-x86_64/08891279-rust-uefi-macros/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 6 Fedora Review Service 2025-05-08 08:39:18 UTC
Created attachment 2088976 [details]
The .spec file difference from Copr build 8891279 to 9010546

Comment 7 Fedora Review Service 2025-05-08 08:39:21 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/9010546
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2357920-rust-uefi-macros/fedora-rawhide-x86_64/09010546-rust-uefi-macros/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 8 Fabio Valentini 2025-05-10 15:21:51 UTC
Package was generated with rust2rpm, simplifying the review.

✅ package contains only permissible content
✅ package builds and installs without errors on rawhide
🫤 test suite is run and all unit tests pass
   (disabled to resolve a circular dependency with the "uefi" crate)
✅ latest version of the crate is packaged
✅ license matches upstream specification and is acceptable for Fedora
✅ license files are included with %license in %files
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter (*NOT* pre-release filter): alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- set bugzilla assignee overrides to @rust-sig (optional)

===

If you have time, it would be great if you could review a pending package in turn:
https://fedoraproject.org/PackageReviewStatus/reviewable.html

Comment 9 Fedora Admin user for bugzilla script actions 2025-05-12 07:41:22 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-uefi-macros

Comment 10 Fedora Update System 2025-05-12 09:19:11 UTC
FEDORA-2025-3944f5e566 (rust-uefi-macros-0.18.1-2.fc42) has been submitted as an update to Fedora 42.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-3944f5e566

Comment 11 Fedora Update System 2025-05-12 11:55:26 UTC
FEDORA-2025-da8810be56 (rust-uefi-macros-0.18.1-2.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-da8810be56

Comment 12 Fedora Update System 2025-05-13 01:56:45 UTC
FEDORA-2025-3944f5e566 has been pushed to the Fedora 42 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-3944f5e566 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-3944f5e566

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 13 Fedora Update System 2025-05-13 02:54:57 UTC
FEDORA-2025-da8810be56 has been pushed to the Fedora 41 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-da8810be56 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-da8810be56

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 14 Fedora Update System 2025-05-21 02:04:57 UTC
FEDORA-2025-da8810be56 (rust-uefi-macros-0.18.1-2.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 15 Fedora Update System 2025-05-21 02:16:30 UTC
FEDORA-2025-3944f5e566 (rust-uefi-macros-0.18.1-2.fc42) has been pushed to the Fedora 42 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.