Bug 2358213 - Review Request: chinese-segmentation - Chinese segmentation software [NEEDINFO]
Summary: Review Request: chinese-segmentation - Chinese segmentation software
Keywords:
Status: NEW
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL: https://gitee.com/openkylin/chinese-s...
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2025-04-08 08:22 UTC by Benson Muite
Modified: 2026-09-03 15:18 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed:
Type: ---
Embargoed:
Tom.Rix: fedora-review?
package-review: needinfo? (Tom.Rix)


Attachments (Terms of Use)

Description Benson Muite 2025-04-08 08:22:18 UTC
spec: https://fed500.fedorapeople.org/chinese-segmentation.spec
srpm: https://fed500.fedorapeople.org/chinese-segmentation-0.^20240206git4a6b092-1.fc41.src.rpm

description:
Convert hanzi to pinyin and traditional chinese to simplified.

fas: fed500

Reproducible: Always

Comment 1 Tom.Rix 2025-04-11 15:34:49 UTC
srpm link in broken, fedorpeople -> fedorapeople

Comment 2 Benson Muite 2025-04-11 15:53:32 UTC
Edited it. Will likely need to update download link as Gitee requires authentication from most ip addresses, so may need to add a comment about that.

Comment 3 Tom.Rix 2025-08-05 13:20:38 UTC
Thanks for the update, I was able to run a local fedora-review, I think there is an issue with the source, here is the first part of the output.

Issues:
=======
- Dist tag is present.
- Sources used to build the package match the upstream source, as provided
  in the spec URL.
  Note: Upstream MD5sum check error, diff is in /sfs/fedora-review/review-
  chinese-segmentation/diff.txt
  See: https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/

can you review your src and the upstream's ?

Comment 5 Fedora Review Service 2025-08-06 13:53:18 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/9381360
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2358213-chinese-segmentation/fedora-rawhide-x86_64/09381360-chinese-segmentation/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 6 Tom.Rix 2025-08-24 16:14:27 UTC
How are you running the fedora-review command? it is stumbling on source0,1 

How are you getting this line ?
License:        GPL-3.0-or-later AND MIT AND NTP

[!]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.

It looks like this project has a few bundled projects with their license files stripped out, these are the ones i could easily find.

This is the cppjieba/limonp is really this
https://github.com/yanyiwu/limonp/tree/master/include/limonp

And cppjiaba is really this
https://github.com/yanyiwu/cppjieba

A package can not strip other embedded license files.

Comment 7 Package Review 2026-08-25 00:45:28 UTC
This is an automatic check from review-stats script.

This review request ticket hasn't been updated for some time, but it seems
that the review is still being working out by you. If this is right, please
respond to this comment clearing the NEEDINFO flag and try to reach out the
submitter to proceed with the review.

If you're not interested in reviewing this ticket anymore, please clear the
fedora-review flag and reset the assignee, so that a new reviewer can take
this ticket.

Without any reply, this request will shortly be resetted.


Note You need to log in before you can comment on or make changes to this bug.