Spec URL: https://gist.github.com/xanderlent/996108c5b368354573f03da4083330d0/raw/cbbd6b5035cc52491f5582a47ac0547fb30c7565/rust-macro_rules_attribute-proc_macro.spec SRPM URL: https://gist.github.com/xanderlent/996108c5b368354573f03da4083330d0/raw/cbbd6b5035cc52491f5582a47ac0547fb30c7565/rust-macro_rules_attribute-proc_macro-0.2.0-1.fc43.src.rpm Description: Use declarative macros as proc_macro attributes or derives Fedora Account System Username: xanderlent This is a dependency of rust-macro_rules_attribute, which is a dependency of rust-tokenziers. This is another small library, though it required a license fix-up which made the package more complex.
Copr build: https://copr.fedorainfracloud.org/coprs/build/8881507 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2358541-rust-macro_rules_attribute-proc_macro/fedora-rawhide-x86_64/08881507-rust-macro_rules_attribute-proc_macro/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated The spec file is generated by rust2rpm, simplifying the review. Issues: ======= - Package does not contain duplicates in %files. Note: warning: File listed twice: /usr/share/cargo/registry/macro_rules_attribute-proc_macro-0.2.0/LICENSE- APACHE See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_duplicate_files Not a serious problem; due to a reasonable rust2rpm design decision. - The Cargo.toml patch changing the license expression *really* needs an explanatory comment and upstream status. Linking https://github.com/danielhenrymantilla/macro_rules_attribute-rs/commit/ddcf04f30717c80a37911cb311dac5dc20c35ae6 should suffice. ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* Apache License 2.0", "MIT License", "zlib License". 4 files have unknown license. Detailed output of licensecheck in /home/ben/fedora/review/2358541-rust- macro_rules_attribute-proc_macro/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [-]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in rust- macro_rules_attribute-proc_macro-devel , rust-macro_rules_attribute- proc_macro+default-devel , rust-macro_rules_attribute- proc_macro+verbose-expansions-devel [?]: Package functions as described. Tests are correctly built and run, but zero tests actually run. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [!]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. https://koji.fedoraproject.org/koji/taskinfo?taskID=132942395 [-]: %check is present and all tests pass. Tests are correctly built and run, but zero tests actually run. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: rust-macro_rules_attribute-proc_macro-devel-0.2.0-1.fc43.noarch.rpm rust-macro_rules_attribute-proc_macro+default-devel-0.2.0-1.fc43.noarch.rpm rust-macro_rules_attribute-proc_macro+verbose-expansions-devel-0.2.0-1.fc43.noarch.rpm rust-macro_rules_attribute-proc_macro-0.2.0-1.fc43.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpq7axi10q')] checks: 32, packages: 4 rust-macro_rules_attribute-proc_macro-devel.noarch: W: no-documentation rust-macro_rules_attribute-proc_macro+verbose-expansions-devel.noarch: E: description-line-too-long use the "verbose-expansions" feature of the "macro_rules_attribute-proc_macro" crate. 4 packages and 0 specfiles checked; 1 errors, 1 warnings, 19 filtered, 1 badness; has taken 0.1 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 3 rust-macro_rules_attribute-proc_macro-devel.noarch: W: no-documentation rust-macro_rules_attribute-proc_macro+verbose-expansions-devel.noarch: E: description-line-too-long use the "verbose-expansions" feature of the "macro_rules_attribute-proc_macro" crate. 3 packages and 0 specfiles checked; 1 errors, 1 warnings, 15 filtered, 1 badness; has taken 0.0 s Source checksums ---------------- https://crates.io/api/v1/crates/macro_rules_attribute-proc_macro/0.2.0/download#/macro_rules_attribute-proc_macro-0.2.0.crate : CHECKSUM(SHA256) this package : b8dd856d451cc0da70e2ef2ce95a18e39a93b7558bedf10201ad28503f918568 CHECKSUM(SHA256) upstream package : b8dd856d451cc0da70e2ef2ce95a18e39a93b7558bedf10201ad28503f918568 Requires -------- rust-macro_rules_attribute-proc_macro-devel (rpmlib, GLIBC filtered): cargo rust-macro_rules_attribute-proc_macro+default-devel (rpmlib, GLIBC filtered): cargo crate(macro_rules_attribute-proc_macro) rust-macro_rules_attribute-proc_macro+verbose-expansions-devel (rpmlib, GLIBC filtered): cargo crate(macro_rules_attribute-proc_macro) Provides -------- rust-macro_rules_attribute-proc_macro-devel: crate(macro_rules_attribute-proc_macro) rust-macro_rules_attribute-proc_macro-devel rust-macro_rules_attribute-proc_macro+default-devel: crate(macro_rules_attribute-proc_macro/default) rust-macro_rules_attribute-proc_macro+default-devel rust-macro_rules_attribute-proc_macro+verbose-expansions-devel: crate(macro_rules_attribute-proc_macro/verbose-expansions) rust-macro_rules_attribute-proc_macro+verbose-expansions-devel Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2358541 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic Disabled plugins: Perl, Haskell, Java, PHP, fonts, Ocaml, Python, C/C++, R, SugarActivity Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
Actually, the license expression for this crate (macro_rules_attribute-proc_macro) still needs to be fixed upstream, in src/proc_macro/Cargo.toml. I sent a PR to do that: https://github.com/danielhenrymantilla/macro_rules_attribute-rs/pull/28
Thanks for catching that; I'll update the spec and SRPM shortly.
Spec URL: https://gist.githubusercontent.com/xanderlent/996108c5b368354573f03da4083330d0/raw/18b18e9271529c745eb6aae6251c01b0020e0e18/rust-macro_rules_attribute-proc_macro.spec SRPM URL: https://gist.github.com/xanderlent/996108c5b368354573f03da4083330d0/raw/18b18e9271529c745eb6aae6251c01b0020e0e18/rust-macro_rules_attribute-proc_macro-0.2.0-1.fc43.src.rpm Updated this crate per the review, sorry it took so long. See also the updated rust2rpm.toml: https://gist.githubusercontent.com/xanderlent/996108c5b368354573f03da4083330d0/raw/18b18e9271529c745eb6aae6251c01b0020e0e18/rust2rpm.toml
[fedora-review-service-build]
Created attachment 2092647 [details] The .spec file difference from Copr build 8881507 to 9110215
Copr build: https://copr.fedorainfracloud.org/coprs/build/9110215 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2358541-rust-macro_rules_attribute-proc_macro/fedora-rawhide-x86_64/09110215-rust-macro_rules_attribute-proc_macro/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
The spec-file diff shows that an appropriate comment was added justifying the license metadata change, and nothing else was modified. The package is therefore APPROVED.
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-macro_rules_attribute-proc_macro
FEDORA-2025-b6defe9a7e (rust-macro_rules_attribute-proc_macro-0.2.0-1.fc43) has been submitted as an update to Fedora 43. https://bodhi.fedoraproject.org/updates/FEDORA-2025-b6defe9a7e
FEDORA-2025-b6defe9a7e (rust-macro_rules_attribute-proc_macro-0.2.0-1.fc43) has been pushed to the Fedora 43 stable repository. If problem still persists, please make note of it in this bug report.