Bug 2358552 - Review Request: rust-esaxx-rs - Wrapping around sentencepiece's esaxxx library
Summary: Review Request: rust-esaxx-rs - Wrapping around sentencepiece's esaxxx library
Keywords:
Status: NEW
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/esaxx-rs
Whiteboard:
Depends On:
Blocks: 2358553
TreeView+ depends on / blocked
 
Reported: 2025-04-09 04:58 UTC by Alexander Lent
Modified: 2025-04-09 15:07 UTC (History)
1 user (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed:
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Alexander Lent 2025-04-09 04:58:05 UTC
Spec URL: https://gist.github.com/xanderlent/ed3801d7d1c2b5f1bda899ea69a306f2/raw/5d21f945057e47e0e0114e2105effa168cc2fa4a/rust-esaxx-rs.spec
SRPM URL: https://gist.github.com/xanderlent/ed3801d7d1c2b5f1bda899ea69a306f2/raw/5d21f945057e47e0e0114e2105effa168cc2fa4a/rust-esaxx-rs-0.1.10-1.fc43.src.rpm
Description: Wrapping around sentencepiece's esaxxx library
Fedora Account System Username: xanderlent

See also the rust2rpm.toml: https://gist.github.com/xanderlent/ed3801d7d1c2b5f1bda899ea69a306f2/raw/5d21f945057e47e0e0114e2105effa168cc2fa4a/rust2rpm.toml

This is a dependency of rust-tokenizers. It needed a few tweaks in rust2rpm.toml, mostly because we don't package criterion, and because the bundled C++ sources aren't considered by the package license for some reason.

Comment 1 Fedora Review Service 2025-04-09 15:07:20 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8881509
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2358552-rust-esaxx-rs/fedora-rawhide-x86_64/08881509-rust-esaxx-rs/fedora-review/review.txt

Found issues:

- No gcc, gcc-c++ or clang found in BuildRequires
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.


Note You need to log in before you can comment on or make changes to this bug.