Copr build:
https://copr.fedorainfracloud.org/coprs/build/8885673
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2358792-wget/fedora-rawhide-x86_64/08885673-wget/fedora-review/review.txt

Found issues:

- License file COPYING is not marked as %license
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text
- A package with this name already exists. Please check https://src.fedoraproject.org/rpms/wget, https://src.fedoraproject.org/tests/wget
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

How will conflicts with the wget subpackage of wget2 be managed?

I will create a PR for wget2 to remove the wget2-wget package. This way wget will provide webclient and wget2 will be a separate package.

Please call this wget1 instead. And instead add a wget1-wget subpackage for those who want to switch the default.

Hi Neal, I still don't get why it should be renamed to wget1. We could just un-retire the package as per the Package Retirement Process, no need to rename it to something else - https://docs.fedoraproject.org/en-US/package-maintainers/Package_Retirement_Process/#claiming

This way we can un-retire it in not just rawhide but also older branches.

Renaming it doesn't stop you from putting it in other branches. In fact, my suggestion *specifically* makes it possible for people to use wget1 as the wget provider, because all we have to do is drop the Obsoletes and people would be able to choose to switch to it on their systems.

Hi Neal,

sorry for the delay, long Public Holiday here. So just to be sure how you mean it. Both packages will have Conflicts: and the only way to install one or the other will be with --allowerasing? Or am I missing some details here?

Basically, the base package will be wget1, then a subpackage wget1-wget will exist that Provides+Conflicts: wget, and users can opt into wget1 by doing "dnf swap wget2-wget wget1-wget" or "dnf install --allowerasing wget1-wget" to switch.

Alright, got it. New build below:

Spec URL: https://download.copr.fedorainfracloud.org/results/mruprich/wget/fedora-rawhide-x86_64/08972233-wget1/wget.spec

SRPM URL: https://download.copr.fedorainfracloud.org/results/mruprich/wget/fedora-rawhide-x86_64/08972233-wget1/wget1-1.25.0-1.fc43.src.rpm

Created attachment 2087600 [details]
Fixes for the wget1.spec file

There's a few more changes you need to make, including renaming the spec file to wget1.spec.

I've attached a diff you can apply to resolve the rest of the issues.

Thanks, latest files below:

Spec URL: https://download.copr.fedorainfracloud.org/results/mruprich/wget/fedora-rawhide-x86_64/08978024-wget1/wget1.spec

SRPM URL: https://download.copr.fedorainfracloud.org/results/mruprich/wget/fedora-rawhide-x86_64/08978024-wget1/wget1-1.25.0-1.fc43.src.rpm

I've seen a couple of issues with the fedora-review tool, I will run it again and upload the results manually.

Created attachment 2087729 [details]
Review

> %doc AUTHORS MAILING-LIST NEWS README COPYING doc/sample.wgetrc

This needs to be changed to:

> %license AUTHORS COPYING
> %doc MAILING-LIST NEWS README doc/sample.wgetrc

Phew, this could work:

Spec URL: https://download.copr.fedorainfracloud.org/results/mruprich/wget/fedora-rawhide-x86_64/08978974-wget1/wget1.spec

SRPM URL: https://download.copr.fedorainfracloud.org/results/mruprich/wget/fedora-rawhide-x86_64/08978974-wget1/wget1-1.25.0-1.fc43.src.rpm

Sorry, doing multiple things at once did not turn out great for me here...

Created attachment 2088411 [details]
Review

This is missing a changelog entry for the update to 1.25.0 and the rename to wget1.

* Mon May 05 2025 Michal Ruprich <mruprich at redhat> - 1.25.0
- Update to 1.25.0
- Rename package to wget1
- Add wget1-wget subpackage to allow usage as wget

Blech, this is more or less what it should be (obviously fix the email address part of the author):

* Mon May 05 2025 Michal Ruprich <mruprich at redhat> - 1.25.0-1
- Update to 1.25.0
- Rename package to wget1
- Add wget1-wget subpackage to allow usage as wget

Spec URL: https://download.copr.fedorainfracloud.org/results/mruprich/wget/fedora-rawhide-x86_64/08997034-wget1/wget1.spec

SRPM URL: https://download.copr.fedorainfracloud.org/results/mruprich/wget/fedora-rawhide-x86_64/08997034-wget1/wget1-1.25.0-1.fc43.src.rpm

Copr build:
https://copr.fedorainfracloud.org/coprs/build/8997532
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2358792-wget1/fedora-rawhide-x86_64/08997532-wget1/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Review notes:

* Package follows Fedora Packaging Guidelines
* Package builds and installs
* Package licensing is correct and license files are captured properly
* No serious issues from rpmlint

PACKAGE APPROVED.

Now that I think of it, this is not technically an unretirement since the package is now renamed to wget1 so even the repository should be different and renamed. Removing the unretirement from the Whiteboard and proceeding with the regular process.

The Pagure repository was created at https://src.fedoraproject.org/rpms/wget1

Stuck on a failing unit test on aarch64:

https://koji.fedoraproject.org/koji/buildinfo?buildID=2710743

I am debugging the issue.