Spec URL: http://developer.postgresql.org/~devrim/rpms/other/postgresql-odbcng/postgresql-odbcng.spec SRPM URL: http://developer.postgresql.org/~devrim/rpms/other/postgresql-odbcng/postgresql-odbcng-0.90.101-1.src.rpm Description: ODBCng is a written from scratch ODBC driver for PostgreSQL 8.x. ODBCng is a wire-level ODBC driver meaning that we do not require libpq or any PostgreSQL libraries be installed to function.
rpmlint: empty debuginfo pkg, but more importantly, GPL isn't a valid license tag anymore.
On install attempt: [root@fawkes SPECS]# rpm -ivh ../RPMS/i386/postgresql-odbcng-0.90.101-1.fc8.i386.rpm Preparing... ########################################### [100%] 1:postgresql-odbcng ########################################### [100%] /sbin/ldconfig: /usr/lib/libmodbc.so.0 is not a symbolic link
md5sums do not match. [limb@fawkes SPECS]$ md5sum odbcng-0.90.101.tar.gz 3d731ed853b798ee1c51bf547a16995a odbcng-0.90.101.tar.gz [limb@fawkes SPECS]$ md5sum ../SOURCES/odbcng-0.90.101.tar.gz 17f167a13e360c3f0a02c695fe22574f ../SOURCES/odbcng-0.90.101.tar.gz
Thanks, will submit new spec and srpm today.
Any updates?
re-uploaded srpm and spec: http://developer.postgresql.org/~devrim/rpms/other/postgresql-odbcng/postgresql-odbcng-0.90.101-1.f8.src.rpm http://developer.postgresql.org/~devrim/rpms/other/postgresql-odbcng/postgresql-odbcng.spec Regards, Devrim
rpmlint on SRPM clean. On RPMS, postgresql-odbcng-debuginfo.i386: E: empty-debuginfo-package This debuginfo package contains no files. This is often a sign of binaries being unexpectedly stripped too early during the build, rpmbuild not being able to strip the binaries, the package actually being a noarch one but erratically packaged as arch dependent, or something else. Verify what the case is, and if there's no way to produce useful debuginfo out of it, disable creation of the debuginfo package. md5 still differs: [limb@fawkes SPECS]$ md5sum odbcng-0.90.101.tar.gz cb90deb161b55161e473c5fc0dd420dc odbcng-0.90.101.tar.gz [limb@fawkes SPECS]$ md5sum ../SOURCES/odbcng-0.90.101.tar.gz 17f167a13e360c3f0a02c695fe22574f ../SOURCES/odbcng-0.90.101.tar.gz
Hrm. I re-uploaded packages (yeah I know why that md5sum thing is happening) I also disabled strip inside spec file, but it did not help for debuginfo issue. Any comments? Regards, Devrim
Spec in SRPM and URL differ, using URL spec. . . Figured out the md5 issues, the Source0 URL isn't quite right. Might want to explain that in the comments. Not sure about the debuginfo issue. Not a major issue, I don't think. Might want to disable debuginfo creation. License is listed as GPLv2, which is what is included, but the only mention of a license in the src is LGPL. Other than licensing and debuginfo, it passed the rest of the review.
Hi, (In reply to comment #9) > Spec in SRPM and URL differ, using URL spec. . . I have zero idea why this happened. Anyway: > Figured out the md5 issues, the Source0 URL isn't quite right. Might want to > explain that in the comments. I cannot add ?format=raw to Source0 -- current thing is the closest that I can do -- and ok, added a comment. > Not sure about the debuginfo issue. Not a major issue, I don't think. Might > want to disable debuginfo creation. 'k, done. > License is listed as GPLv2, which is what is included, but the only mention of a > license in the src is LGPL. My bad, fixed. > Other than licensing and debuginfo, it passed the rest of the review. Thanks. I re-uploaded spec and srpm. SRPM: http://developer.postgresql.org/~devrim/rpms/other/postgresql-odbcng/postgresql-odbcng-0.90.101-1.fc9.src.rpm SPEC: http://developer.postgresql.org/~devrim/rpms/other/postgresql-odbcng/postgresql-odbcng.spec Regards, Devrim
postgresql-odbcng.src: W: invalid-license LGPL The value of the License tag was not recognized. Known values are: "Adobe", "AFL", "AGPLv1", "AGPLv3", "AMPAS BSD", "ARL", "ASL 1.0", "ASL 1.0+", "ASL 1.1", "ASL 1.1+", "ASL 2.0", "ASL 2.0+", "APSL 2.0", "APSL 2.0+", "Artistic 2.0", "Artistic clarified", "BitTorrent", "Boost", "BSD", "BSD with advertising", "CeCILL", "CDDL", "CPL", "Condor", "Copyright only", "Cryptix", "Crystal Stacker", "EPL", "eCos", "EFL 2.0", "EFL 2.0+", "EU Datagrid", "FTL", "Giftware", "Glide", "gnuplot", "GPL+", "GPL+ or Artistic", "GPLv2+ or Artistic", "GPLv2", "GPLv2 with exceptions", "GPLv2+", "GPLv2+ with exceptions", "GPLv3", "GPLv3 with exceptions", "GPLv3+", "GPLv3+ with exceptions", "IBM", "IJG", "ImageMagick", "iMatix", "Imlib2", "Intel ACPI", "Interbase", "ISC", "Jabber", "JasPer", "LGPLv2", "LGPLv2 with exceptions", "LGPLv2+", "LGPLv3", "LGPLv3+", "libtiff", "LPL", "LPPL", "mecab-ipadic", "MIT", "MPLv1.0", "MPLv1.0+", "MPLv1.1", "MPLv1.1+", "NCSA", "NGPL", "NOSL", "Netscape", "Nokia", "OpenLDAP", "OpenPBS", "OReilly", "OSL 1.0", "OSL 1.0+", "OSL 1.1", "OSL 1.1+", "OSL 2.0", "OSL 2.0+", "OSL 3.0", "OSL 3.0+", "OpenSSL", "Phorum", "PHP", "Public Domain", "Python", "QPL", "RPSL", "Ruby", "Sleepycat", "SISSL", "SLIB", "SPL", "TCL", "UCD", "Vim", "VNLSL", "VSL", "W3C", "WTFPL", "wxWindows", "xinetd", "Zend", "ZPLv1.0", "ZPLv1.0+", "ZPLv2.0", "ZPLv2.0+", "ZPLv2.1", "ZPLv2.1+", "zlib", "CDL", "FBSDDL", "GFDL", "IEEE", "OFSFDL", "Open Publication", "CC-BY", "CC-BY-SA", "DSL", "Free Art", "Arphic", "Baekmuk", "Bitstream Vera", "mplus", "OFL", "STIX", "Utopia", "XANO", "Redistributable, no modification permitted", "Freely redistributable without restriction". Needs a version. Since the source doesn't specify, I'd probably go with LGPLv2.
Sorry for that, I am really busy ATM, that's why I could not check it with rpmlint. Spec and SRPM updated: SRPM: http://developer.postgresql.org/~devrim/rpms/other/postgresql-odbcng/postgresql-odbcng-0.90.101-1.fc9.src.rpm SPEC: http://developer.postgresql.org/~devrim/rpms/other/postgresql-odbcng/postgresql-odbcng.spec Regards, Devrim
No worries, looks great. APPROVED.
Note on licensing from: http://fedoraproject.org/wiki/Licensing ''' A GPL or LGPL licensed package that lacks any statement of what version that it's licensed under in the source code/program output/accompanying docs is technically licensed under *any* version of the GPL or LGPL, not just the version in whatever COPYING file they include. ''' This combines with the fact that there's no version 1 of the LGPL to make the license tag LGPLv2+.
Thanks, I wasn't sure how to interpret that. That makes sense.
New Package CVS Request ======================= Package Name: postgresql-odbcng Short Description: PostgreSQL ODBCng driver Owners: devrim Branches: F-8 F-9 EL-5 InitialCC: Cvsextras Commits: yes
cvs done.
Why do you need to set %debug_package as nil?
See review , please. Regards, Devrim
Well, actually make process strips .libs/libmodbc.so, needs fixing. sed -i.strip -e 's|strip|true strip|' makefile.in at the end of %prep should fix this. Also, libmodbc.so.0 should be symlink and is libmodbc.so really be needed?
debuginfo issue is actually a BLOCKER for review and review request _must_ not be accepted until it is solved except for mono packages and so on.
I wasn't aware of this debuginfo fix. Thanks for pointing that out!
ping?
Spec and SRPM updated: SRPM: http://developer.postgresql.org/~devrim/rpms/other/postgresql-odbcng/postgresql-odbcng-0.90.101-1.fc9.src.rpm SPEC: http://developer.postgresql.org/~devrim/rpms/other/postgresql-odbcng/postgresql-odbcng.spec I'm pushing it for build. Regards, Devrim