Spec URL: https://music.fedorapeople.org/python-typing-inspection.spec SRPM URL: https://music.fedorapeople.org/python-typing-inspection-0.4.0-1.fc41.src.rpm Description: This module provides tools to inspect type annotations at runtime. Fedora Account System Username: music
Copr build: https://copr.fedorainfracloud.org/coprs/build/8897653 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2359303-python-typing-inspection/fedora-rawhide-x86_64/08897653-python-typing-inspection/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "MIT License", "*No copyright* MIT License". 23 files have unknown license. Detailed output of licensecheck in /home/fedora-packaging/reviews/python-typing- inspection/2359303-python-typing-inspection/licensecheck.txt [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/python3.13, /usr/lib/python3.13/site-packages [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 2608 bytes in 2 files. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [-]: Python eggs must not download any dependencies during the build process. [-]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python3-typing-inspection-0.4.0-1.fc43.noarch.rpm python-typing-inspection-0.4.0-1.fc43.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.6.1 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpq791ll61')] checks: 32, packages: 2 2 packages and 0 specfiles checked; 0 errors, 0 warnings, 7 filtered, 0 badness; has taken 0.5 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 3 filtered, 0 badness; has taken 0.0 s Source checksums ---------------- https://files.pythonhosted.org/packages/source/t/typing_inspection/typing_inspection-0.4.0.tar.gz : CHECKSUM(SHA256) this package : 9765c87de36671694a67904bf2c96e395be9c6439bb6c87b5142569dcdd65122 CHECKSUM(SHA256) upstream package : 9765c87de36671694a67904bf2c96e395be9c6439bb6c87b5142569dcdd65122 Requires -------- python3-typing-inspection (rpmlib, GLIBC filtered): python(abi) python3.13dist(typing-extensions) Provides -------- python3-typing-inspection: python-typing-inspection python3-typing-inspection python3.13-typing-inspection python3.13dist(typing-inspection) python3dist(typing-inspection) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2359303 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Python, Shell-api Disabled plugins: PHP, Ocaml, Haskell, C/C++, Java, fonts, R, Perl, SugarActivity Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH Comments: a) Approved b) It maybe helpful to package documentation..
> Comments: > a) Approved Thank you for the review! https://release-monitoring.org/project/377682/ > b) It maybe helpful to package documentation.. I really like the *idea* of packaging useful offline documentation, and for a long time, I went out of my way to build HTML or PDF documentation wherever possible. However, I’ve come to agree with the position that building generated documentation is almost always more trouble than it is worth, and I’ve been actively removing -doc subpackages with documentation generated by Sphinx, Doxygeen, etc. from most of my packages. For HTML, there tend to be issues with bundled fonts, CSS, JavaScript, etc., as noted in bug 2006555. Several recent FESCo decisions have lightened the burden here, but guideline compliance and determining all applicable licenses can still be a burden. Building PDF documentation can help, but tends to be a bit fussy, and TeX is a very heavy build dependency. In this case, there’s at least one missing documentation dependency, which is another reason not to want to try to build the documentation, and except for usage.md, the raw Markdown sources are really not useful by themselves.
The Pagure repository was created at https://src.fedoraproject.org/rpms/python-typing-inspection
FEDORA-2025-8aafd40339 (python-typing-inspection-0.4.0-1.fc43) has been submitted as an update to Fedora 43. https://bodhi.fedoraproject.org/updates/FEDORA-2025-8aafd40339
FEDORA-2025-8aafd40339 (python-typing-inspection-0.4.0-1.fc43) has been pushed to the Fedora 43 stable repository. If problem still persists, please make note of it in this bug report.
A build with documentation is available at: https://koji.fedoraproject.org/koji/taskinfo?taskID=131512520 The package uses mkdocs, it seems not possible to remove the javascript used for search. Maybe it is helpful to have a set of Fedora themes for common documentation packages? Sphinx and Rubydocs are others that are likely useful. With Sphinx, it is possible to create themes that facilitate a single HTML output without javascript. One can use browser single page search functionality. For an example see: https://packages.fedoraproject.org/pkgs/novelwriter/novelwriter/ Still needs to be made beautiful though.
FEDORA-2025-7e7d75d566 (python-typing-inspection-0.4.0-2.fc42) has been submitted as an update to Fedora 42. https://bodhi.fedoraproject.org/updates/FEDORA-2025-7e7d75d566
FEDORA-2025-a577d96824 (python-typing-inspection-0.4.0-2.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2025-a577d96824
FEDORA-2025-a577d96824 has been pushed to the Fedora 41 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-a577d96824 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-a577d96824 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2025-7e7d75d566 has been pushed to the Fedora 42 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-7e7d75d566 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-7e7d75d566 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2025-24bdf205ce (python-pydantic-settings-2.9.1-1.fc42 and python-typing-inspection-0.4.0-2.fc42) has been submitted as an update to Fedora 42. https://bodhi.fedoraproject.org/updates/FEDORA-2025-24bdf205ce
FEDORA-2025-633ab53bc0 (python-pydantic-settings-2.9.1-1.fc41 and python-typing-inspection-0.4.0-2.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2025-633ab53bc0
FEDORA-2025-633ab53bc0 has been pushed to the Fedora 41 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-633ab53bc0` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-633ab53bc0 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2025-24bdf205ce has been pushed to the Fedora 42 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-24bdf205ce` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-24bdf205ce See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2025-24bdf205ce (python-pydantic-settings-2.9.1-1.fc42 and python-typing-inspection-0.4.0-2.fc42) has been pushed to the Fedora 42 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2025-633ab53bc0 (python-pydantic-settings-2.9.1-1.fc41 and python-typing-inspection-0.4.0-2.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report.