Bug 2359454 - Spec file contains "forbidden controlchar"
Summary: Spec file contains "forbidden controlchar"
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: xz
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
low
Target Milestone: ---
Assignee: Richard W.M. Jones
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2025-04-14 09:35 UTC by Tim Landscheidt
Modified: 2025-04-14 09:59 UTC (History)
6 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2025-04-14 09:59:16 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Tim Landscheidt 2025-04-14 09:35:53 UTC
With commit 1904db7c75ca93ac1f4e2277a6945826414d5366, an (apparently benign) ANSI sequence was introduced in a comment:

| $ grep $'\33' xz.spec | od -c
| 0000000   #       d   o   c   s       -       B   S 033   [   O   D   0
                                                      ^^^^^^^^^^^
| 0000020       A   N   D       L   i   c   e   n   s   e   R   e   f   -
| 0000040   F   e   d   o   r   a   -   P   u   b   l   i   c   -   D   o
| 0000060   m   a   i   n  \n
| 0000065
| $

(Reading https://en.wikipedia.org/wiki/ANSI_escape_code, this appears to be a signal from the terminal emulator that it has "exited focus".)

rpmlint catches these:

| $ rpmlint xz.spec 
| ========================================================================================================== rpmlint session starts =========================================================================================================
| rpmlint: 2.6.1
| configuration:
|     /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml
|     /etc/xdg/rpmlint/fedora-legacy-licenses.toml
|     /etc/xdg/rpmlint/fedora-spdx-licenses.toml
|     /etc/xdg/rpmlint/fedora.toml
|     /etc/xdg/rpmlint/scoring.toml
|     /etc/xdg/rpmlint/users-groups.toml
|     /etc/xdg/rpmlint/warn-on-functions.toml
| checks: 32, packages: 1

| xz.spec:14: W: forbidden-controlchar-found
| ===================================================================== 0 packages and 1 specfiles checked; 0 errors, 1 warnings, 2 filtered, 0 badness; has taken 0.1 s ====================================================================
| $

Comment 1 Richard W.M. Jones 2025-04-14 09:55:19 UTC
https://src.fedoraproject.org/rpms/xz/c/1904db7c75ca93ac1f4e2277a6945826414d5366?branch=rawhide

$ git show 1904db7c75ca93ac1f4e2277a6945826414d5366 | hexdump -C | grep -C3 "1b 5b 4f"
00000260  2c 64 69 66 66 2c 6c 65  73 73 2c 6d 6f 72 65 7d  |,diff,less,more}|
00000270  20 2d 20 47 50 4c 2d 32  2e 30 2d 6f 72 2d 6c 61  | - GPL-2.0-or-la|
00000280  74 65 72 0a 2b 23 20 64  6f 63 73 20 2d 20 42 53  |ter.+# docs - BS|
00000290  1b 5b 4f 44 30 20 41 4e  44 20 4c 69 63 65 6e 73  |.[OD0 AND Licens|
000002a0  65 52 65 66 2d 46 65 64  6f 72 61 2d 50 75 62 6c  |eRef-Fedora-Publ|
000002b0  69 63 2d 44 6f 6d 61 69  6e 0a 2b 23 20 6d 61 6e  |ic-Domain.+# man|
000002c0  20 70 61 67 65 73 20 61  6e 64 20 74 72 61 6e 73  | pages and trans|

Looks like Lucas accidentally fat-fingered while typing the comment.  What's
really interesting is that git itself doesn't show the escape sequence
when you use 'git show'.  Anyway it's an accident, I'll fix it.

Comment 2 Richard W.M. Jones 2025-04-14 09:59:16 UTC
Fixed in dist-git back to f40.


Note You need to log in before you can comment on or make changes to this bug.