SRPM URL: http://home.comcast.net/~ckweyl/perl-Data-Visitor-0.05-1.fc6.src.rpm SPEC URL: http://home.comcast.net/~ckweyl/perl-Data-Visitor.spec Description: This module is a simple visitor implementation for Perl values.
This package is a prereq of the Catalyst framework.
BR: perl(ExtUtils::MakeMaker) missing?
(In reply to comment #2) > BR: perl(ExtUtils::MakeMaker) missing? No, this is deliberate: the package uses Module::Build to build itself.
Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and for RPM. + source files match upstream url d8b5c458439698187db0bfee672044ef Data-Visitor-0.05.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test outputs t/base.................ok t/bugs.................ok t/callback.............ok t/callback_aliasing....ok t/circular_refs........ok t/globs................ok All tests successful. Files=6, Tests=64, 1 wallclock secs ( 0.30 cusr + 0.08 csys = 0.38 CPU) + Provides: perl(Data::Visitor) = 0.05 perl(Data::Visitor::Callback) APPROVED.
New Package CVS Request ======================= Package Name: perl-Data-Visitor Short Description: Visitor style traversal of Perl data structures Owners: cweyl.edu Branches: FC-5, FC-6, devel InitialCC: fedora-perl-devel-list
Imported and building... thanks for the review!
Package Change Request ====================== Package Name: perl-Data-Visitor New Branches: el6 Owners: iarnell tremble InitialCC: perl-sig
Git done (by process-git-requests).