Spec URL: https://raw.githubusercontent.com/firefly-cpp/rpm-reviews/refs/heads/main/python-niaarmts.spec SRPM URL: https://github.com/firefly-cpp/rpm-reviews/raw/refs/heads/main/python-niaarmts-0.1.5-1.fc41.src.rpm Description: Framework is designed for numerical association rule mining in time series data using stochastic population-based nature-inspired algorithms. It provides tools to extract association rules from time series datasets while incorporating key metrics such as support, confidence, inclusion, and amplitude. Although independent from the NiaARM framework, this software can be viewed as an extension, with additional support for time series numerical association rule mining. Fedora Account System Username: iztokf
Copr build: https://copr.fedorainfracloud.org/coprs/build/8906142 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2359763-python-niaarmts/fedora-rawhide-x86_64/08906142-python-niaarmts/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "MIT License", "*No copyright* MIT License". 36 files have unknown license. Detailed output of licensecheck in /home/fedora-packaging/reviews/python-niaarmts/2359763 -python-niaarmts/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/python3.13/site- packages, /usr/lib/python3.13 [x]: Package contains no bundled libraries without FPC exception. [!]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 8436 bytes in 1 files. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [-]: Python eggs must not download any dependencies during the build process. [-]: A package which is used by another package via an egg interface should provide egg info. [ ]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python3-NiaARMTS [ ]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python3-NiaARMTS-0.1.5-1.fc43.noarch.rpm python-niaarmts-doc-0.1.5-1.fc43.noarch.rpm python-niaarmts-0.1.5-1.fc43.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.6.1 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpy7192f_y')] checks: 32, packages: 3 python-niaarmts-doc.noarch: W: no-documentation python-niaarmts.src: E: description-line-too-long framework is designed for numerical association rule mining in time series data using python-niaarmts.src: E: description-line-too-long stochastic population-based nature-inspired algorithms. It provides tools to extract python-niaarmts.src: E: description-line-too-long association rules from time series datasets while incorporating key metrics such as python-niaarmts.src: E: description-line-too-long support, confidence, inclusion, and amplitude. Although independent from the NiaARM python3-NiaARMTS.noarch: E: description-line-too-long framework is designed for numerical association rule mining in time series data using python3-NiaARMTS.noarch: E: description-line-too-long stochastic population-based nature-inspired algorithms. It provides tools to extract python3-NiaARMTS.noarch: E: description-line-too-long association rules from time series datasets while incorporating key metrics such as python3-NiaARMTS.noarch: E: description-line-too-long support, confidence, inclusion, and amplitude. Although independent from the NiaARM 3 packages and 0 specfiles checked; 8 errors, 1 warnings, 12 filtered, 8 badness; has taken 0.5 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 2 python-niaarmts-doc.noarch: W: no-documentation python3-NiaARMTS.noarch: E: description-line-too-long framework is designed for numerical association rule mining in time series data using python3-NiaARMTS.noarch: E: description-line-too-long stochastic population-based nature-inspired algorithms. It provides tools to extract python3-NiaARMTS.noarch: E: description-line-too-long association rules from time series datasets while incorporating key metrics such as python3-NiaARMTS.noarch: E: description-line-too-long support, confidence, inclusion, and amplitude. Although independent from the NiaARM 2 packages and 0 specfiles checked; 4 errors, 1 warnings, 8 filtered, 4 badness; has taken 0.1 s Source checksums ---------------- https://github.com/firefly-cpp/NiaARMTS/archive/0.1.5/NiaARMTS-0.1.5.tar.gz : CHECKSUM(SHA256) this package : 08e0dd02a67394e3690662f170b7090e4cabc69e7eeb711ca2c7b8ae403175bd CHECKSUM(SHA256) upstream package : 08e0dd02a67394e3690662f170b7090e4cabc69e7eeb711ca2c7b8ae403175bd Requires -------- python3-NiaARMTS (rpmlib, GLIBC filtered): (python3.13dist(niapy) < 3~~ with python3.13dist(niapy) >= 2.5.2) python(abi) python3.13dist(pandas) python-niaarmts-doc (rpmlib, GLIBC filtered): Provides -------- python3-NiaARMTS: python-NiaARMTS python3-NiaARMTS python3.13-NiaARMTS python3.13dist(niaarmts) python3dist(niaarmts) python-niaarmts-doc: python-niaarmts-doc Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2359763 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic, Python Disabled plugins: C/C++, Java, SugarActivity, Perl, R, Haskell, PHP, fonts, Ocaml Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH Comments: a) A doc package is created, but it is empty. Is it possible to build the docs? HTML might be better to ship, especially if it can use the lv_theme: https://packages.fedoraproject.org/pkgs/python-sphinx_lv2_theme/python3-sphinx_lv2_theme/ which does not have javascript, even if not complete, shipping it maybe helpful. Otherwise, only create the package if the docs are built. b) Consider using %{autorelease} and %{autochangelog} macros alternatively update the version in the changelog to the current version being packaged. c) Please change lines in description so that they are at most 80 characters. d) Please change %if %{with tests} %pytest %endif to %if %{with tests} %pytest %else %pyproject_check_import %endif or %pyproject_check_import %if %{with tests} %pytest %endif
Thank you for your review! Corrections attached. Spec URL: https://raw.githubusercontent.com/firefly-cpp/rpm-reviews/refs/heads/main/python-niaarmts.spec SRPM URL: https://github.com/firefly-cpp/rpm-reviews/raw/refs/heads/main/python-niaarmts-0.1.7-1.fc41.src.rpm
Created attachment 2085792 [details] The .spec file difference from Copr build 8906142 to 8921164
Copr build: https://copr.fedorainfracloud.org/coprs/build/8921164 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2359763-python-niaarmts/fedora-rawhide-x86_64/08921164-python-niaarmts/fedora-review/review.txt Found issues: - License file license.doctree is not marked as %license Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
There are some warnings for hidden files which could possibly be removed: python-niaarmts-doc.noarch: W: python-sphinx-doctrees-leftover /usr/share/doc/python-niaarmts-doc/html/.doctrees python-niaarmts-doc.noarch: W: hidden-file-or-dir /usr/share/doc/python-niaarmts-doc/html/.buildinfo python-niaarmts-doc.noarch: W: hidden-file-or-dir /usr/share/doc/python-niaarmts-doc/html/.doctrees python-niaarmts-doc.noarch: W: hidden-file-or-dir /usr/share/doc/python-niaarmts-doc/html/.doctrees Otherwise, seems ok. Approved. If time allows, would appreciate review of: https://bugzilla.redhat.com/show_bug.cgi?id=2359409
Thank you, Benson!
The Pagure repository was created at https://src.fedoraproject.org/rpms/python-niaarmts
FEDORA-2025-54ae72bcbb (python-niaarmts-0.1.7-1.fc43) has been submitted as an update to Fedora 43. https://bodhi.fedoraproject.org/updates/FEDORA-2025-54ae72bcbb
FEDORA-2025-54ae72bcbb (python-niaarmts-0.1.7-1.fc43) has been pushed to the Fedora 43 stable repository. If problem still persists, please make note of it in this bug report.