Bug 2360415 - Review Request: rust-migrations_internals - Internal implementation of diesels migration mechanism
Summary: Review Request: rust-migrations_internals - Internal implementation of diesel...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/migrations_i...
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2025-04-16 18:19 UTC by Jelle van der Waa
Modified: 2025-04-18 19:48 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2025-04-18 19:48:58 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)

Comment 1 Fedora Review Service 2025-04-16 18:25:41 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8911077
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2360415-rust-migrations_internals/fedora-rawhide-x86_64/08911077-rust-migrations_internals/fedora-review/review.txt

Found issues:

- A package with this name already exists. Please check https://src.fedoraproject.org/rpms/rust-migrations_internals
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Fabio Valentini 2025-04-17 12:28:45 UTC
The <summary> from the bug title template should be the package summary, not something you write yourself.

Will post full review shortly.

Comment 3 Fabio Valentini 2025-04-17 12:36:29 UTC
Package was generated with rust2rpm, simplifying the review.

✅ package contains only permissible content
✅ package builds and installs without errors on rawhide
🫤 test suite is run and all unit tests pass (there are zero tests)
✅ latest version of the crate is packaged
✅ license matches upstream specification and is acceptable for Fedora
✅ license file is included with %license in %files
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

This is a package un-retirement, so you'll need to file a ticket with releng for the next steps.

Comment 4 Fedora Update System 2025-04-18 10:05:17 UTC
FEDORA-2025-95b7d7b903 (rust-migrations_internals-2.2.0-1.fc43) has been submitted as an update to Fedora 43.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-95b7d7b903

Comment 5 Fedora Update System 2025-04-18 19:48:58 UTC
FEDORA-2025-95b7d7b903 (rust-migrations_internals-2.2.0-1.fc43) has been pushed to the Fedora 43 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.