Bug 2360941 (rust-igvm) - Review Request: rust-igvm - Igvm is an implementation of a parser for the Independent Guest Virtual Machine
Summary: Review Request: rust-igvm - Igvm is an implementation of a parser for the Ind...
Keywords:
Status: CLOSED ERRATA
Alias: rust-igvm
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Cole Robinson
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/igvm
Whiteboard:
Depends On: rust-igvm_defs
Blocks:
TreeView+ depends on / blocked
 
Reported: 2025-04-18 09:03 UTC by Luigi Leonardi
Modified: 2025-04-30 09:28 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2025-04-30 09:28:03 UTC
Type: ---
Embargoed:
crobinso: fedora-review+


Attachments (Terms of Use)

Description Luigi Leonardi 2025-04-18 09:03:33 UTC
Spec URL: https://gitlab.com/luigileonardi/igvm/-/raw/master/rust-igvm.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/lleonard/sev-snp-coconut/fedora-rawhide-x86_64/08918631-rust-igvm/rust-igvm-0.3.4-1.fc43.src.rpm
Description: The igvm crate is an implementation of a parser for the Independent
Guest Virtual Machine (IGVM) file format.
Fedora Account System Username: lleonard

This is part of the effort to package svsm.

Comment 1 Fedora Review Service 2025-04-18 09:05:22 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8918645
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2360941-rust-igvm/fedora-rawhide-x86_64/08918645-rust-igvm/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Luigi Leonardi 2025-04-24 14:05:41 UTC
[fedora-review-service-build]

Comment 3 Fedora Review Service 2025-04-24 14:17:19 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8963800
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2360941-rust-igvm/fedora-rawhide-x86_64/08963800-rust-igvm/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 4 Cole Robinson 2025-04-29 17:51:47 UTC
* spec matches rust2rpm output, with Summary tweak and metadata patch.
  + small suggestion: tweak the comment `after version 0.3.4` -> `when version > 0.3.4`
    since it reads a little ambiguous to me

* builds on rawhide
* installs on rawhide
* content looks fine

Approved. setting fedora-review+

Comment 5 Fedora Admin user for bugzilla script actions 2025-04-30 09:06:22 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-igvm

Comment 6 Fedora Update System 2025-04-30 09:24:39 UTC
FEDORA-2025-438d5f61eb (rust-igvm-0.3.4-1.fc43) has been submitted as an update to Fedora 43.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-438d5f61eb

Comment 7 Fedora Update System 2025-04-30 09:28:03 UTC
FEDORA-2025-438d5f61eb (rust-igvm-0.3.4-1.fc43) has been pushed to the Fedora 43 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.