Spec URL: https://asn.fedorapeople.org/rust-opendal.spec SRPM URL: https://asn.fedorapeople.org/rust-opendal-0.53.1-2.fc43.src.rpm Description: Apache OpenDAL™: One Layer, All Storage. Fedora Account System Username: asn
This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=131855534
Copr build: https://copr.fedorainfracloud.org/coprs/build/8951395 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2361620-rust-opendal/fedora-rawhide-x86_64/08951395-rust-opendal/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
# * The tests::assert_size fails on 32bit: # https://github.com/apache/opendal/issues/6077 Should we skip this only `%ifarch i386` (and other 32b arches)? Or should we rather patch the test to get this fixed also in upstream?
I was trying to run the fedora review locally, but it failed to install for some reason. Did you regenerate the spec file using rust2rpm after the update from the previous versions? INFO: installing package(s): /builddir/rust-opendal+default-devel-0.53.1-2.fc43.noarch.rpm /builddir/rust-opendal+services-fs-devel-0.53.1-2.fc43.noarch.rpm /builddir/rust-opendal+tests-devel-0.53.1-2.fc43.noarch.rpm /builddir/rust-opendal+services-memcached-devel-0.53.1-2.fc43.noarch.rpm /builddir/rust-opendal+services-webdav-devel-0.53.1-2.fc43.noarch.rpm /builddir/rust-opendal+executors-tokio-devel-0.53.1-2.fc43.noarch.rpm /builddir/rust-opendal+internal-tokio-rt-devel-0.53.1-2.fc43.noarch.rpm /builddir/rust-opendal+hdfs-native-devel-0.53.1-2.fc43.noarch.rpm /builddir/rust-opendal+internal-path-cache-devel-0.53.1-2.fc43.noarch.rpm /builddir/rust-opendal+tikv-client-devel-0.53.1-2.fc43.noarch.rpm /builddir/rust-opendal+services-opfs-devel-0.53.1-2.fc43.noarch.rpm /builddir/rust-opendal-devel-0.53.1-2.fc43.noarch.rpm ERROR: Command failed: # /usr/bin/systemd-nspawn -q -M 08637b2b0d6444e98b2536d08effec2b -D /var/lib/mock/fedora-rawhide-x86_64-bootstrap/root -a --capability=cap_ipc_lock --bind=/tmp/mock-resolv.6l3uw9jr:/etc/resolv.conf --console=pipe --setenv=TERM=vt100 --setenv=SHELL=/bin/bash --setenv=HOME=/var/lib/mock/fedora-rawhide-x86_64/root/installation-homedir --setenv=HOSTNAME=mock --setenv=PATH=/usr/bin:/bin:/usr/sbin:/sbin '--setenv=PROMPT_COMMAND=printf "\033]0;<mock-chroot>\007"' '--setenv=PS1=<mock-chroot> \s-\v\$ ' --setenv=LANG=C.UTF-8 --setenv=LC_MESSAGES=C.UTF-8 --resolv-conf=off /usr/bin/dnf5 --installroot /var/lib/mock/fedora-rawhide-x86_64/root/ --releasever 43 install /builddir/rust-opendal+default-devel-0.53.1-2.fc43.noarch.rpm /builddir/rust-opendal+services-fs-devel-0.53.1-2.fc43.noarch.rpm /builddir/rust-opendal+tests-devel-0.53.1-2.fc43.noarch.rpm /builddir/rust-opendal+services-memcached-devel-0.53.1-2.fc43.noarch.rpm /builddir/rust-opendal+services-webdav-devel-0.53.1-2.fc43.noarch.rpm /builddir/rust-opendal+executors-tokio-devel-0.53.1-2.fc43.noarch.rpm /builddir/rust-opendal+internal-tokio-rt-devel-0.53.1-2.fc43.noarch.rpm /builddir/rust-opendal+hdfs-native-devel-0.53.1-2.fc43.noarch.rpm /builddir/rust-opendal+internal-path-cache-devel-0.53.1-2.fc43.noarch.rpm /builddir/rust-opendal+tikv-client-devel-0.53.1-2.fc43.noarch.rpm /builddir/rust-opendal+services-opfs-devel-0.53.1-2.fc43.noarch.rpm /builddir/rust-opendal-devel-0.53.1-2.fc43.noarch.rpm --setopt=deltarpm=False --setopt=allow_vendor_change=yes --allowerasing --setopt=tsflags=nocontexts Otherwise lgtm.
I created a fix for that bug. I will include it and rebuild. I think what you found in comment #4 also needs fixing.
Spec URL: https://asn.fedorapeople.org/rust-opendal.spec SRPM URL: https://asn.fedorapeople.org/rust-opendal-0.53.1-3.fc43.src.rpm
Spec URL: https://asn.fedorapeople.org/rust-opendal.spec SRPM URL: https://asn.fedorapeople.org/rust-opendal-0.53.1-4.fc43.src.rpm
Copr build: https://copr.fedorainfracloud.org/coprs/build/8952257 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2361620-rust-opendal/fedora-rawhide-x86_64/08952257-rust-opendal/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Created attachment 2086444 [details] The .spec file difference from Copr build 8952255 to 8952257
Copr build: https://copr.fedorainfracloud.org/coprs/build/8952255 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2361620-rust-opendal/fedora-rawhide-x86_64/08952255-rust-opendal/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
It still fails to install for me in `fedora-review`, but I have no idea why: INFO: installing package(s): /builddir/rust-opendal+services-webdav-devel-0.53.1-4.fc43.noarch.rpm /builddir/rust-opendal+services-fs-devel-0.53.1-4.fc43.noarch.rpm /builddir/rust-opendal-devel-0.53.1-4.fc43.noarch.rpm /builddir/rust-opendal+services-memcached-devel-0.53.1-4.fc43.noarch.rpm /builddir/rust-opendal+default-devel-0.53.1-4.fc43.noarch.rpm ERROR: Command failed: # /usr/bin/systemd-nspawn -q -M f5a1c5b199f64034883357b512f1c779 -D /var/lib/mock/fedora-rawhide-x86_64-bootstrap/root -a --capability=cap_ipc_lock --bind=/tmp/mock-resolv.g1e3dk4f:/etc/resolv.conf --console=pipe --setenv=TERM=vt100 --setenv=SHELL=/bin/bash --setenv=HOME=/var/lib/mock/fedora-rawhide-x86_64/root/installation-homedir --setenv=HOSTNAME=mock --setenv=PATH=/usr/bin:/bin:/usr/sbin:/sbin '--setenv=PROMPT_COMMAND=printf "\033]0;<mock-chroot>\007"' '--setenv=PS1=<mock-chroot> \s-\v\$ ' --setenv=LANG=C.UTF-8 --setenv=LC_MESSAGES=C.UTF-8 --resolv-conf=off /usr/bin/dnf5 --installroot /var/lib/mock/fedora-rawhide-x86_64/root/ --releasever 43 install /builddir/rust-opendal+services-webdav-devel-0.53.1-4.fc43.noarch.rpm /builddir/rust-opendal+services-fs-devel-0.53.1-4.fc43.noarch.rpm /builddir/rust-opendal-devel-0.53.1-4.fc43.noarch.rpm /builddir/rust-opendal+services-memcached-devel-0.53.1-4.fc43.noarch.rpm /builddir/rust-opendal+default-devel-0.53.1-4.fc43.noarch.rpm --setopt=deltarpm=False --setopt=allow_vendor_change=yes --allowerasing --setopt=tsflags=nocontexts Any thoughts?
Spec URL: https://asn.fedorapeople.org/rust-opendal.spec SRPM URL: https://asn.fedorapeople.org/rust-opendal-0.53.1-5.fc43.src.rpm
Created attachment 2086741 [details] The .spec file difference from Copr build 8952257 to 8955624
Copr build: https://copr.fedorainfracloud.org/coprs/build/8955624 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2361620-rust-opendal/fedora-rawhide-x86_64/08955624-rust-opendal/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [X]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [X]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* Apache License 2.0". 146 files have unknown license. Detailed output of licensecheck in /home/jjelen/2361620-rust-opendal/licensecheck.txt [X]: License file installed when any subpackage combination is installed. [X]: %build honors applicable compiler flags or justifies otherwise. [X]: Package contains no bundled libraries without FPC exception. [X]: Changelog in prescribed format. [X]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [X]: Development files must be in a -devel package [X]: Package uses nothing in %doc for runtime. [X]: Package consistently uses macros (instead of hard-coded directory names). [X]: Package is named according to the Package Naming Guidelines. [X]: Package does not generate any conflict. [X]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [X]: Requires correct, justified where necessary. [X]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [X]: Package is not known to require an ExcludeArch tag. [X]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [X]: Final provides and requires are sane (see attachments). [X]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in rust- opendal-devel , rust-opendal+default-devel , rust-opendal+executors- tokio-devel , rust-opendal+internal-tokio-rt-devel , rust- opendal+services-fs-devel , rust-opendal+services-memcached-devel , rust-opendal+services-memory-devel , rust-opendal+services-webdav- devel [X]: Package functions as described. [X]: Latest version is packaged. [X]: Package does not include license text files separate from upstream. [X]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [X]: Package should compile and build into binary rpms on all supported architectures. [X]: %check is present and all tests pass. [X]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-opendal
I don't think this does what you think it does: > [features] >enable = [ > "services-fs", > "services-memcached", > # "services-redis", # would be nice to have > "services-webdav", >] From https://src.fedoraproject.org/rpms/rust-opendal/blob/rawhide/f/rust2rpm.toml#_20-25 These "enabled" features are only enabled for the test compile (%cargo_build) and for running tests (%cargo_test) - they are **local** properties for the package which do not affect the contents of the built packages in any way. You cannot "enable" features you want the package to provide this way. === Additionally, the Summary contains the (TM) symbol, which is "you should never do this": https://docs.fedoraproject.org/en-US/packaging-guidelines/#_trademarks_in_summary_or_description Also unclear if it's even the correct unicode code point, it doesn't render correctly on pagure: https://src.fedoraproject.org/rpms/rust-opendal/blob/rawhide/f/rust-opendal.spec#_10
Fixed, thanks.