Red Hat Bugzilla – Bug 236177
Review Request: perl-NetAddr-IP - Manages IPv4 and IPv6 addresses and subnets
Last modified: 2011-02-09 04:23:32 EST
Spec URL: http://helena.bawue.de/~ixs/perl-NetAddr-IP/perl-NetAddr-IP.spec
SRPM URL: http://helena.bawue.de/~ixs/perl-NetAddr-IP/perl-NetAddr-IP-4.004-1.src.rpm
This module provides an object-oriented abstraction on top of IP addresses
or IP subnets, that allows for easy manipulations. Version 4.xx of
NetAdder::IP will will work older versions of Perl and does not use
Math::BigInt as in previous versions.
Missing br's on:
There's an rfc included under docs/... Why not add it to %doc?
Kay, new package at http://helena.bawue.de/~ixs/perl-NetAddr-IP/
Oddly enough, the module itself is (as near as I can determine) definitely
under the Artistic license, though it includes a copy of the GPL at
Lite/Util/GPL. Weird. --along the same lines, Makefile.PL complains if
Test::Pod isn't installed, but no test actually uses it.
The non-versioned requires on perl(NetAddr::IP::Util) would normally need to
be filtered, but as this package also provides perl(NetAddr::IP::Util), it's
really not worth the effort :)
Missing BR on Test::More -- approval is contingent on this being added (which
can be done post-import).
+ source files match upstream:
+ package meets naming and versioning guidelines.
+ specfile is properly named, is cleanly written and uses macros consistently.
+ dist tag is present.
+ build root is correct.
+ license field matches the actual license.
+ license is open source-compatible. (Artistic) License text not included upstream.
+ latest version is being packaged.
X BuildRequires are proper.
+ compiler flags are appropriate.
+ %clean is present.
+ package installs properly
+ debuginfo package looks complete.
+ rpmlint is silent.
+ final provides and requires are sane:
perl(NetAddr::IP) = 4.4
perl(NetAddr::IP::Lite) = 1.5
perl(NetAddr::IP::Util) = 1.3
perl(NetAddr::IP::UtilPP) = 1.2
perl(NetAddr::IP::Util_IS) = 1.00
perl-NetAddr-IP = 4.004-0.2.fc6
perl(NetAddr::IP::Lite) >= 1.02
O perl(NetAddr::IP::Util) >= 0.17
perl-NetAddr-IP-debuginfo = 4.004-0.2.fc6
+ %check is present and all tests pass
+ no shared libraries are added to the regular linker search paths.
+ owns the directories it creates.
+ doesn't own any directories it shouldn't.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no scriptlets present.
+ code, not content.
+ documentation is small, so no -docs subpackage is necessary.
+ %docs are not necessary for the proper functioning of the package.
+ no headers.
+ no pkgconfig files.
+ no libtool .la droppings.
+ not a GUI app.
Sorry, must have missed this being approved.
New Package CVS Request
Package Name: perl-NetAddr-IP
Short Description: Manages IPv4 and IPv6 addresses and subnets
Branches: FC-5, FC-6, devel
*** Bug 247625 has been marked as a duplicate of this bug. ***
Is there some reason why this hasn't been built yet?
Package Change Request
Package Name: perl-NetAddr-IP
New Branches: F-7