Bug 2363709 (CVE-2023-53083) - CVE-2023-53083 kernel: nfsd: don't replace page in rq_pages if it's a continuation of last page
Summary: CVE-2023-53083 kernel: nfsd: don't replace page in rq_pages if it's a continu...
Keywords:
Status: NEW
Alias: CVE-2023-53083
Product: Security Response
Classification: Other
Component: vulnerability
Version: unspecified
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Product Security DevOps Team
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2025-05-02 16:02 UTC by OSIDB Bzimport
Modified: 2025-05-05 04:46 UTC (History)
4 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed:
Embargoed:


Attachments (Terms of Use)

Description OSIDB Bzimport 2025-05-02 16:02:45 UTC
In the Linux kernel, the following vulnerability has been resolved:

nfsd: don't replace page in rq_pages if it's a continuation of last page

The splice read calls nfsd_splice_actor to put the pages containing file
data into the svc_rqst->rq_pages array. It's possible however to get a
splice result that only has a partial page at the end, if (e.g.) the
filesystem hands back a short read that doesn't cover the whole page.

nfsd_splice_actor will plop the partial page into its rq_pages array and
return. Then later, when nfsd_splice_actor is called again, the
remainder of the page may end up being filled out. At this point,
nfsd_splice_actor will put the page into the array _again_ corrupting
the reply. If this is done enough times, rq_next_page will overrun the
array and corrupt the trailing fields -- the rq_respages and
rq_next_page pointers themselves.

If we've already added the page to the array in the last pass, don't add
it to the array a second time when dealing with a splice continuation.
This was originally handled properly in nfsd_splice_actor, but commit
91e23b1c3982 ("NFSD: Clean up nfsd_splice_actor()") removed the check
for it.

Comment 1 Avinash Hanwate 2025-05-05 04:35:19 UTC
Upstream advisory:
https://lore.kernel.org/linux-cve-announce/2025050217-CVE-2023-53083-5b4e@gregkh/T


Note You need to log in before you can comment on or make changes to this bug.