Spec URL: https://solomoncyj.fedorapeople.org/reviews/rust-khronos-egl/rust-khronos-egl.spec SRPM URL: https://solomoncyj.fedorapeople.org/reviews/rust-khronos-egl/rust-khronos-egl-6.0.0-1.fc42.src.rpm Description: Rust bindings for EGL. Fedora Account System Username: solomoncyj
Copr build: https://copr.fedorainfracloud.org/coprs/build/9000103 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2364325-rust-khronos-egl/fedora-rawhide-x86_64/09000103-rust-khronos-egl/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
> Problem: nothing provides requested (crate(gl/default) >= 0.14.0 with crate(gl/default) < 0.15.0~) It looks like you *can* patch out this dev-dependency, which is only used for some examples, but it looks like you haven’t done so.
Spec URL: https://solomoncyj.fedorapeople.org/reviews/rust-khronos-egl/rust-khronos-egl.spec SRPM URL: https://solomoncyj.fedorapeople.org/reviews/rust-khronos-egl/rust-khronos-egl-6.0.0-1.fc43.src.rpm patch gl
Created attachment 2090178 [details] The .spec file difference from Copr build 9000103 to 9057365
Copr build: https://copr.fedorainfracloud.org/coprs/build/9057365 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2364325-rust-khronos-egl/fedora-rawhide-x86_64/09057365-rust-khronos-egl/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Spec URL: https://solomoncyj.fedorapeople.org/reviews/rust-khronos-egl/rust-khronos-egl.spec SRPM URL: https://solomoncyj.fedorapeople.org/reviews/rust-khronos-egl/rust-khronos-egl-6.0.0-1.fc43.src.rpm - Uncommitted changes
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package does not contain duplicates in %files. Note: warning: File listed twice: /usr/share/cargo/registry/khronos- egl-6.0.0/CHANGELOG.md See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_duplicate_files ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* Apache License 2.0", "*No copyright* MIT License". 16 files have unknown license. Detailed output of licensecheck in /home/pemensik/fedora/rawhide/2364325-rust- khronos-egl/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in rust- khronos-egl-devel , rust-khronos-egl+default-devel , rust-khronos- egl+1_0-devel , rust-khronos-egl+1_1-devel , rust-khronos- egl+1_2-devel , rust-khronos-egl+1_3-devel , rust-khronos- egl+1_4-devel , rust-khronos-egl+1_5-devel , rust-khronos-egl+dynamic- devel , rust-khronos-egl+libloading-devel , rust-khronos-egl+no-pkg- config-devel , rust-khronos-egl+pkg-config-devel , rust-khronos- egl+static-devel [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). See: (this test has no URL) [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. Rpmlint ------- Checking: rust-khronos-egl-devel-6.0.0-1.fc43.noarch.rpm rust-khronos-egl+default-devel-6.0.0-1.fc43.noarch.rpm rust-khronos-egl+1_0-devel-6.0.0-1.fc43.noarch.rpm rust-khronos-egl+1_1-devel-6.0.0-1.fc43.noarch.rpm rust-khronos-egl+1_2-devel-6.0.0-1.fc43.noarch.rpm rust-khronos-egl+1_3-devel-6.0.0-1.fc43.noarch.rpm rust-khronos-egl+1_4-devel-6.0.0-1.fc43.noarch.rpm rust-khronos-egl+1_5-devel-6.0.0-1.fc43.noarch.rpm rust-khronos-egl+dynamic-devel-6.0.0-1.fc43.noarch.rpm rust-khronos-egl+libloading-devel-6.0.0-1.fc43.noarch.rpm rust-khronos-egl+no-pkg-config-devel-6.0.0-1.fc43.noarch.rpm rust-khronos-egl+pkg-config-devel-6.0.0-1.fc43.noarch.rpm rust-khronos-egl+static-devel-6.0.0-1.fc43.noarch.rpm rust-khronos-egl-6.0.0-1.fc43.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.6.1 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpdyyfq1eo')] checks: 32, packages: 14 rust-khronos-egl+1_0-devel.noarch: W: no-documentation rust-khronos-egl+1_1-devel.noarch: W: no-documentation rust-khronos-egl+1_2-devel.noarch: W: no-documentation rust-khronos-egl+1_3-devel.noarch: W: no-documentation rust-khronos-egl+1_4-devel.noarch: W: no-documentation rust-khronos-egl+1_5-devel.noarch: W: no-documentation rust-khronos-egl+default-devel.noarch: W: no-documentation rust-khronos-egl+dynamic-devel.noarch: W: no-documentation rust-khronos-egl+libloading-devel.noarch: W: no-documentation rust-khronos-egl+no-pkg-config-devel.noarch: W: no-documentation rust-khronos-egl+pkg-config-devel.noarch: W: no-documentation rust-khronos-egl+static-devel.noarch: W: no-documentation 14 packages and 0 specfiles checked; 0 errors, 12 warnings, 68 filtered, 0 badness; has taken 0.3 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 13 13 packages and 0 specfiles checked; 0 errors, 0 warnings, 75 filtered, 0 badness; has taken 0.0 s Source checksums ---------------- https://crates.io/api/v1/crates/khronos-egl/6.0.0/download#/khronos-egl-6.0.0.crate : CHECKSUM(SHA256) this package : 6aae1df220ece3c0ada96b8153459b67eebe9ae9212258bb0134ae60416fdf76 CHECKSUM(SHA256) upstream package : 6aae1df220ece3c0ada96b8153459b67eebe9ae9212258bb0134ae60416fdf76 Requires -------- rust-khronos-egl-devel (rpmlib, GLIBC filtered): (crate(libc/default) >= 0.2.0 with crate(libc/default) < 0.3.0~) cargo rust-khronos-egl+default-devel (rpmlib, GLIBC filtered): cargo crate(khronos-egl) crate(khronos-egl/1_5) rust-khronos-egl+1_0-devel (rpmlib, GLIBC filtered): cargo crate(khronos-egl) rust-khronos-egl+1_1-devel (rpmlib, GLIBC filtered): cargo crate(khronos-egl) crate(khronos-egl/1_0) rust-khronos-egl+1_2-devel (rpmlib, GLIBC filtered): cargo crate(khronos-egl) crate(khronos-egl/1_1) rust-khronos-egl+1_3-devel (rpmlib, GLIBC filtered): cargo crate(khronos-egl) crate(khronos-egl/1_2) rust-khronos-egl+1_4-devel (rpmlib, GLIBC filtered): cargo crate(khronos-egl) crate(khronos-egl/1_3) rust-khronos-egl+1_5-devel (rpmlib, GLIBC filtered): cargo crate(khronos-egl) crate(khronos-egl/1_4) rust-khronos-egl+dynamic-devel (rpmlib, GLIBC filtered): cargo crate(khronos-egl) crate(khronos-egl/libloading) rust-khronos-egl+libloading-devel (rpmlib, GLIBC filtered): (crate(libloading/default) >= 0.8.0 with crate(libloading/default) < 0.9.0~) cargo crate(khronos-egl) rust-khronos-egl+no-pkg-config-devel (rpmlib, GLIBC filtered): cargo crate(khronos-egl) rust-khronos-egl+pkg-config-devel (rpmlib, GLIBC filtered): (crate(pkg-config/default) >= 0.3.0 with crate(pkg-config/default) < 0.4.0~) cargo crate(khronos-egl) rust-khronos-egl+static-devel (rpmlib, GLIBC filtered): cargo crate(khronos-egl) crate(khronos-egl/pkg-config) Provides -------- rust-khronos-egl-devel: crate(khronos-egl) rust-khronos-egl-devel rust-khronos-egl+default-devel: crate(khronos-egl/default) rust-khronos-egl+default-devel rust-khronos-egl+1_0-devel: crate(khronos-egl/1_0) rust-khronos-egl+1_0-devel rust-khronos-egl+1_1-devel: crate(khronos-egl/1_1) rust-khronos-egl+1_1-devel rust-khronos-egl+1_2-devel: crate(khronos-egl/1_2) rust-khronos-egl+1_2-devel rust-khronos-egl+1_3-devel: crate(khronos-egl/1_3) rust-khronos-egl+1_3-devel rust-khronos-egl+1_4-devel: crate(khronos-egl/1_4) rust-khronos-egl+1_4-devel rust-khronos-egl+1_5-devel: crate(khronos-egl/1_5) rust-khronos-egl+1_5-devel rust-khronos-egl+dynamic-devel: crate(khronos-egl/dynamic) rust-khronos-egl+dynamic-devel rust-khronos-egl+libloading-devel: crate(khronos-egl/libloading) rust-khronos-egl+libloading-devel rust-khronos-egl+no-pkg-config-devel: crate(khronos-egl/no-pkg-config) rust-khronos-egl+no-pkg-config-devel rust-khronos-egl+pkg-config-devel: crate(khronos-egl/pkg-config) rust-khronos-egl+pkg-config-devel rust-khronos-egl+static-devel: crate(khronos-egl/static) rust-khronos-egl+static-devel Diff spec file in url and in SRPM --------------------------------- --- /home/pemensik/fedora/rawhide/2364325-rust-khronos-egl/srpm/rust-khronos-egl.spec 2025-05-21 18:51:33.448384482 +0200 +++ /home/pemensik/fedora/rawhide/2364325-rust-khronos-egl/srpm-unpacked/rust-khronos-egl.spec 2025-05-17 02:00:00.000000000 +0200 @@ -1,2 +1,12 @@ +## START: Set by rpmautospec +## (rpmautospec version 0.8.1) +## RPMAUTOSPEC: autorelease, autochangelog +%define autorelease(e:s:pb:n) %{?-p:0.}%{lua: + release_number = 1; + base_release_number = tonumber(rpm.expand("%{?-b*}%{!?-b:1}")); + print(release_number + base_release_number - 1); +}%{?-e:.%{-e*}}%{?-s:.%{-s*}}%{!?-n:%{?dist}} +## END: Set by rpmautospec + # Generated by rust2rpm 27 %bcond check 0 @@ -208,3 +218,6 @@ %changelog -%autochangelog +## START: Generated by rpmautospec +* Sat May 17 2025 John Doe <packager> - 6.0.0-1 +- Uncommitted changes +## END: Generated by rpmautospec Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2364325 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api Disabled plugins: Java, Python, Perl, SugarActivity, Haskell, PHP, R, fonts, Ocaml, C/C++ Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
I haven't found anything requiring changes, but without dependencies it is not simple to test it works properly. According to cargo rpmstatus, we are missing dependency: wayland-commons is not packaged yet, but no review seems to exist for it or depending bug exists. But perhaps that is handled by wayland-client crate sufficiently? It may need some tuning to make successful builds using this package, but this package alone should work already.
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-khronos-egl