Spec URL: https://jskarvad.fedorapeople.org/qdmr/qdmr.spec SRPM URL: https://jskarvad.fedorapeople.org/qdmr/qdmr-0.12.1-1.fc43.src.rpm Description: A Qt5 application to program DMR radios. DMR is a digital modulation standard used in amateur and commercial radio. To this end, qdmr is an alternative codeplug programming software (CPS) that supports several radios across several manufacturers. Fedora Account System Username: jskarvad
Upstream ticket regarding the patch and some other minor problems: https://github.com/hmatuschek/qdmr/issues/586
Copr build: https://copr.fedorainfracloud.org/coprs/build/9003585 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2364403-qdmr/fedora-rawhide-x86_64/09003585-qdmr/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
There are quite a lot of complaints on duplicated files in generated libdmrconf-doc package, which is even 100MB large and architecture specific. It might be reduced by removing duplicate and replacing it with symlink. fdupes -r rpms-unpacked/libdmrconf-doc-0.12.1-1.fc43.x86_64.rpm/ -m 922 duplicate files (in 922 sets), occupying 2.8 megabytes rpmlint creates a lot of warnings about it, might be worth solving by after-process somehow. But their size does not seem significant. libdmrconf-doc.x86_64: E: no-binary libdmrconf-doc.x86_64: E: files-duplicated-waste 2826520 If possible, common data should be in noarch doc package. If there are any differences, those might be part of devel package. I expect just few files might be arch-dependent, if any. Requires: libdmrconf{?_isa} = %{version} I think also release should be included in above Requires for %package -n libdmrconf-doc and %package devel. Common usage is %{version}-%{release}, is there any secific reason why is not release included? There are few unowned directories: [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/udev/rules.d, /usr/lib/udev, /usr/share/doc/libdmrconf Depending on systemd-udev should fix first 2, %files -n libdmrconf-doc should own directory without html too.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package installs properly. Note: Installation errors (see attachment) See: https://docs.fedoraproject.org/en-US/packaging-guidelines/ ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GNU General Public License v3.0 or later", "BSD 3-Clause License", "GNU General Public License, Version 3", "*No copyright* GNU General Public License v3.0 or later". 1206 files have unknown license. Detailed output of licensecheck in /home/pemensik/fedora/rawhide/2364403-qdmr/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/udev/rules.d, /usr/lib/udev, /usr/share/doc/libdmrconf [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [!]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 5861 bytes in 1 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in libdmrconf , qdmr-devel [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Rpmlint is run on all installed packages. Note: Mock build failed See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_use_rpmlint [!]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 107253760 bytes in /usr/share libdmrconf-doc-0.12.1-1.fc43.x86_64.rpm:106813440 See: https://fedoraproject.org/wiki/Packaging:ReviewGuidelines#Package_Review_Guidelines [x]: Spec file according to URL is the same as in SRPM. Installation errors ------------------- INFO: mock.py version 6.1 starting (python version = 3.13.3, NVR = mock-6.1-1.fc41), args: /usr/libexec/mock/mock -r fedora-rawhide-x86_64 --no-cleanup-after --no-clean --plugin-option=tmpfs:keep_mounted=True --resultdir=/home/pemensik/fedora/rawhide/2364403-qdmr/results install /home/pemensik/fedora/rawhide/2364403-qdmr/results/qdmr-0.12.1-1.fc43.x86_64.rpm /home/pemensik/fedora/rawhide/2364403-qdmr/results/qdmr-devel-0.12.1-1.fc43.x86_64.rpm /home/pemensik/fedora/rawhide/2364403-qdmr/results/libdmrconf-debuginfo-0.12.1-1.fc43.x86_64.rpm /home/pemensik/fedora/rawhide/2364403-qdmr/results/qdmr-debuginfo-0.12.1-1.fc43.x86_64.rpm /home/pemensik/fedora/rawhide/2364403-qdmr/results/qdmr-debugsource-0.12.1-1.fc43.x86_64.rpm /home/pemensik/fedora/rawhide/2364403-qdmr/results/libdmrconf-doc-0.12.1-1.fc43.x86_64.rpm /home/pemensik/fedora/rawhide/2364403-qdmr/results/libdmrconf-0.12.1-1.fc43.x86_64.rpm Start(bootstrap): init plugins INFO: selinux enabled Finish(bootstrap): init plugins Start: init plugins INFO: selinux enabled Finish: init plugins INFO: Signal handler active Start: run Mock Version: 6.1 INFO: Mock Version: 6.1 Start(bootstrap): chroot init INFO: calling preinit hooks INFO: enabled root cache INFO: enabled package manager cache Start(bootstrap): cleaning package manager metadata Finish(bootstrap): cleaning package manager metadata INFO: Package manager dnf5 detected and used (fallback) Finish(bootstrap): chroot init Start: chroot init INFO: calling preinit hooks INFO: enabled root cache INFO: enabled package manager cache Start: cleaning package manager metadata Finish: cleaning package manager metadata INFO: enabled HW Info plugin INFO: Package manager dnf5 detected and used (direct choice) Finish: chroot init INFO: installing package(s): /builddir/qdmr-0.12.1-1.fc43.x86_64.rpm /builddir/qdmr-devel-0.12.1-1.fc43.x86_64.rpm /builddir/libdmrconf-debuginfo-0.12.1-1.fc43.x86_64.rpm /builddir/qdmr-debuginfo-0.12.1-1.fc43.x86_64.rpm /builddir/qdmr-debugsource-0.12.1-1.fc43.x86_64.rpm /builddir/libdmrconf-doc-0.12.1-1.fc43.x86_64.rpm /builddir/libdmrconf-0.12.1-1.fc43.x86_64.rpm ERROR: Command failed: # /usr/bin/systemd-nspawn -q -M 1fc45b95db4c4410825f2bfd41846694 -D /var/lib/mock/fedora-rawhide-x86_64-bootstrap/root -a --capability=cap_ipc_lock --bind=/tmp/mock-resolv.qmz3fe98:/etc/resolv.conf --console=pipe --setenv=TERM=vt100 --setenv=SHELL=/bin/bash --setenv=HOME=/var/lib/mock/fedora-rawhide-x86_64/root/installation-homedir --setenv=HOSTNAME=mock --setenv=PATH=/usr/bin:/bin:/usr/sbin:/sbin '--setenv=PROMPT_COMMAND=printf "\033]0;<mock-chroot>\007"' '--setenv=PS1=<mock-chroot> \s-\v\$ ' --setenv=LANG=C.UTF-8 --setenv=LC_MESSAGES=C.UTF-8 --resolv-conf=off /usr/bin/dnf5 --installroot /var/lib/mock/fedora-rawhide-x86_64/root/ --releasever 43 install /builddir/qdmr-0.12.1-1.fc43.x86_64.rpm /builddir/qdmr-devel-0.12.1-1.fc43.x86_64.rpm /builddir/libdmrconf-debuginfo-0.12.1-1.fc43.x86_64.rpm /builddir/qdmr-debuginfo-0.12.1-1.fc43.x86_64.rpm /builddir/qdmr-debugsource-0.12.1-1.fc43.x86_64.rpm /builddir/libdmrconf-doc-0.12.1-1.fc43.x86_64.rpm /builddir/libdmrconf-0.12.1-1.fc43.x86_64.rpm --setopt=deltarpm=False --setopt=allow_vendor_change=yes --allowerasing --setopt=tsflags=nocontexts Rpmlint ------- Checking: qdmr-0.12.1-1.fc43.x86_64.rpm libdmrconf-0.12.1-1.fc43.x86_64.rpm libdmrconf-doc-0.12.1-1.fc43.x86_64.rpm qdmr-devel-0.12.1-1.fc43.x86_64.rpm qdmr-0.12.1-1.fc43.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.6.1 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp_3ltfdzf')] checks: 32, packages: 5 libdmrconf.x86_64: E: spelling-error ('qdmr', '%description -l en_US qdmr -> ramrod') qdmr.src: E: spelling-error ('codeplug', '%description -l en_US codeplug -> code plug, code-plug, codependent') qdmr.x86_64: E: spelling-error ('codeplug', '%description -l en_US codeplug -> code plug, code-plug, codependent') qdmr-devel.x86_64: E: spelling-error ('dmrconf', 'Summary(en_US) dmrconf -> conform') qdmr-devel.x86_64: W: no-documentation libdmrconf-doc.x86_64: E: no-binary libdmrconf-doc.x86_64: E: files-duplicated-waste 2826520 libdmrconf-doc.x86_64: W: files-duplicate /usr/share/doc/libdmrconf/html/classAESEncryptionKey__inherit__graph.map /usr/share/doc/libdmrconf/html/classAESEncryptionKey__coll__graph.map libdmrconf-doc.x86_64: W: files-duplicate /usr/share/doc/libdmrconf/html/classAESEncryptionKey__inherit__graph.md5 /usr/share/doc/libdmrconf/html/classAESEncryptionKey__coll__graph.md5 libdmrconf-doc.x86_64: W: files-duplicate /usr/share/doc/libdmrconf/html/classAESEncryptionKey__inherit__graph.png /usr/share/doc/libdmrconf/html/classAESEncryptionKey__coll__graph.png libdmrconf-doc.x86_64: W: files-duplicate /usr/share/doc/libdmrconf/html/classAnytoneAPRSFrequencyList__inherit__graph.map /usr/share/doc/libdmrconf/html/classAnytoneAPRSFrequencyList__coll__graph.map libdmrconf-doc.x86_64: W: files-duplicate /usr/share/doc/libdmrconf/html/classAnytoneAPRSFrequencyList__inherit__graph.md5 /usr/share/doc/libdmrconf/html/classAnytoneAPRSFrequencyList__coll__graph.md5 libdmrconf-doc.x86_64: W: files-duplicate /usr/share/doc/libdmrconf/html/classAnytoneAPRSFrequencyList__inherit__graph.png /usr/share/doc/libdmrconf/html/classAnytoneAPRSFrequencyList__coll__graph.png libdmrconf-doc.x86_64: W: files-duplicate /usr/share/doc/libdmrconf/html/classAnytoneAutoRepeaterOffsetList__inherit__graph.map /usr/share/doc/libdmrconf/html/classAnytoneAutoRepeaterOffsetList__coll__graph.map libdmrconf-doc.x86_64: W: files-duplicate /usr/share/doc/libdmrconf/html/classAnytoneAutoRepeaterOffsetList__inherit__graph.md5 /usr/share/doc/libdmrconf/html/classAnytoneAutoRepeaterOffsetList__coll__graph.md5 libdmrconf-doc.x86_64: W: files-duplicate /usr/share/doc/libdmrconf/html/classAnytoneAutoRepeaterOffsetList__inherit__graph.png /usr/share/doc/libdmrconf/html/classAnytoneAutoRepeaterOffsetList__coll__graph.png libdmrconf-doc.x86_64: W: files-duplicate /usr/share/doc/libdmrconf/html/classAnytoneCodeplug_1_1AlarmSettingElement_1_1AnalogAlarm__inherit__graph.map /usr/share/doc/libdmrconf/html/classAnytoneCodeplug_1_1AlarmSettingElement_1_1AnalogAlarm__coll__graph.map libdmrconf-doc.x86_64: W: files-duplicate /usr/share/doc/libdmrconf/html/classAnytoneCodeplug_1_1AlarmSettingElement_1_1AnalogAlarm__inherit__graph.md5 /usr/share/doc/libdmrconf/html/classAnytoneCodeplug_1_1AlarmSettingElement_1_1AnalogAlarm__coll__graph.md5 ... libdmrconf-doc.x86_64: W: files-duplicate /usr/share/doc/libdmrconf/html/structOpenUV380Codeplug_1_1Limit__inherit__graph.map /usr/share/doc/libdmrconf/html/structOpenUV380Codeplug_1_1Limit__coll__graph.map libdmrconf-doc.x86_64: W: files-duplicate /usr/share/doc/libdmrconf/html/structOpenUV380Codeplug_1_1Limit__inherit__graph.md5 /usr/share/doc/libdmrconf/html/structOpenUV380Codeplug_1_1Limit__coll__graph.md5 libdmrconf-doc.x86_64: W: files-duplicate /usr/share/doc/libdmrconf/html/structOpenUV380Codeplug_1_1Limit__inherit__graph.png /usr/share/doc/libdmrconf/html/structOpenUV380Codeplug_1_1Limit__coll__graph.png libdmrconf-doc.x86_64: W: files-duplicate /usr/share/doc/libdmrconf/html/structRD5RCodeplug_1_1ChannelElement_1_1Offset__inherit__graph.map /usr/share/doc/libdmrconf/html/structRD5RCodeplug_1_1ChannelElement_1_1Offset__coll__graph.map libdmrconf-doc.x86_64: W: files-duplicate /usr/share/doc/libdmrconf/html/structRD5RCodeplug_1_1ChannelElement_1_1Offset__inherit__graph.md5 /usr/share/doc/libdmrconf/html/structRD5RCodeplug_1_1ChannelElement_1_1Offset__coll__graph.md5 libdmrconf-doc.x86_64: W: files-duplicate /usr/share/doc/libdmrconf/html/structRD5RCodeplug_1_1ChannelElement_1_1Offset__inherit__graph.png /usr/share/doc/libdmrconf/html/structRD5RCodeplug_1_1ChannelElement_1_1Offset__coll__graph.png 5 packages and 0 specfiles checked; 6 errors, 923 warnings, 29 filtered, 6 badness; has taken 4.2 s Source checksums ---------------- https://github.com/hmatuschek/qdmr/archive/refs/tags/v0.12.1/qdmr-0.12.1.tar.gz : CHECKSUM(SHA256) this package : 80eaadc6f817894fde6773d1b021e7a8ec051cbb774f63e6a097e21d8a56d8b5 CHECKSUM(SHA256) upstream package : 80eaadc6f817894fde6773d1b021e7a8ec051cbb774f63e6a097e21d8a56d8b5 Requires -------- qdmr (rpmlib, GLIBC filtered): hicolor-icon-theme libQt5Core.so.5()(64bit) libQt5Core.so.5(Qt_5)(64bit) libQt5Core.so.5(Qt_5.15)(64bit) libQt5Gui.so.5()(64bit) libQt5Gui.so.5(Qt_5)(64bit) libQt5Network.so.5()(64bit) libQt5Network.so.5(Qt_5)(64bit) libQt5Positioning.so.5()(64bit) libQt5Positioning.so.5(Qt_5)(64bit) libQt5Widgets.so.5()(64bit) libQt5Widgets.so.5(Qt_5)(64bit) libc.so.6()(64bit) libdmrconf.so.0()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) rtld(GNU_HASH) libdmrconf (rpmlib, GLIBC filtered): libQt5Core.so.5()(64bit) libQt5Core.so.5(Qt_5)(64bit) libQt5Core.so.5(Qt_5.15)(64bit) libQt5Network.so.5()(64bit) libQt5Network.so.5(Qt_5)(64bit) libQt5Positioning.so.5()(64bit) libQt5Positioning.so.5(Qt_5)(64bit) libQt5SerialPort.so.5()(64bit) libQt5SerialPort.so.5(Qt_5)(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libm.so.6()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) libusb-1.0.so.0()(64bit) libyaml-cpp.so.0.8()(64bit) rtld(GNU_HASH) libdmrconf-doc (rpmlib, GLIBC filtered): libdmrconf{?_isa} qdmr-devel (rpmlib, GLIBC filtered): libdmrconf(x86-64) libdmrconf.so.0()(64bit) Provides -------- qdmr: application() application(qdmr.desktop) qdmr qdmr(x86-64) libdmrconf: libdmrconf libdmrconf(x86-64) libdmrconf.so.0()(64bit) libdmrconf-doc: libdmrconf-doc libdmrconf-doc(x86-64) qdmr-devel: qdmr-devel qdmr-devel(x86-64) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2364403 Buildroot used: fedora-rawhide-x86_64 Active plugins: C/C++, Shell-api, Generic Disabled plugins: SugarActivity, Java, fonts, R, Ocaml, Haskell, PHP, Perl, Python Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
Created attachment 2088633 [details] rpmlint.txt
I think just fixing unowned directories is mandatory. Reducing duplicity and switching libdmrconf-doc to noarch would be nice, but not strictly necessary. Otherwise package is ready to pass the review IMO.
By the way, I think that since QDMR is a desktop application, the following fix should also be added as a patch (until a new upstream QDMR version gets released): https://github.com/hmatuschek/qdmr/pull/587
@Petr Menšík thanks for the review. @Daniel Rusek thanks for the patch. New version: Spec URL: https://jskarvad.fedorapeople.org/qdmr/qdmr.spec SRPM URL: https://jskarvad.fedorapeople.org/qdmr/qdmr-0.12.1-2.fc43.src.rpm
Created attachment 2088678 [details] The .spec file difference from Copr build 9003585 to 9004436
Copr build: https://copr.fedorainfracloud.org/coprs/build/9004436 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2364403-qdmr/fedora-rawhide-x86_64/09004436-qdmr/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Eh, nice, comment #8 fixes my unowned directories. But because metainfo file is added as well, there should be a format check of it similar to desktop file verification. According to: https://docs.fedoraproject.org/en-US/packaging-guidelines/AppData/ This is mandatory step now missing: The AppData files MUST correctly validate using appstream-util validate-relax. There is an addition at the bottom, requiring this in %check or %install section. https://docs.fedoraproject.org/en-US/packaging-guidelines/AppData/#_app_data_validate_usage
(In reply to Petr Menšík from comment #11) > Eh, nice, comment #8 fixes my unowned directories. But because metainfo file > is added as well, there should be a format check of it similar to desktop > file verification. > > According to: > https://docs.fedoraproject.org/en-US/packaging-guidelines/AppData/ > > This is mandatory step now missing: > The AppData files MUST correctly validate using appstream-util > validate-relax. > > There is an addition at the bottom, requiring this in %check or %install > section. > > https://docs.fedoraproject.org/en-US/packaging-guidelines/AppData/ > #_app_data_validate_usage Thanks, good point, I just merged @Daniel Rusek patch which was missing it.
New version: Spec URL: https://jskarvad.fedorapeople.org/qdmr/qdmr.spec SRPM URL: https://jskarvad.fedorapeople.org/qdmr/qdmr-0.12.1-3.fc43.src.rpm
Created attachment 2089636 [details] The .spec file difference from Copr build 9004436 to 9033421
Copr build: https://copr.fedorainfracloud.org/coprs/build/9033421 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2364403-qdmr/fedora-rawhide-x86_64/09033421-qdmr/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Seems fine, passing the review!
Thanks.
The Pagure repository was created at https://src.fedoraproject.org/rpms/qdmr
FEDORA-2025-8fb74b6eac (qdmr-0.12.1-3.fc42) has been submitted as an update to Fedora 42. https://bodhi.fedoraproject.org/updates/FEDORA-2025-8fb74b6eac
FEDORA-2025-9e859161d4 (qdmr-0.12.1-3.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2025-9e859161d4
FEDORA-2025-8fb74b6eac has been pushed to the Fedora 42 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-8fb74b6eac \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-8fb74b6eac See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2025-9e859161d4 has been pushed to the Fedora 41 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-9e859161d4 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-9e859161d4 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2025-400b8715f0 has been pushed to the Fedora 42 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-400b8715f0` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-400b8715f0 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2025-5f1e27ddae has been pushed to the Fedora 41 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-5f1e27ddae` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-5f1e27ddae See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2025-2e19ec2775 has been pushed to the Fedora 42 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-2e19ec2775` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-2e19ec2775 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2025-74a76fbb11 has been pushed to the Fedora 41 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-74a76fbb11` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-74a76fbb11 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2025-74a76fbb11 (qdmr-0.12.1-5.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2025-2e19ec2775 (qdmr-0.12.1-5.fc42) has been pushed to the Fedora 42 stable repository. If problem still persists, please make note of it in this bug report.