Red Hat Bugzilla – Bug 236512
Yum no longer sets repo.callback before calling postreposetup_hook
Last modified: 2014-01-21 17:57:48 EST
Description of problem:
Yum doesn't set repo.callback before calling postreposetup_hook. This means
that any plugins that want to use that callback are out of luck.
Version-Release number of selected component (if applicable):
Steps to Reproduce:
1. Install yum-presto-0.3.9 on an FC6 box
2. Install yum-presto-0.3.9 on a Rawhide box
On FC6 box, yum-presto shows progress as downloading deltarpms
On Rawhide box, yum-presto shows nothing as downloading deltarpms
On Rawhide box, yum-presto should show progress
Yum-presto has a prestoRepo object that is basically a yumRepo with some data
changed. It takes all its callbacks from its parent yumRepo, but in Rawhide
they're not set before postreposetup_hook is called.
Fixed in upstream CVS for 3.1.7 I think. Let me know if that doesn't fix things
I'm running yum-3.1.7-1.fc7, and this bug is still there. The other bug
affecting yum-presto in rawhide, 237425 (having to do with options not being
set) has been fixed.
Urk. I see what's going on.
In output.py, we do self.repos.setCallback... this ends up doing the repo set up
and thus implicitly calls the hooks. I think the real problem is that we're
doing the set up from the YumBase object instead of the RepoStorage...
Fixing this is going to be scary for this stage of the game; hopefully I'll have
a patch this evening
What's the status on this?
FWIW, Jeremy has posted a fix to yum-devel recently.
Yeah, so I have something that looks pretty good for a patch, but it's a bit
scary. Seth and I talked a bit the other day and we think the safest route is
to not fix this in F7 final and then get the fix into 3.2.1 as a pretty quick
update to F7.
Jonathan -- this means that there's not progress with presto at first, but that
feels like a reasonable compromise weighed against having the change break
things for all cases. If you're really against it, we can go with pushing the
change, it just makes me a smidge uncomfortable at this point.
Well, seeing as we won't even have "official" F7 presto repositories when F7
comes out, I think you're making the right decision.
Here's looking forward to that update when it does come out!
Fix committed upstream; will be in 3.2.1
3.2.1 is out and we can close this