Spec URL: https://sgallagh.fedorapeople.org/packagereview/python-aiolimiter/python-aiolimiter.spec SRPM URL: https://sgallagh.fedorapeople.org/packagereview/python-aiolimiter/python-aiolimiter-1.2.1-2.fc43.src.rpm Description: An efficient implementation of a rate limiter for asyncio. This project implements the Leaky bucket algorithm, giving you precise control over the rate a code section can be entered. Fedora Account System Username: sgallagh
Built in COPR: https://copr.fedorainfracloud.org/coprs/sgallagh/python-aiolimiter/ Fedora Review (automated): https://download.copr.fedorainfracloud.org/results/sgallagh/python-aiolimiter/fedora-rawhide-x86_64/09024027-python-aiolimiter/fedora-review/review.txt
Copr build: https://copr.fedorainfracloud.org/coprs/build/9024065 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2365640-python-aiolimiter/fedora-rawhide-x86_64/09024065-python-aiolimiter/fedora-review/review.txt Found issues: - python3-toml is deprecated, you must not depend on it. Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/deprecating-packages/ - License file LICENSE.txt is not marked as %license Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Spec URL: https://sgallagh.fedorapeople.org/packagereview/python-aiolimiter/python-aiolimiter.spec SRPM URL: https://sgallagh.fedorapeople.org/packagereview/python-aiolimiter/python-aiolimiter-1.2.1-4.fc43.src.rpm
Created attachment 2089532 [details] The .spec file difference from Copr build 9024065 to 9024306
Copr build: https://copr.fedorainfracloud.org/coprs/build/9024306 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2365640-python-aiolimiter/fedora-rawhide-x86_64/09024306-python-aiolimiter/fedora-review/review.txt Found issues: - python3-toml is deprecated, you must not depend on it. Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/deprecating-packages/ Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Thank you for the package Stephen, > Issues: > ======= > - Package must not depend on deprecated() packages. > Note: python3-toml is deprecated, you must not depend on it. > See: https://docs.fedoraproject.org/en-US/packaging- > guidelines/deprecating-packages/ This is a test-only dependency, behind a conditional, and with a proposed patch to the upstream. Let's not block the review by this. > W: summary-ended-with-dot An efficient implementation of a rate limiter for asyncio. > E: description-line-too-long This project implements the Leaky bucket algorithm, giving you precise control over the rate a code section can be entered. Rpmlint found these two easy-to-fix issues. Can be done post-review. > BuildRequires: python3-toml > %if 0%{?rhel} < 10 > BuildRequires: python3-toml > %endif # rhel9 Should there be the first python3-toml? Also, the %endif comment should probably say rhel10 All minor things, I am giving +1 here. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package must not depend on deprecated() packages. Note: python3-toml is deprecated, you must not depend on it. See: https://docs.fedoraproject.org/en-US/packaging- guidelines/deprecating-packages/ ===== MUST items ===== Generic: [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "MIT License", "Unknown or generated". 23 files have unknown license. Detailed output of licensecheck in /var/lib/copr- rpmbuild/results/python-aiolimiter/licensecheck.txt [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/python3.13/site- packages, /usr/lib/python3.13 [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 5634 bytes in 2 files. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [x]: Reviewer should test that the package builds in mock. [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [?]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [?]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Spec use %global instead of %define unless justified. Note: %define requiring justification: %define autorelease(e:s:pb:n) %{?-p:0.}%{lua: [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. Rpmlint ------- Checking: python3-aiolimiter-1.2.1-4.fc43.noarch.rpm python-aiolimiter-1.2.1-4.fc43.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.6.1 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp09cwahh1')] checks: 32, packages: 2 python-aiolimiter.src: W: summary-ended-with-dot An efficient implementation of a rate limiter for asyncio. python3-aiolimiter.noarch: W: summary-ended-with-dot An efficient implementation of a rate limiter for asyncio. python-aiolimiter.src: E: description-line-too-long This project implements the Leaky bucket algorithm, giving you precise control over the rate a code section can be entered. python3-aiolimiter.noarch: E: description-line-too-long This project implements the Leaky bucket algorithm, giving you precise control over the rate a code section can be entered. 2 packages and 0 specfiles checked; 2 errors, 2 warnings, 11 filtered, 2 badness; has taken 0.3 s Rpmlint (installed packages) ---------------------------- (none): E: there is no installed rpm "python3-aiolimiter". There are no files to process nor additional arguments. Nothing to do, aborting. ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 filtered, 0 badness; has taken 0.0 s Source checksums ---------------- https://github.com/mjpieters/aiolimiter/archive/v1.2.1/aiolimiter-1.2.1.tar.gz : CHECKSUM(SHA256) this package : faa4d74d9354352f6db2c98c1dca2a7bbc2ea50e51fe5899c9b9b257b1eff2ee CHECKSUM(SHA256) upstream package : faa4d74d9354352f6db2c98c1dca2a7bbc2ea50e51fe5899c9b9b257b1eff2ee Requires -------- python3-aiolimiter (rpmlib, GLIBC filtered): python(abi) Provides -------- python3-aiolimiter: python-aiolimiter python3-aiolimiter python3.13-aiolimiter python3.13dist(aiolimiter) python3dist(aiolimiter) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/bin/fedora-review --no-colors --prebuilt --rpm-spec --name python-aiolimiter --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-rawhide-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: C/C++, SugarActivity, Java, Haskell, fonts, R, Ocaml, Perl, PHP Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
(In reply to Jakub Kadlčík from comment #6) > Thank you for the package Stephen, > > > Issues: > > ======= > > - Package must not depend on deprecated() packages. > > Note: python3-toml is deprecated, you must not depend on it. > > See: https://docs.fedoraproject.org/en-US/packaging- > > guidelines/deprecating-packages/ > > This is a test-only dependency, behind a conditional, and with a proposed > patch to the upstream. Let's not block the review by this. > I think that was due to the other issue below. > > > W: summary-ended-with-dot An efficient implementation of a rate limiter for asyncio. > > E: description-line-too-long This project implements the Leaky bucket algorithm, giving you precise control over the rate a code section can be entered. > > Rpmlint found these two easy-to-fix issues. Can be done post-review. > > > > BuildRequires: python3-toml > > %if 0%{?rhel} < 10 > > BuildRequires: python3-toml > > %endif # rhel9 > > Should there be the first python3-toml? Also, the %endif comment should > probably say rhel10 > I put that there while I was testing and forgot to remove it before pushing the latest spec/SRPM. I just re-tested without it to make sure I didn't get false successes earlier. The `rhel9` comment there was intentional; the test is for "less than RHEL 10". That said, I removed it because the version of RPM on RHEL 9 apparently doesn't accept it.
The Pagure repository was created at https://src.fedoraproject.org/rpms/python-aiolimiter
FEDORA-2025-158324aaaf (python-aiolimiter-1.2.1-7.fc42) has been submitted as an update to Fedora 42. https://bodhi.fedoraproject.org/updates/FEDORA-2025-158324aaaf
FEDORA-EPEL-2025-68b6db6ea8 (python-aiolimiter-1.2.1-7.el10_1) has been submitted as an update to Fedora EPEL 10.1. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2025-68b6db6ea8
FEDORA-EPEL-2025-168213d893 (python-aiolimiter-1.2.1-7.el9) has been submitted as an update to Fedora EPEL 9. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2025-168213d893
FEDORA-2025-a5696ec745 (python-aiolimiter-1.2.1-7.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-EPEL-2025-168213d893 has been pushed to the Fedora EPEL 9 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2025-168213d893 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2025-158324aaaf (python-aiolimiter-1.2.1-7.fc42) has been pushed to the Fedora 42 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-EPEL-2025-68b6db6ea8 has been pushed to the Fedora EPEL 10.1 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2025-68b6db6ea8 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-EPEL-2025-168213d893 (python-aiolimiter-1.2.1-7.el9) has been pushed to the Fedora EPEL 9 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-EPEL-2025-68b6db6ea8 (python-aiolimiter-1.2.1-7.el10_1) has been pushed to the Fedora EPEL 10.1 stable repository. If problem still persists, please make note of it in this bug report.