Spec URL: https://lecris.fedorapeople.org/reviews/lief/lief.spec SRPM URL: https://lecris.fedorapeople.org/reviews/lief/lief-0.16.5-1.fc43.src.rpm Description: The purpose of this project is to provide a cross-platform library to parse, modify and abstract ELF, PE and MachO formats. Fedora Account System Username: lecris Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=132773120
Copr build: https://copr.fedorainfracloud.org/coprs/build/9050195 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2366506-lief/fedora-rawhide-x86_64/09050195-lief/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
The first part of the soname should not be globbed https://docs.fedoraproject.org/en-US/packaging-guidelines/#_shared_libraries Can tcb-span be packaged instead of bundled: https://github.com/tcbrindle/span Can documentation be generated? https://github.com/lief-project/LIEF/tree/main/doc Suggest using docbook or any other form that will not introduce javascript and additional fonts but will still be reasonably complete.
Spec URL: https://lecris.fedorapeople.org/reviews/lief/lief.spec SRPM URL: https://lecris.fedorapeople.org/reviews/lief/lief-0.16.5^20250521gitdc66460-1.fc43.src.rpm Unbundled `span` (see dependent bug), and added a soversion macro. About documentation though, I am reluctant to generate it because it does not have `man` or other artifacts that are usable by the system, and there may be unpackaged dependencies.
Created attachment 2091015 [details] The .spec file difference from Copr build 9050195 to 9069433
Copr build: https://copr.fedorainfracloud.org/coprs/build/9069433 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2366506-lief/fedora-rawhide-x86_64/09069433-lief/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Spec URL: https://lecris.fedorapeople.org/reviews/lief/lief.spec SRPM URL: https://lecris.fedorapeople.org/reviews/lief/lief-0.17.0~20250521gitdc66460-1.fc43.src.rpm Version should have been 0.17.0 to match the library version. Using a pre-release indicator for the snapshot
Created attachment 2091016 [details] The .spec file difference from Copr build 9069433 to 9069438
Copr build: https://copr.fedorainfracloud.org/coprs/build/9069438 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2366506-lief/fedora-rawhide-x86_64/09069438-lief/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
[fedora-review-service-build]
Copr build: https://copr.fedorainfracloud.org/coprs/build/9092229 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2366506-lief/fedora-rawhide-x86_64/09092229-lief/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Copr build: https://copr.fedorainfracloud.org/coprs/build/9103867 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2366506-lief/fedora-rawhide-x86_64/09103867-lief/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Spec URL: https://lecris.fedorapeople.org/reviews/lief/lief.spec SRPM URL: https://lecris.fedorapeople.org/reviews/lief/lief-0.17.0~20250730git971a8de-1.fc43.src.rpm Bumped the commit to resolve the s390x issue Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=135536558