spec: https://suve.fedorapeople.org/review/php-php81_bc-strftime-0.7.6-1/php-php81_bc-strftime.spec srpm: https://suve.fedorapeople.org/review/php-php81_bc-strftime-0.7.6-1/php-php81_bc-strftime-0.7.6-1.fc42.src.rpm koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=132783923 Description: The strftime() function has been marked as deprecated in PHP 8.1. This package provides a locale-formatted strftime() implementation using IntlDateFormatter, for projects seeking an easy, backwards-compatible solution. FAS username: suve
Copr build: https://copr.fedorainfracloud.org/coprs/build/9051146 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2366627-php-php81_bc-strftime/fedora-rawhide-x86_64/09051146-php-php81_bc-strftime/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "MIT License", "*No copyright* MIT License". 15 files have unknown license. Detailed output of licensecheck in /home/fedora-packaging/reviews/php- php81_bc-strftime/licensecheck.txt [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 11955 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Spec file according to URL is the same as in SRPM. PHP: [x]: Run phpci static analyze on all php files. Note: 7.2.3@25777bc static analyze results in /home/benson/Projects/fedora-packaging/reviews/php-php81_bc- strftime/2366627-php-php81_bc-strftime/srpm-unpacked/review-php- php81_bc-strftime/phpci.log Rpmlint ------- Checking: php-php81_bc-strftime-0.7.6-1.fc44.noarch.rpm php-php81_bc-strftime-0.7.6-1.fc44.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpnipgbtj5')] checks: 32, packages: 2 php-php81_bc-strftime.spec:63: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 63) 2 packages and 0 specfiles checked; 0 errors, 1 warnings, 7 filtered, 0 badness; has taken 0.2 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 3 filtered, 0 badness; has taken 0.0 s Source checksums ---------------- https://github.com/alphp/strftime/archive/0.7.6/strftime-0.7.6.tar.gz : CHECKSUM(SHA256) this package : 07c02120e31ae9438b3c33a407c68e168881eac8fdaaa6e2af5d740ba070fb48 CHECKSUM(SHA256) upstream package : 07c02120e31ae9438b3c33a407c68e168881eac8fdaaa6e2af5d740ba070fb48 Requires -------- php-php81_bc-strftime (rpmlib, GLIBC filtered): php(language) php-intl Provides -------- php-php81_bc-strftime: php-composer(php81_bc/strftime) php-php81_bc-strftime Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -n php-php81_bc-strftime Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, PHP, Generic Disabled plugins: R, Ocaml, Java, Perl, Python, fonts, Haskell, C/C++, SugarActivity Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH Comments: a) Consider using %autorelease and %autochangelog macros b) Koji build https://koji.fedoraproject.org/koji/taskinfo?taskID=138140680 c) Approved.
The Pagure repository was created at https://src.fedoraproject.org/rpms/php-php81_bc-strftime
FEDORA-2025-e6ce056923 (dokuwiki-20250514b-1.fc43 and php-php81_bc-strftime-0.7.6-1.fc43) has been submitted as an update to Fedora 43. https://bodhi.fedoraproject.org/updates/FEDORA-2025-e6ce056923
FEDORA-2025-5c621a5a8a (dokuwiki-20250514b-1.fc44 and php-php81_bc-strftime-0.7.6-1.fc44) has been submitted as an update to Fedora 44. https://bodhi.fedoraproject.org/updates/FEDORA-2025-5c621a5a8a
FEDORA-2025-5c621a5a8a (dokuwiki-20250514b-1.fc44 and php-php81_bc-strftime-0.7.6-1.fc44) has been pushed to the Fedora 44 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2025-e6ce056923 has been pushed to the Fedora 43 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-e6ce056923` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-e6ce056923 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2025-e6ce056923 (dokuwiki-20250514b-1.fc43 and php-php81_bc-strftime-0.7.6-1.fc43) has been pushed to the Fedora 43 stable repository. If problem still persists, please make note of it in this bug report.