Bug 2366744 - Review Request: rust-cobs - Implementation of the Consistent Overhead Byte Stuffing (COBS) algorithm
Summary: Review Request: rust-cobs - Implementation of the Consistent Overhead Byte St...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/cobs
Whiteboard:
Depends On:
Blocks: 2366746
TreeView+ depends on / blocked
 
Reported: 2025-05-16 05:07 UTC by Ben Beasley
Modified: 2025-05-30 01:44 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2025-05-20 17:58:47 UTC
Type: Bug
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)
Configuration file for rust2rpm (748 bytes, text/plain)
2025-05-16 05:07 UTC, Ben Beasley
no flags Details

Description Ben Beasley 2025-05-16 05:07:28 UTC
Created attachment 2090046 [details]
Configuration file for rust2rpm

Spec URL: https://music.fedorapeople.org/rust-cobs.spec
SRPM URL: https://music.fedorapeople.org/rust-cobs-0.3.0-1.fc42.src.rpm

Description:

This is an implementation of the Consistent Overhead Byte Stuffing (COBS)
algorithm. COBS is an algorithm for transforming a message into an encoding
where a specific value (the "sentinel" value) is not used. This value can then
be used to mark frame boundaries in a serial communication channel.

Fedora Account System Username: music

Comment 1 Fedora Review Service 2025-05-16 18:10:50 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/9056195
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2366744-rust-cobs/fedora-rawhide-x86_64/09056195-rust-cobs/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Fedora Review Service 2025-05-16 18:11:41 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/9056194
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2366744-rust-cobs/fedora-rawhide-x86_64/09056194-rust-cobs/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Fabio Valentini 2025-05-20 17:22:57 UTC
Package was generated with rust2rpm, simplifying the review.

The patch is reasonable and documented.
Disabling unused optional support for the defmt crate is reasonable as well.

✅ package contains only permissible content
✅ package builds and installs without errors on rawhide
✅ test suite is run and all unit tests pass
✅ latest version of the crate is packaged
✅ license matches upstream specification and is acceptable for Fedora
✅ license files are included with %license in %files
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter (*NOT* pre-release filter): alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- set bugzilla assignee overrides to @rust-sig (optional)

Comment 4 Ben Beasley 2025-05-20 17:29:43 UTC
Thank you for the review!

https://release-monitoring.org/project/378279/

Comment 5 Fedora Admin user for bugzilla script actions 2025-05-20 17:35:29 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-cobs

Comment 6 Fedora Update System 2025-05-20 17:54:46 UTC
FEDORA-2025-58d11bd5ba (rust-cobs-0.3.0-1.fc43) has been submitted as an update to Fedora 43.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-58d11bd5ba

Comment 7 Fedora Update System 2025-05-20 17:58:47 UTC
FEDORA-2025-58d11bd5ba (rust-cobs-0.3.0-1.fc43) has been pushed to the Fedora 43 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 8 Fedora Update System 2025-05-21 13:43:57 UTC
FEDORA-2025-a200b5835c (rust-cobs-0.3.0-1.fc42, rust-icu_collections-1.5.0-6.fc42, and 9 more) has been submitted as an update to Fedora 42.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-a200b5835c

Comment 9 Fedora Update System 2025-05-21 13:45:03 UTC
FEDORA-2025-2494ae440f (rust-cobs-0.3.0-1.fc41, rust-icu_collections-1.5.0-6.fc41, and 9 more) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-2494ae440f

Comment 10 Fedora Update System 2025-05-21 13:45:47 UTC
FEDORA-EPEL-2025-da425cf623 (rust-cobs-0.3.0-1.el10_1, rust-icu_collections-1.5.0-6.el10_1, and 9 more) has been submitted as an update to Fedora EPEL 10.1.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2025-da425cf623

Comment 11 Fedora Update System 2025-05-21 13:46:52 UTC
FEDORA-EPEL-2025-84a74db226 (rust-cobs-0.3.0-1.el9, rust-icu_collections-1.5.0-6.el9, and 9 more) has been submitted as an update to Fedora EPEL 9.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2025-84a74db226

Comment 12 Fedora Update System 2025-05-22 01:13:34 UTC
FEDORA-2025-a200b5835c has been pushed to the Fedora 42 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-a200b5835c \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-a200b5835c

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 13 Fedora Update System 2025-05-22 01:59:34 UTC
FEDORA-EPEL-2025-84a74db226 has been pushed to the Fedora EPEL 9 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2025-84a74db226

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 14 Fedora Update System 2025-05-22 02:13:18 UTC
FEDORA-EPEL-2025-da425cf623 has been pushed to the Fedora EPEL 10.1 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2025-da425cf623

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 15 Fedora Update System 2025-05-22 02:22:01 UTC
FEDORA-2025-2494ae440f has been pushed to the Fedora 41 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-2494ae440f \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-2494ae440f

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 16 Fedora Update System 2025-05-30 00:40:03 UTC
FEDORA-EPEL-2025-84a74db226 (rust-cobs-0.3.0-1.el9, rust-icu_collections-1.5.0-6.el9, and 9 more) has been pushed to the Fedora EPEL 9 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 17 Fedora Update System 2025-05-30 00:59:32 UTC
FEDORA-EPEL-2025-da425cf623 (rust-cobs-0.3.0-1.el10_1, rust-icu_collections-1.5.0-6.el10_1, and 9 more) has been pushed to the Fedora EPEL 10.1 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 18 Fedora Update System 2025-05-30 01:14:54 UTC
FEDORA-2025-a200b5835c (rust-cobs-0.3.0-1.fc42, rust-icu_collections-1.5.0-6.fc42, and 9 more) has been pushed to the Fedora 42 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 19 Fedora Update System 2025-05-30 01:44:37 UTC
FEDORA-2025-2494ae440f (rust-cobs-0.3.0-1.fc41, rust-icu_collections-1.5.0-6.fc41, and 9 more) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.