Spec URL: https://solomoncyj.fedorapeople.org/reviews/rust-bmart-derive/rust-bmart-derive.spec SRPM URL: https://solomoncyj.fedorapeople.org/reviews/rust-bmart-derive/rust-bmart-derive-0.1.4-1.fc43.src.rpm Description: Bohemia Automation common tools library (derive macros). Fedora Account System Username: solomoncyj
Spec URL: https://solomoncyj.fedorapeople.org/reviews/rust-bmart-derive/rust-bmart-derive.spec SRPM URL: https://solomoncyj.fedorapeople.org/reviews/rust-bmart-derive/rust-bmart-derive-0.1.4-1.fc43.src.rpm - Uncommitted changes
The source RPM still has the LICENSE file from https://github.com/roboplc/virtual-terminal/raw/refs/heads/main/LICENSE instead of the one from Source1, https://github.com/eva-ics/bmart/raw/2d8447ea8731fb933bb1d94d6df0c099ff28f5bd/LICENSE
Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter (*NOT* pre-release filter): alpha;beta;rc;pre distro: Fedora Package: rust-$crate - add @rust-sig with "commit" access as package co-maintainer (should happen automatically) - set bugzilla assignee overrides to @rust-sig (optional) - track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer) === Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated The spec file is generated by rust2rpm, simplifying the review. Compared to the unmodified rust2rpm output, I noted that rpmautospec macros are expanded, and that a license file was patched in: +# * include license file +# * https://github.com/eva-ics/bmart/pull/1 +Source1: https://github.com/eva-ics/bmart/raw/2d8447ea8731fb933bb1d94d6df0c099ff28f5bd/LICENSE […] %files devel -# FIXME: no license files detected +%license %{crate_instdir}/LICENSE […] %cargo_prep +# copy in license file +cp -p %{SOURCE1} . The license-file patch is necessary, is done correctly, and has upstream status. Issues: ======= - Package does not contain duplicates in %files. Note: warning: File listed twice: /usr/share/cargo/registry/bmart- derive-0.1.4/LICENSE See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_duplicate_files This is not a serious problem; due to a reasonable rust2rpm design decision. ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 5 files have unknown license. Detailed output of licensecheck in /home/ben/fedora/review/2366978-rust-bmart- derive/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in rust- bmart-derive-devel , rust-bmart-derive+default-devel [x]: Package functions as described. (Tests pass.) [x]: Latest version is packaged. [-]: Package does not include license text files separate from upstream. License file patched in correctly (and necessarily) with the appropriate change submitted upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. https://koji.fedoraproject.org/koji/taskinfo?taskID=132916064 [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). See: (this test has no URL) [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. Rpmlint ------- Checking: rust-bmart-derive-devel-0.1.4-1.fc43.noarch.rpm rust-bmart-derive+default-devel-0.1.4-1.fc43.noarch.rpm rust-bmart-derive-0.1.4-1.fc43.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp41sczprs')] checks: 32, packages: 3 3 packages and 0 specfiles checked; 0 errors, 0 warnings, 13 filtered, 0 badness; has taken 0.1 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 2 2 packages and 0 specfiles checked; 0 errors, 0 warnings, 9 filtered, 0 badness; has taken 0.0 s Source checksums ---------------- https://github.com/eva-ics/bmart/raw/2d8447ea8731fb933bb1d94d6df0c099ff28f5bd/LICENSE : CHECKSUM(SHA256) this package : 969b726b78c2ce8dbef5bb77b89cc3e83b5346826d903157704e1c27babdcf4d CHECKSUM(SHA256) upstream package : 969b726b78c2ce8dbef5bb77b89cc3e83b5346826d903157704e1c27babdcf4d https://crates.io/api/v1/crates/bmart-derive/0.1.4/download#/bmart-derive-0.1.4.crate : CHECKSUM(SHA256) this package : 03fef4da9ab97084fa2135d13ec196ce7e3ddb99e89fef1cfb72fd77bb559855 CHECKSUM(SHA256) upstream package : 03fef4da9ab97084fa2135d13ec196ce7e3ddb99e89fef1cfb72fd77bb559855 Requires -------- rust-bmart-derive-devel (rpmlib, GLIBC filtered): (crate(quote/default) >= 1.0.9 with crate(quote/default) < 2.0.0~) (crate(syn/default) >= 1.0.91 with crate(syn/default) < 2.0.0~) (crate(syn/extra-traits) >= 1.0.91 with crate(syn/extra-traits) < 2.0.0~) (crate(syn/full) >= 1.0.91 with crate(syn/full) < 2.0.0~) cargo rust-bmart-derive+default-devel (rpmlib, GLIBC filtered): cargo crate(bmart-derive) Provides -------- rust-bmart-derive-devel: crate(bmart-derive) rust-bmart-derive-devel rust-bmart-derive+default-devel: crate(bmart-derive/default) rust-bmart-derive+default-devel Diff spec file in url and in SRPM --------------------------------- --- /home/ben/fedora/review/2366978-rust-bmart-derive/srpm/rust-bmart-derive.spec 2025-05-18 07:16:02.489044041 -0400 +++ /home/ben/fedora/review/2366978-rust-bmart-derive/srpm-unpacked/rust-bmart-derive.spec 2025-05-17 20:00:00.000000000 -0400 @@ -1,2 +1,12 @@ +## START: Set by rpmautospec +## (rpmautospec version 0.8.1) +## RPMAUTOSPEC: autorelease, autochangelog +%define autorelease(e:s:pb:n) %{?-p:0.}%{lua: + release_number = 1; + base_release_number = tonumber(rpm.expand("%{?-b*}%{!?-b:1}")); + print(release_number + base_release_number - 1); +}%{?-e:.%{-e*}}%{?-s:.%{-s*}}%{!?-n:%{?dist}} +## END: Set by rpmautospec + # Generated by rust2rpm 27 %bcond check 1 @@ -71,3 +81,6 @@ %changelog -%autochangelog +## START: Generated by rpmautospec +* Sun May 18 2025 John Doe <packager> - 0.1.4-1 +- Uncommitted changes +## END: Generated by rpmautospec Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2366978 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api Disabled plugins: SugarActivity, C/C++, R, fonts, Perl, Python, Java, PHP, Haskell, Ocaml Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH