Bug 2368294 - Review Request: rust-gstreamer-tag-sys - FFI bindings to libgsttag-1.0
Summary: Review Request: rust-gstreamer-tag-sys - FFI bindings to libgsttag-1.0
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/gstreamer-ta...
Whiteboard:
Depends On:
Blocks: 2368295
TreeView+ depends on / blocked
 
Reported: 2025-05-23 18:13 UTC by Yaakov Selkowitz
Modified: 2025-06-13 01:34 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2025-06-04 19:47:05 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)

Description Yaakov Selkowitz 2025-05-23 18:13:58 UTC
Spec URL: https://yselkowitz.fedorapeople.org/rust-gstreamer-tag-sys.spec
SRPM URL: https://yselkowitz.fedorapeople.org/rust-gstreamer-tag-sys-0.23.6-1.fc43.src.rpm
Description: FFI bindings to libgsttag-1.0 (This is a new dependency of rust-gst-plugin-{,f}mp4.)
Fedora Account System Username: yselkowitz

Comment 1 Fedora Review Service 2025-05-23 18:27:30 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/9076074
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2368294-rust-gstreamer-tag-sys/fedora-rawhide-x86_64/09076074-rust-gstreamer-tag-sys/fedora-review/review.txt

Found issues:

- No gcc, gcc-c++ or clang found in BuildRequires
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Fabio Valentini 2025-05-28 20:47:29 UTC
Package was generated with rust2rpm, simplifying the review.

✅ package contains only permissible content
✅ package builds and installs without errors on rawhide
🫤 test suite is run and all unit tests pass (tests are known brittle / broken)
✅ latest version of the crate is packaged
✅ license matches upstream specification and is acceptable for Fedora
✅ license file is included with %license in %files
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter (*NOT* pre-release filter): alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- set bugzilla assignee overrides to @rust-sig (optional)

===

It would be great if you could review any other pending Rust package in return, if you have time.

Comment 3 Fedora Admin user for bugzilla script actions 2025-06-04 18:17:56 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-gstreamer-tag-sys

Comment 4 Fedora Update System 2025-06-04 19:42:54 UTC
FEDORA-2025-45ca54e080 (rust-gst-plugin-fmp4-0.13.6-1.fc43, rust-gst-plugin-mp4-0.13.6-1.fc43, and 2 more) has been submitted as an update to Fedora 43.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-45ca54e080

Comment 5 Fedora Update System 2025-06-04 19:47:05 UTC
FEDORA-2025-45ca54e080 (rust-gst-plugin-fmp4-0.13.6-1.fc43, rust-gst-plugin-mp4-0.13.6-1.fc43, and 2 more) has been pushed to the Fedora 43 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 6 Fedora Update System 2025-06-04 19:49:27 UTC
FEDORA-2025-2e7c60d95f (rust-gst-plugin-fmp4-0.13.6-1.fc42, rust-gst-plugin-mp4-0.13.6-1.fc42, and 2 more) has been submitted as an update to Fedora 42.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-2e7c60d95f

Comment 7 Fedora Update System 2025-06-04 19:51:33 UTC
FEDORA-2025-f239e387fd (rust-gst-plugin-fmp4-0.13.6-1.fc41, rust-gst-plugin-mp4-0.13.6-1.fc41, and 2 more) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-f239e387fd

Comment 8 Fedora Update System 2025-06-05 01:41:55 UTC
FEDORA-2025-f239e387fd has been pushed to the Fedora 41 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-f239e387fd`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-f239e387fd

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 9 Fedora Update System 2025-06-05 02:36:09 UTC
FEDORA-2025-2e7c60d95f has been pushed to the Fedora 42 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-2e7c60d95f`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-2e7c60d95f

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 10 Fedora Update System 2025-06-13 01:03:01 UTC
FEDORA-2025-2e7c60d95f (rust-gst-plugin-fmp4-0.13.6-1.fc42, rust-gst-plugin-mp4-0.13.6-1.fc42, and 2 more) has been pushed to the Fedora 42 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 11 Fedora Update System 2025-06-13 01:34:10 UTC
FEDORA-2025-f239e387fd (rust-gst-plugin-fmp4-0.13.6-1.fc41, rust-gst-plugin-mp4-0.13.6-1.fc41, and 2 more) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.