Spec URL: https://yselkowitz.fedorapeople.org/R-R2HTML.spec SRPM URL: https://yselkowitz.fedorapeople.org/R-R2HTML-2.3.4-1.fc43.src.rpm Description: Includes HTML function and methods to write in an HTML file. Thus, making HTML reports is easy. Includes a function that allows redirection on the fly, which appears to be very useful for teaching purpose, as the student can keep a copy of the produced output to keep all that he did during the course. Package comes with a vignette describing how to write HTML reports for statistical analysis. Finally, a driver for 'Sweave' allows to parse HTML flat files containing R code and to automatically write the corresponding outputs (tables and graphs). [This is being added as an optional dependency of rkward.] Fedora Account System Username: yselkowitz
Copr build: https://copr.fedorainfracloud.org/coprs/build/9076177 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2368308-r-r2html/fedora-rawhide-x86_64/09076177-R-R2HTML/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Issues: ======= - Package have the default element marked as %%doc :doc, DESCRIPTION, NEWS, CITATION - Package requires R-core. ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "*No copyright* GNU General Public License, Version 2", "Unknown or generated", "GNU General Public License v2.0 or later [obsolete FSF postal address (Temple Place)]", "GNU General Public License v2.0 or later", "GNU General Public License v2.0 or later [obsolete FSF postal address (Mass Ave)]". 90 files have unknown license. Detailed output of licensecheck in /home/fedora-packaging/reviews/R-R2HTML/2368308-R- R2HTML/licensecheck.txt [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local R: [x]: Package contains the mandatory BuildRequires. [x]: The package has the standard %install section. ===== SHOULD items ===== Generic: [!]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. R: [x]: The %check macro is present [x]: Latest version is packaged. Note: Latest upstream version is 2.3.4, packaged version is 2.3.4 ===== EXTRA items ===== Generic: [!]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). See: (this test has no URL) [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). Rpmlint ------- Checking: R-R2HTML-2.3.4-1.fc43.noarch.rpm R-R2HTML-2.3.4-1.fc43.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.6.1 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpetdakmv3')] checks: 32, packages: 2 R-R2HTML.noarch: W: spurious-executable-perm /usr/share/R/library/R2HTML/output/R2HTMLstuff.zip R-R2HTML.noarch: E: incorrect-fsf-address /usr/share/R/library/R2HTML/output/runtime/lib/grid.js R-R2HTML.noarch: E: incorrect-fsf-address /usr/share/R/library/R2HTML/output/runtime/styles/classic/grid.css R-R2HTML.noarch: E: incorrect-fsf-address /usr/share/R/library/R2HTML/output/runtime/styles/flat/grid.css R-R2HTML.noarch: E: incorrect-fsf-address /usr/share/R/library/R2HTML/output/runtime/styles/xp/grid.css R-R2HTML.noarch: W: files-duplicate /usr/share/R/library/R2HTML/help/HTML.xtabs.html /usr/share/R/library/R2HTML/help/HTML.Anova.html:/usr/share/R/library/R2HTML/help/HTML.Arima.html:/usr/share/R/library/R2HTML/help/HTML.HoltWinters.html:/usr/share/R/library/R2HTML/help/HTML.MethodsFunction.html:/usr/share/R/library/R2HTML/help/HTML.POSIXct.html:(and 147 more) R-R2HTML.noarch: W: files-duplicate /usr/share/R/library/R2HTML/help/HTML.matrix.html /usr/share/R/library/R2HTML/help/HTML.data.frame.html R-R2HTML.noarch: W: files-duplicate /usr/share/R/library/R2HTML/help/as.latex.html /usr/share/R/library/R2HTML/help/HTML.latex.html R-R2HTML.noarch: W: files-duplicate /usr/share/R/library/R2HTML/help/as.title.html /usr/share/R/library/R2HTML/help/HTML.title.html R-R2HTML.noarch: W: files-duplicate /usr/share/R/library/R2HTML/help/R2HTML-internal.html /usr/share/R/library/R2HTML/help/HTMLCommand.html:/usr/share/R/library/R2HTML/help/HTMLReplaceNA.html:/usr/share/R/library/R2HTML/help/HTMLcode.html R-R2HTML.noarch: W: files-duplicate /usr/share/R/library/R2HTML/help/HTMLSetFile.html /usr/share/R/library/R2HTML/help/HTMLEndFile.html:/usr/share/R/library/R2HTML/help/HTMLGetFile.html:/usr/share/R/library/R2HTML/help/HTMLInitFile.html R-R2HTML.noarch: W: files-duplicate /usr/share/R/library/R2HTML/help/HTMLStop.html /usr/share/R/library/R2HTML/help/HTMLStart.html R-R2HTML.noarch: W: files-duplicate /usr/share/R/library/R2HTML/help/HTMLli.html /usr/share/R/library/R2HTML/help/HTMLbr.html:/usr/share/R/library/R2HTML/help/HTMLhr.html R-R2HTML.noarch: W: files-duplicate /usr/share/R/library/R2HTML/help/HTMLgrid_summary.html /usr/share/R/library/R2HTML/help/HTMLgrid.html:/usr/share/R/library/R2HTML/help/HTMLgrid_inline.html:/usr/share/R/library/R2HTML/help/HTMLgrid_references.html R-R2HTML.noarch: W: files-duplicate /usr/share/R/library/R2HTML/help/SweaveSyntaxHTML.html /usr/share/R/library/R2HTML/help/RweaveHTML.html:/usr/share/R/library/R2HTML/help/RweaveHTMLFinish.html:/usr/share/R/library/R2HTML/help/RweaveHTMLOptions.html:/usr/share/R/library/R2HTML/help/RweaveHTMLRuncode.html:/usr/share/R/library/R2HTML/help/RweaveHTMLSetup.html:(and 1 more) R-R2HTML.noarch: W: files-duplicate /usr/share/R/library/R2HTML/output/runtime/styles/xp/gecko.xml /usr/share/R/library/R2HTML/output/runtime/styles/classic/gecko.xml:/usr/share/R/library/R2HTML/output/runtime/styles/flat/gecko.xml R-R2HTML.noarch: W: files-duplicate /usr/share/R/library/R2HTML/output/runtime/styles/xp/icons.png /usr/share/R/library/R2HTML/output/runtime/styles/classic/icons.png:/usr/share/R/library/R2HTML/output/runtime/styles/flat/icons.png R-R2HTML.noarch: W: files-duplicate /usr/share/R/library/R2HTML/output/runtime/styles/xp/loading.gif /usr/share/R/library/R2HTML/output/runtime/styles/classic/loading.gif:/usr/share/R/library/R2HTML/output/runtime/styles/flat/loading.gif R-R2HTML.noarch: W: files-duplicate /usr/share/R/library/R2HTML/samples/essai-005.png /usr/share/R/library/R2HTML/samples/essai-002.png:/usr/share/R/library/R2HTML/samples/essai-004.png R-R2HTML.noarch: W: file-not-utf8 /usr/share/R/library/R2HTML/NEWS R-R2HTML.noarch: W: file-not-utf8 /usr/share/R/library/R2HTML/samples/example3.snw 2 packages and 0 specfiles checked; 4 errors, 17 warnings, 7 filtered, 4 badness; has taken 0.4 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 R-R2HTML.noarch: W: spurious-executable-perm /usr/share/R/library/R2HTML/output/R2HTMLstuff.zip R-R2HTML.noarch: E: incorrect-fsf-address /usr/share/R/library/R2HTML/output/runtime/lib/grid.js R-R2HTML.noarch: E: incorrect-fsf-address /usr/share/R/library/R2HTML/output/runtime/styles/classic/grid.css R-R2HTML.noarch: E: incorrect-fsf-address /usr/share/R/library/R2HTML/output/runtime/styles/flat/grid.css R-R2HTML.noarch: E: incorrect-fsf-address /usr/share/R/library/R2HTML/output/runtime/styles/xp/grid.css R-R2HTML.noarch: W: files-duplicate /usr/share/R/library/R2HTML/help/HTML.xtabs.html /usr/share/R/library/R2HTML/help/HTML.Anova.html:/usr/share/R/library/R2HTML/help/HTML.Arima.html:/usr/share/R/library/R2HTML/help/HTML.HoltWinters.html:/usr/share/R/library/R2HTML/help/HTML.MethodsFunction.html:/usr/share/R/library/R2HTML/help/HTML.POSIXct.html:(and 147 more) R-R2HTML.noarch: W: files-duplicate /usr/share/R/library/R2HTML/help/HTML.matrix.html /usr/share/R/library/R2HTML/help/HTML.data.frame.html R-R2HTML.noarch: W: files-duplicate /usr/share/R/library/R2HTML/help/as.latex.html /usr/share/R/library/R2HTML/help/HTML.latex.html R-R2HTML.noarch: W: files-duplicate /usr/share/R/library/R2HTML/help/as.title.html /usr/share/R/library/R2HTML/help/HTML.title.html R-R2HTML.noarch: W: files-duplicate /usr/share/R/library/R2HTML/help/R2HTML-internal.html /usr/share/R/library/R2HTML/help/HTMLCommand.html:/usr/share/R/library/R2HTML/help/HTMLReplaceNA.html:/usr/share/R/library/R2HTML/help/HTMLcode.html R-R2HTML.noarch: W: files-duplicate /usr/share/R/library/R2HTML/help/HTMLSetFile.html /usr/share/R/library/R2HTML/help/HTMLEndFile.html:/usr/share/R/library/R2HTML/help/HTMLGetFile.html:/usr/share/R/library/R2HTML/help/HTMLInitFile.html R-R2HTML.noarch: W: files-duplicate /usr/share/R/library/R2HTML/help/HTMLStop.html /usr/share/R/library/R2HTML/help/HTMLStart.html R-R2HTML.noarch: W: files-duplicate /usr/share/R/library/R2HTML/help/HTMLli.html /usr/share/R/library/R2HTML/help/HTMLbr.html:/usr/share/R/library/R2HTML/help/HTMLhr.html R-R2HTML.noarch: W: files-duplicate /usr/share/R/library/R2HTML/help/HTMLgrid_summary.html /usr/share/R/library/R2HTML/help/HTMLgrid.html:/usr/share/R/library/R2HTML/help/HTMLgrid_inline.html:/usr/share/R/library/R2HTML/help/HTMLgrid_references.html R-R2HTML.noarch: W: files-duplicate /usr/share/R/library/R2HTML/help/SweaveSyntaxHTML.html /usr/share/R/library/R2HTML/help/RweaveHTML.html:/usr/share/R/library/R2HTML/help/RweaveHTMLFinish.html:/usr/share/R/library/R2HTML/help/RweaveHTMLOptions.html:/usr/share/R/library/R2HTML/help/RweaveHTMLRuncode.html:/usr/share/R/library/R2HTML/help/RweaveHTMLSetup.html:(and 1 more) R-R2HTML.noarch: W: files-duplicate /usr/share/R/library/R2HTML/output/runtime/styles/xp/gecko.xml /usr/share/R/library/R2HTML/output/runtime/styles/classic/gecko.xml:/usr/share/R/library/R2HTML/output/runtime/styles/flat/gecko.xml R-R2HTML.noarch: W: files-duplicate /usr/share/R/library/R2HTML/output/runtime/styles/xp/icons.png /usr/share/R/library/R2HTML/output/runtime/styles/classic/icons.png:/usr/share/R/library/R2HTML/output/runtime/styles/flat/icons.png R-R2HTML.noarch: W: files-duplicate /usr/share/R/library/R2HTML/output/runtime/styles/xp/loading.gif /usr/share/R/library/R2HTML/output/runtime/styles/classic/loading.gif:/usr/share/R/library/R2HTML/output/runtime/styles/flat/loading.gif R-R2HTML.noarch: W: files-duplicate /usr/share/R/library/R2HTML/samples/essai-005.png /usr/share/R/library/R2HTML/samples/essai-002.png:/usr/share/R/library/R2HTML/samples/essai-004.png R-R2HTML.noarch: W: file-not-utf8 /usr/share/R/library/R2HTML/NEWS R-R2HTML.noarch: W: file-not-utf8 /usr/share/R/library/R2HTML/samples/example3.snw 1 packages and 0 specfiles checked; 4 errors, 17 warnings, 3 filtered, 4 badness; has taken 0.1 s Source checksums ---------------- https://CRAN.R-project.org/package=R2HTML&version=2.3.4#/R2HTML_2.3.4.tar.gz : CHECKSUM(SHA256) this package : b9ed93a48840e7866ccfec7948c62b0c3708915865d79f851eb0bde27af21ea9 CHECKSUM(SHA256) upstream package : b9ed93a48840e7866ccfec7948c62b0c3708915865d79f851eb0bde27af21ea9 Requires -------- R-R2HTML (rpmlib, GLIBC filtered): R(ABI) R(grDevices) R(graphics) R(methods) R(stats) R(utils) R-core Provides -------- R-R2HTML: R(R2HTML) R-R2HTML Diff spec file in url and in SRPM --------------------------------- --- /home/fedora-packaging/reviews/R-R2HTML/2368308-R-R2HTML/srpm/R-R2HTML.spec 2025-05-24 09:03:06.130985554 +0300 +++ /homefedora-packaging/reviews/R-R2HTML/2368308-R-R2HTML/srpm-unpacked/R-R2HTML.spec 2025-05-09 03:00:00.000000000 +0300 @@ -1,2 +1,12 @@ +## START: Set by rpmautospec +## (rpmautospec version 0.8.1) +## RPMAUTOSPEC: autorelease, autochangelog +%define autorelease(e:s:pb:n) %{?-p:0.}%{lua: + release_number = 1; + base_release_number = tonumber(rpm.expand("%{?-b*}%{!?-b:1}")); + print(release_number + base_release_number - 1); +}%{?-e:.%{-e*}}%{?-s:.%{-s*}}%{!?-n:%{?dist}} +## END: Set by rpmautospec + %global packname R2HTML %global rlibdir %{_datadir}/R/library @@ -63,3 +73,6 @@ %changelog -%autochangelog +## START: Generated by rpmautospec +* Fri May 09 2025 John Doe <packager> - 2.3.4-1 +- Uncommitted changes +## END: Generated by rpmautospec Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2368308 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, R Disabled plugins: Python, Ocaml, PHP, SugarActivity, Java, Haskell, Perl, fonts, C/C++ Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH Comments: a) Can these be fixed: - Package have the default element marked as %%doc :doc, DESCRIPTION, NEWS, CITATION - Package requires R-core. b) Is it possible to ask upstream to add a license file? c) Many files in the tar ball have executable permissions. Can these permissione be removed?
a) Can these be fixed: - Package have the default element marked as %%doc :doc, DESCRIPTION, NEWS, CITATION NEWS and the doc subdirectory are marked %doc, in line with the sample in the guidelines. CITATION and DESCRIPTION are not. - Package requires R-core. Please explain. The guidelines do not seem to mention this, and many R packages have the same. b) Is it possible to ask upstream to add a license file? https://github.com/nalimilan/R2HTML/issues/9 c) Many files in the tar ball have executable permissions. Can these permissione be removed? Fixed.
Spec URL: https://yselkowitz.fedorapeople.org/R-R2HTML.spec SRPM URL: https://yselkowitz.fedorapeople.org/R-R2HTML-2.3.4-1.fc44.src.rpm
Created attachment 2105540 [details] The .spec file difference from Copr build 9076177 to 9513917
Copr build: https://copr.fedorainfracloud.org/coprs/build/9513917 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2368308-r-r2html/fedora-rawhide-x86_64/09513917-R-R2HTML/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Hi, one of the R maintainers here. As I said in the GH issue above, by CRAN policy, R packages do not contain a license. The R package contains all the licenses allowed once, and then packages just declare which one they use. So this is fine. The R packaging guidelines are not in very good shape, TBH, and they don't reflect yet some practices that I'm changing to e.g. make mass rebuilds for new versions of R much easier. But this package is simple enough, no problem. here.
Benson, based on the above, can you reconsider your review?
In fact, this is in the guidelines now: https://docs.fedoraproject.org/en-US/packaging-guidelines/R/#_license
Thanks. Will get to this in the next few days.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package have the default element marked as %%doc :doc, DESCRIPTION, NEWS, CITATION - Package requires R-core. ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "*No copyright* GNU General Public License, Version 2", "Unknown or generated", "GNU General Public License v2.0 or later [obsolete FSF postal address (Temple Place)]", "GNU General Public License v2.0 or later", "GNU General Public License v2.0 or later [obsolete FSF postal address (Mass Ave)]". 90 files have unknown license. Detailed output of licensecheck in /home/fedora-packaging/reviews/R-R2HTML/2368308-R- R2HTML/licensecheck.txt [ ]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local R: [x]: Package contains the mandatory BuildRequires. [x]: The package has the standard %install section. ===== SHOULD items ===== Generic: [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. R: [x]: The %check macro is present [x]: Latest version is packaged. Note: Latest upstream version is 2.3.4, packaged version is 2.3.4 ===== EXTRA items ===== Generic: [!]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). See: (this test has no URL) [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). Rpmlint ------- Checking: R-R2HTML-2.3.4-1.fc44.noarch.rpm R-R2HTML-2.3.4-1.fc44.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmplw1rbu52')] checks: 32, packages: 2 R-R2HTML.noarch: E: incorrect-fsf-address /usr/share/R/library/R2HTML/output/runtime/lib/grid.js R-R2HTML.noarch: E: incorrect-fsf-address /usr/share/R/library/R2HTML/output/runtime/styles/classic/grid.css R-R2HTML.noarch: E: incorrect-fsf-address /usr/share/R/library/R2HTML/output/runtime/styles/flat/grid.css R-R2HTML.noarch: E: incorrect-fsf-address /usr/share/R/library/R2HTML/output/runtime/styles/xp/grid.css R-R2HTML.noarch: W: file-not-utf8 /usr/share/R/library/R2HTML/samples/example3.snw R-R2HTML.noarch: W: cross-directory-hard-link /usr/share/R/library/R2HTML/output/runtime/styles/flat/gecko.xml /usr/share/R/library/R2HTML/output/runtime/styles/classic/gecko.xml R-R2HTML.noarch: W: cross-directory-hard-link /usr/share/R/library/R2HTML/output/runtime/styles/flat/icons.png /usr/share/R/library/R2HTML/output/runtime/styles/classic/icons.png R-R2HTML.noarch: W: cross-directory-hard-link /usr/share/R/library/R2HTML/output/runtime/styles/flat/loading.gif /usr/share/R/library/R2HTML/output/runtime/styles/classic/loading.gif R-R2HTML.noarch: W: cross-directory-hard-link /usr/share/R/library/R2HTML/output/runtime/styles/xp/gecko.xml /usr/share/R/library/R2HTML/output/runtime/styles/classic/gecko.xml R-R2HTML.noarch: W: cross-directory-hard-link /usr/share/R/library/R2HTML/output/runtime/styles/xp/gecko.xml /usr/share/R/library/R2HTML/output/runtime/styles/flat/gecko.xml R-R2HTML.noarch: W: cross-directory-hard-link /usr/share/R/library/R2HTML/output/runtime/styles/xp/icons.png /usr/share/R/library/R2HTML/output/runtime/styles/classic/icons.png R-R2HTML.noarch: W: cross-directory-hard-link /usr/share/R/library/R2HTML/output/runtime/styles/xp/icons.png /usr/share/R/library/R2HTML/output/runtime/styles/flat/icons.png R-R2HTML.noarch: W: cross-directory-hard-link /usr/share/R/library/R2HTML/output/runtime/styles/xp/loading.gif /usr/share/R/library/R2HTML/output/runtime/styles/classic/loading.gif R-R2HTML.noarch: W: cross-directory-hard-link /usr/share/R/library/R2HTML/output/runtime/styles/xp/loading.gif /usr/share/R/library/R2HTML/output/runtime/styles/flat/loading.gif 2 packages and 0 specfiles checked; 4 errors, 10 warnings, 7 filtered, 4 badness; has taken 0.9 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 R-R2HTML.noarch: E: incorrect-fsf-address /usr/share/R/library/R2HTML/output/runtime/lib/grid.js R-R2HTML.noarch: E: incorrect-fsf-address /usr/share/R/library/R2HTML/output/runtime/styles/classic/grid.css R-R2HTML.noarch: E: incorrect-fsf-address /usr/share/R/library/R2HTML/output/runtime/styles/flat/grid.css R-R2HTML.noarch: E: incorrect-fsf-address /usr/share/R/library/R2HTML/output/runtime/styles/xp/grid.css R-R2HTML.noarch: W: file-not-utf8 /usr/share/R/library/R2HTML/samples/example3.snw R-R2HTML.noarch: W: cross-directory-hard-link /usr/share/R/library/R2HTML/output/runtime/styles/flat/gecko.xml /usr/share/R/library/R2HTML/output/runtime/styles/classic/gecko.xml R-R2HTML.noarch: W: cross-directory-hard-link /usr/share/R/library/R2HTML/output/runtime/styles/flat/icons.png /usr/share/R/library/R2HTML/output/runtime/styles/classic/icons.png R-R2HTML.noarch: W: cross-directory-hard-link /usr/share/R/library/R2HTML/output/runtime/styles/flat/loading.gif /usr/share/R/library/R2HTML/output/runtime/styles/classic/loading.gif R-R2HTML.noarch: W: cross-directory-hard-link /usr/share/R/library/R2HTML/output/runtime/styles/xp/gecko.xml /usr/share/R/library/R2HTML/output/runtime/styles/classic/gecko.xml R-R2HTML.noarch: W: cross-directory-hard-link /usr/share/R/library/R2HTML/output/runtime/styles/xp/gecko.xml /usr/share/R/library/R2HTML/output/runtime/styles/flat/gecko.xml R-R2HTML.noarch: W: cross-directory-hard-link /usr/share/R/library/R2HTML/output/runtime/styles/xp/icons.png /usr/share/R/library/R2HTML/output/runtime/styles/classic/icons.png R-R2HTML.noarch: W: cross-directory-hard-link /usr/share/R/library/R2HTML/output/runtime/styles/xp/icons.png /usr/share/R/library/R2HTML/output/runtime/styles/flat/icons.png R-R2HTML.noarch: W: cross-directory-hard-link /usr/share/R/library/R2HTML/output/runtime/styles/xp/loading.gif /usr/share/R/library/R2HTML/output/runtime/styles/classic/loading.gif R-R2HTML.noarch: W: cross-directory-hard-link /usr/share/R/library/R2HTML/output/runtime/styles/xp/loading.gif /usr/share/R/library/R2HTML/output/runtime/styles/flat/loading.gif 1 packages and 0 specfiles checked; 4 errors, 10 warnings, 3 filtered, 4 badness; has taken 0.2 s Source checksums ---------------- https://CRAN.R-project.org/package=R2HTML&version=2.3.4#/R2HTML_2.3.4.tar.gz : CHECKSUM(SHA256) this package : b9ed93a48840e7866ccfec7948c62b0c3708915865d79f851eb0bde27af21ea9 CHECKSUM(SHA256) upstream package : b9ed93a48840e7866ccfec7948c62b0c3708915865d79f851eb0bde27af21ea9 Requires -------- R-R2HTML (rpmlib, GLIBC filtered): R(ABI) R(grDevices) R(graphics) R(methods) R(stats) R(utils) R-core Provides -------- R-R2HTML: R(R2HTML) R-R2HTML Diff spec file in url and in SRPM --------------------------------- --- /home/fedora-packaging/reviews/R-R2HTML/2368308-R-R2HTML/srpm/R-R2HTML.spec 2025-12-28 08:54:23.388383557 +0300 +++ /home/fedora-packaging/reviews/R-R2HTML/2368308-R-R2HTML/srpm-unpacked/R-R2HTML.spec 2025-09-02 03:00:00.000000000 +0300 @@ -1,2 +1,12 @@ +## START: Set by rpmautospec +## (rpmautospec version 0.8.1) +## RPMAUTOSPEC: autorelease, autochangelog +%define autorelease(e:s:pb:n) %{?-p:0.}%{lua: + release_number = 1; + base_release_number = tonumber(rpm.expand("%{?-b*}%{!?-b:1}")); + print(release_number + base_release_number - 1); +}%{?-e:.%{-e*}}%{?-s:.%{-s*}}%{!?-n:%{?dist}} +## END: Set by rpmautospec + %global packname R2HTML %global rlibdir %{_datadir}/R/library @@ -68,3 +78,6 @@ %changelog -%autochangelog +## START: Generated by rpmautospec +* Tue Sep 02 2025 John Doe <packager> - 2.3.4-1 +- Uncommitted changes +## END: Generated by rpmautospec Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2368308 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic, R Disabled plugins: PHP, Python, Java, SugarActivity, C/C++, Haskell, Ocaml, Perl, fonts Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH Comments: a) A build using the new packaging macros: https://koji.fedoraproject.org/koji/taskinfo?taskID=141246167 Macros documented at: https://docs.fedoraproject.org/en-US/packaging-guidelines/R/#_example_spec_file b) Please indicate Provides: bundled(asciimathml) This is available at https://www1.chapman.edu/~jipsen/asciimath.html https://github.com/nalimilan/R2HTML/blob/master/inst/output/ASCIIMathML.js c) Please also indicate Provides: bundled(activewidgets) There are files taken from https://sourceforge.net/projects/activeui/ d) Pull request to update FSF addresses: https://github.com/nalimilan/R2HTML/pull/10 e) Approved. Please fix (b) and (c) before import. Consider using (a).
The new macros **must** be used. The R2spec tool version 6 gives you a good starting point.
Please update to use the new macros.
Neither R2spec version 6 nor the new macros are available for stable branches. Therefore, they cannot be a blocking requirement yet.
The new macros are available for stable branches. R2spec 6.0.0 is in testing for F43. But you don't need R2spec.
Not completely, see https://koji.fedoraproject.org/koji/taskinfo?taskID=141289849: ``` error: line 12: Tag takes single token only: Version: %R_rpm_version 2.3.4 ``` https://src.fedoraproject.org/rpms/redhat-rpm-config/c/eb69ca5b90cfe7797a165ed794ceed510d880c4d needs to be backported/cherry-picked to f43, built, and pushed to stable before packages using these macros can be built for f43, and same for f42 if so desired. Until then, the new macros are only usable on rawhide, and therefore should not be a blocking requirement.
Review requests are for the inclusion of packages in rawhide. Adding them to more releases is optional. The new spec format is mandatory in rawhide, so please use the new macros in rawhide. Or I'll put it in another way: I spent a whole week implementing [1], i.e. transforming 400 packages into the new format. I don't care if you are willing to maintain this package in the old format for F43, but please do not land the old format in rawhide, because that would mean more work for me. [1] https://fedoraproject.org/wiki/Changes/Adopt_new_R_Packaging_Guidelines
Even the tools to create packages in the new format aren't in stable branches yet, so once again, it is premature to make this a blocking requirement. It cannot be a requirement to *run* rawhide in order to create a package for rawhide. Once I import the package in a way that can be fast-forwarded to stable branches, then I can immediately convert rawhide to the new format. I have both spec files locally.
Again: as long as you convert it in rawhide, fine with me.