Bug 2368362 - Review Request: rust-ssh-agent-client-rs - Pure rust implementation of the ssh-agent protocol
Summary: Review Request: rust-ssh-agent-client-rs - Pure rust implementation of the ss...
Keywords:
Status: NEW
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/ssh-agent-cl...
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2025-05-24 12:34 UTC by Noa Resare
Modified: 2025-05-25 12:01 UTC (History)
1 user (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed:
Type: ---
Embargoed:


Attachments (Terms of Use)
The .spec file difference from Copr build 9077037 to 9078264 (447 bytes, patch)
2025-05-25 12:01 UTC, Fedora Review Service
no flags Details | Diff

Description Noa Resare 2025-05-24 12:34:23 UTC
Spec URL: https://download.copr.fedorainfracloud.org/results/noa/rust/fedora-42-aarch64/09077024-rust-ssh-agent-client-rs/rust-ssh-agent-client-rs.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/noa/rust/fedora-42-aarch64/09077024-rust-ssh-agent-client-rs/rust-ssh-agent-client-rs-1.0.0-1.fc42.src.rpm
Description: Pure rust implementation of the ssh-agent protocol
Fedora Account System Username: noa

I believe I need a sponsor, even though I dabbled with Fedora packaging a long time ago.

I am the upstream author of this code, and my purpose in packaging it is to be able to package my pam-ssh-agent crate for Fedora.

The COPR build referenced above builds its srpm using the srpm target in this makefile: https://github.com/nresare/rpm-packaging/blob/main/ssh-agent-client-rs/Makefile

Comment 1 Fedora Review Service 2025-05-24 12:42:06 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/9077037
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2368362-rust-ssh-agent-client-rs/fedora-rawhide-x86_64/09077037-rust-ssh-agent-client-rs/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Noa Resare 2025-05-25 11:54:15 UTC
It turns out that the copr 'make srpm' feature that only invokes "dnf install rust2rpm" and not "dnf install rust2rpm rust2rpm-helper" will silently skip generating patches that removes non-matching conditional dependencies, such as the windows only interprocess.

Here is an updated .src.rpm and .spec where this is fixed:

https://download.copr.fedorainfracloud.org/results/noa/rust/epel-10-aarch64/09077642-rust-ssh-agent-client-rs/rust-ssh-agent-client-rs-1.0.0-1.el10.src.rpm
https://download.copr.fedorainfracloud.org/results/noa/rust/epel-10-aarch64/09077642-rust-ssh-agent-client-rs/rust-ssh-agent-client-rs.spec

Comment 3 Fedora Review Service 2025-05-25 12:01:46 UTC
Created attachment 2091502 [details]
The .spec file difference from Copr build 9077037 to 9078264

Comment 4 Fedora Review Service 2025-05-25 12:01:49 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/9078264
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2368362-rust-ssh-agent-client-rs/fedora-rawhide-x86_64/09078264-rust-ssh-agent-client-rs/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.


Note You need to log in before you can comment on or make changes to this bug.