Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: https://solopasha.fedorapeople.org/reviews/gocryptfs/gocryptfs.spec SRPM URL: https://solopasha.fedorapeople.org/reviews/gocryptfs/gocryptfs-2.5.4-1.fc43.src.rpm Description: Encrypted overlay filesystem written in Go. Fedora Account System Username: solopasha
Copr build: https://copr.fedorainfracloud.org/coprs/build/9087636 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2368700-gocryptfs/fedora-rawhide-x86_64/09087636-gocryptfs/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Spec URL: https://solopasha.fedorapeople.org/reviews/gocryptfs/gocryptfs.spec SRPM URL: https://solopasha.fedorapeople.org/reviews/gocryptfs/gocryptfs-2.5.4-1.fc43.src.rpm
Created attachment 2091695 [details] The .spec file difference from Copr build 9087636 to 9092130
Copr build: https://copr.fedorainfracloud.org/coprs/build/9092130 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2368700-gocryptfs/fedora-rawhide-x86_64/09092130-gocryptfs/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Golang Package Review ============== This package was generated using go2rpm, which simplifies the review. Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated - [x] The latest version is packaged or packaging an earlier version is justified. - [x] The License tag reflects the package contents and uses the correct identifiers. - [x] The package builds successfully in mock. - [x] Package is installable (checked by fedora-review). - [x] There are no relevant rpmlint errors. - [x] The package runs tests in %check. - [x] `%goipath` is set correctly. - [x] The package's binaries don't conflict with binaries already in the distribution. (Some Go projects include utility binaries with very generic names) - [x] There are no `%{_bindir}/*` wildcards in %files. (go2rpm includes these by default) - [x] The package does not use `%gometa -f` if it has dependents that still build for %ix86. - [x] The package complies with the Golang and general Packaging Guidelines. Package approved! On import, don't forget to do the following: - [ ] Add the package to release-monitoring.org - [ ] Give go-sig privileges (at least commit) on the package - [ ] Close the review bug by referencing its ID in the rpm changelog and the Bodhi ticket. Thanks!
Thank you for the review, Mikel
The Pagure repository was created at https://src.fedoraproject.org/rpms/gocryptfs
FEDORA-2025-d57986e38c (gocryptfs-2.5.4-1.fc43) has been submitted as an update to Fedora 43. https://bodhi.fedoraproject.org/updates/FEDORA-2025-d57986e38c
FEDORA-2025-d57986e38c (gocryptfs-2.5.4-1.fc43) has been pushed to the Fedora 43 stable repository. If problem still persists, please make note of it in this bug report.
There was already a review ticket for this: https://bugzilla.redhat.com/show_bug.cgi?id=2241620 . Please be careful to check for existing reviews in future before proceeding with a new one.