Spec URL: https://forge.moderndesktop.dev/JoshStrobl/fedora-package-reviews/raw/branch/main/pocillo-gtk-theme/pocillo-gtk-theme.spec SRPM URL: https://forge.moderndesktop.dev/JoshStrobl/fedora-package-reviews/raw/branch/main/pocillo-gtk-theme/pocillo-gtk-theme-0.11-1.fc42.src.rpm Description: Pocillo is a Material Design theme for the Budgie Desktop Fedora Account System Username: joshstrobl
Taking this review.
Copr build: https://copr.fedorainfracloud.org/coprs/build/9101549 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2369202-pocillo-gtk-theme/fedora-rawhide-x86_64/09101549-pocillo-gtk-theme/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Spec review notes: * Can you encode the version in the tarball name? rpmdev-spectool respects "#/%{name}-%{version}-precompiled.tar.gz" suffix to SourceURL to auto-rename tarballs * gtk3 and gtk4 themes should be split into their own subpackages (cf breeze-gtk) so that they only need to be present if gtk3 or gtk4 applications are installed * openbox theme should be subpackaged as well
Done. The "raw" links should get you latest for spec and src rpm :) - Encoded version in tarball name - GTK4 split into own package. Given Pocillo is designed and intended for Budgie Desktop, which at this time is GTK3, it made the most sense to keep that as the "main" package. - openbox split into own package as well
I would prefer that even the gtk3 theme get split out. If you'd like it to get installed alongside gtk3/gtk4, the way I suggest doing it is like so in the main package: Requires: (pocillo-gtk3-theme if gtk3) Requires: (pocillo-gtk4-theme if gtk4) Thus, the main package is a metapackage that pulls the correct stuff based on what you have on your system.
Done. I split out pocillo-gtk3-theme, added requires for all the various subpackages if the user relevant respective installed (though with openbox, pocillo-openbox-theme doesn't require openbox as it just supports the Openbox standard for decorations, can be used with labwc and similar).
I don't see the updated spec and SRPM?
Check again
Review notes: * Package follows Fedora Packaging Guidelines * Package licensing is correct and license data is correctly installed * Package builds and installs * No serious issues from rpmlint PACKAGE APPROVED.
One last note: > tar -xf %{SOURCE0} -C %{_builddir} > mv Pocillo/COPYING %{_builddir}/ > rm -rf Pocillo-*/COPYING > rm -rf **/INSTALL_GDM_THEME.md This should be replaced with the following: """" %autosetup -c cp Pocillo/COPYING . rm -rf Pocillo-*/COPYING rm -rf **/INSTALL_GDM_THEME.md """" Please consider updating to this when you import the package.
The Pagure repository was created at https://src.fedoraproject.org/rpms/pocillo-gtk-theme