SRPM URL: http://home.comcast.net/~ckweyl/perl-Config-IniHash-2.8-1.fc6.src.rpm SPEC URL: http://home.comcast.net/~ckweyl/perl-Config-IniHash.spec Description: This module reads and writes INI files.
package won't mockbuild: + make test PERL_DL_NONLAZY=1 /usr/bin/perl "-Iblib/lib" "-Iblib/arch" test.pl 1..4 not ok 1 - use Config::IniHash; # Failed test 'use Config::IniHash;' # in test.pl at line 9. # Tried to use 'Config::IniHash'. # Error: Can't locate IO/Scalar.pm in @INC (@INC contains: blib/lib blib/arch /usr/lib/perl5/site_perl/5.8.8/i386-linux-thread-multi /usr/lib/perl5/site_perl/5.8.7/i386-linux-thread-multi /usr/lib/perl5/site_perl/5.8.6/i386-linux-thread-multi /usr/lib/perl5/site_perl/5.8.5/i386-linux-thread-multi /usr/lib/perl5/site_perl/5.8.8 /usr/lib/perl5/site_perl/5.8.7 /usr/lib/perl5/site_perl/5.8.6 /usr/lib/perl5/site_perl/5.8.5 /usr/lib/perl5/site_perl /usr/lib/perl5/vendor_perl/5.8.8/i386-linux-thread-multi /usr/lib/perl5/vendor_perl/5.8.7/i386-linux-thread-multi /usr/lib/perl5/vendor_perl/5.8.6/i386-linux-thread-multi /usr/lib/perl5/vendor_perl/5.8.5/i386-linux-thread-multi /usr/lib/perl5/vendor_perl/5.8.8 /usr/lib/perl5/vendor_perl/5.8.7 /usr/lib/perl5/vendor_perl/5.8.6 /usr/lib/perl5/vendor_perl/5.8.5 /usr/lib/perl5/vendor_perl /usr/lib/perl5/5.8.8/i386-linux-thread-multi /usr/lib/perl5/5.8.8 .) at blib/lib/Config/IniHash.pm line 6. # BEGIN failed--compilation aborted at test.pl line 9. # Compilation failed in require at (eval 3) line 2. # BEGIN failed--compilation aborted at (eval 3) line 2. Undefined subroutine &main::WriteINI called at test.pl line 23. # Looks like you planned 4 tests but only ran 1. # Looks like you failed 1 test of 1 run. # Looks like your test died just after 1. make: *** [test_dynamic] Error 255 error: Bad exit status from /var/tmp/rpm-tmp.46589 (%check) RPM build errors: Bad exit status from /var/tmp/rpm-tmp.46589 (%check) Error building package from perl-Config-IniHash-2.8-1.fc6.src.rpm, See build log ending done
Missing BR on perl(IO::Scalar) *sigh* SRPM URL: http://home.comcast.net/~ckweyl/perl-Config-IniHash-2.8-2.fc6.src.rpm SPEC URL: http://home.comcast.net/~ckweyl/perl-Config-IniHash.spec
Package Review ============== Key: - = N/A x = Check ! = Problem ? = Not evaluated === REQUIRED ITEMS === [x] Buildroot is correct (%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)) [x] Rpmlint output: None [x] Package is named according to the Package Naming Guidelines. [x] Spec file name must match the base package %{name}, in the format %{name}.spec. [x] Package meets the Packaging Guidelines. [x] Package is licensed with an open-source compatible license and meet other legal requirements as defined in the legal section of Packaging Guidelines. [x] License field in the package spec file matches the actual license. License type: GPL or Artistic [-] If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x] Spec file is written in American English. [x] Spec file for the package is legible. [x] Sources used to build the package matches the upstream source, as provided in the spec URL. MD5SUM this package : fc8dff4d51cd0380f386e9f35bed59a2 MD5SUM upstream package: fc8dff4d51cd0380f386e9f35bed59a2 [x] Package successfully compiles and builds into binary rpms on at least one supported architecture. Tested on: FC-6 / i386 [x] Package is not known to require ExcludeArch, OR: Arches excluded: Why: [x] All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [-] The spec file handles locales properly. [-] ldconfig called in %post and %postun if required. [x] Package is not relocatable. [x] Package must own all directories that it creates. [-] Package requires other packages for directories it uses. [x] Package does not contain duplicates in %files. [x] Permissions on files are set properly. [x] Package has a %clean section, which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT). [x] Package consistently uses macros. [x] Package contains code, or permissable content. [-] Large documentation files are in a -doc subpackage, if required. [x] Package uses nothing in %doc for runtime. [-] Header files in -devel subpackage, if present. [-] Static libraries in -devel subpackage, if present. [-] Package requires pkgconfig, if .pc files are present. [-] Development .so files in -devel subpackage, if present. [-] Fully versioned dependency in subpackages, if present. [x] Package does not contain any libtool archives (.la). [-] Package contains a properly installed %{name}.desktop file if it is a GUI application. [x] Package does not own files or directories owned by other packages. === SUGGESTED ITEMS === [x] Package does not include license text files separate from upstream. [-] Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x] Reviewer should test that the package builds in mock. Tested on: FC-6 / i386 [-] Package should compile and build into binary rpms on all supported architectures. Tested on: [?] Package functions as described. [-] Scriptlets must be sane, if used. [-] The placement of pkgconfig(.pc) files are correct. [-] File based requires are sane. [!] Latest version is packaged. === Issues === 1. Please package latest version or justify why packaging a 2 year old version is warranted. Latest version is 2.9.0 http://search.cpan.org/dist/Config-IniHash/ === Final Notes === 1.
No justification possible (though I will admit to being confused how cpanspec would pick that version). For your convienence: http://search.cpan.org/diff?from=Config-IniHash-2.8&to=Config-IniHash-2.9.0 No changes except for a changelog entry and the version bump. SRPM URL: http://home.comcast.net/~ckweyl/perl-Config-IniHash-2.9.0-1.fc6.src.rpm SPEC URL: http://home.comcast.net/~ckweyl/perl-Config-IniHash.spec
[x] Sources used to build the package matches the upstream source, as provided in the spec URL. MD5SUM this package : 012e9bc3e320dcb031886a3ffcc19c09 MD5SUM upstream package: 012e9bc3e320dcb031886a3ffcc19c09 [x] Latest version is packaged. ================ *** APPROVED *** ================
New Package CVS Request ======================= Package Name: perl-Config-IniHash Short Description: Perl extension for reading and writing INI files Owners: cweyl.edu Branches: FC-5, FC-6, devel InitialCC: fedora-perl-devel-list
Imported and building... thanks for the review! :)
as per #569301, Package Change Request ====================== Package Name: perl-Config-IniHash New Branches: EL-4 EL-5 Owners: iarnell InitialCC: perl-sig
cvs done.