Bug 2370873 - Remove the unnecessary postrotate script from the logrotate configuration snippet
Summary: Remove the unnecessary postrotate script from the logrotate configuration sni...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: omniORB
Version: 42
Hardware: Unspecified
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Sandro Mani
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2025-06-06 19:23 UTC by Marcos Mello
Modified: 2025-06-19 01:58 UTC (History)
1 user (show)

Fixed In Version: omniORB-4.3.3-3.fc42
Clone Of:
Environment:
Last Closed: 2025-06-19 01:58:58 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Marcos Mello 2025-06-06 19:23:19 UTC
The logrotate configuration snippet is:

# cat /etc/logrotate.d/omniNames
/var/log/omniORB/*.log {
       weekly
       rotate 10
       copytruncate
       delaycompress
       compress
       notifempty
       missingok
       postrotate
          /bin/kill -USR1 `cat /var/run/omniORB/omniORB.pid 2>/dev/null` 2> /dev/null|| true
       endscript
}

Firstly, sending SIGUSR1 immediately terminates the daemon:

# systemctl kill --signal=USR1 --kill-who=main omniNames.service
# systemctl status omniNames.service
× omniNames.service - OmniORB Naming Service
     Loaded: loaded (/usr/lib/systemd/system/omniNames.service; disabled; preset: disabled)
    Drop-In: /usr/lib/systemd/system/service.d
             +-10-timeout-abort.conf
     Active: failed (Result: signal) since Fri 2025-06-06 16:08:22 -03; 14s ago
   Duration: 38min 2.417s
 Invocation: 2bd1eccf66f74544beeb2964181ac427
    Process: 3690 ExecStart=/usr/bin/omniNames -start -always -logdir /var/log/omniORB/ -errlog /var/log/omniORB/error.log (code=killed, signal=USR1)
   Main PID: 3690 (code=killed, signal=USR1)
   Mem peak: 1.1M
        CPU: 8ms

Jun 06 15:30:20 fedora systemd[1]: Started omniNames.service - OmniORB Naming Service.
Jun 06 16:08:22 fedora systemd[1]: omniNames.service: Sent signal SIGUSR1 to main process 3690 (omniNames) on client request.
Jun 06 16:08:22 fedora systemd[1]: omniNames.service: Main process exited, code=killed, status=10/USR1
Jun 06 16:08:22 fedora systemd[1]: omniNames.service: Failed with result 'signal'.

Secondly, the PID file no longer exists since the initscript was retired:

# systemctl restart omniNames.service
# cat /var/run/omniORB/omniORB.pid
cat: /var/run/omniORB/omniORB.pid: No such file or directory

Lastly, the logrotate configuration snippet uses copytruncate, which always keeps the same log file in place, making it unnecessary for the daemon to reopen the file. Therefore, please remove this part:

postrotate
  /bin/kill -USR1 `cat /var/run/omniORB/omniORB.pid 2>/dev/null` 2> /dev/null|| true
endscript

Reproducible: Always




Additional Information:
omniORB-servers-4.3.2-7.fc42.x86_64

Comment 1 Fedora Update System 2025-06-10 06:56:21 UTC
FEDORA-2025-f6f6a87a64 (omniORB-4.3.3-3.fc42) has been submitted as an update to Fedora 42.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-f6f6a87a64

Comment 2 Fedora Update System 2025-06-11 04:00:54 UTC
FEDORA-2025-f6f6a87a64 has been pushed to the Fedora 42 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-f6f6a87a64`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-f6f6a87a64

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 3 Fedora Update System 2025-06-19 01:58:58 UTC
FEDORA-2025-f6f6a87a64 (omniORB-4.3.3-3.fc42) has been pushed to the Fedora 42 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.