Spec URL: https://rathann.fedorapeople.org/review/faad2/faad2.spec SRPM URL: https://rathann.fedorapeople.org/review/faad2/faad2-2.11.2-2.fc43.src.rpm Description: FAAD 2 is a LC, MAIN and LTP profile, MPEG2 and MPEG-4 AAC decoder, completely written from scratch. Fedora Account System Username: rathann
Taking this review.
This looks mostly okay, but there's one issue: > %{_mandir}/man3/libfaad.3* This should be in the devel package since it's devel documentation.
Upstream have changed obviously, you can retain the new github projet as URL. Specially as the domain was re-assigned in 2021, so it's not even the old site/upstream.
Spec URL: https://rathann.fedorapeople.org/review/faad2/faad2.spec SRPM URL: https://rathann.fedorapeople.org/review/faad2/faad2-2.11.2-3.fc43.src.rpm * Mon Jun 09 2025 Dominik Mierzejewski <dominik> - 1:2.11.2-3 - supply a valid upstream URL - move libfaad manpage to devel subpackage
> Epoch: 1 Can we drop this?
(In reply to Neal Gompa from comment #5) > > Epoch: 1 > > Can we drop this? Only if we disregard the fact that RPM Fusion users won't see any updates until they dnf system-upgrade or distro-sync to F44.
Review notes: * Package follows Fedora Packaging Guidelines * Package builds and installs * Package licensing is correct and license data is installed correctly * No serious issues from rpmlint PACKAGE APPROVED.
The Pagure repository was created at https://src.fedoraproject.org/rpms/faad2
https://bodhi.fedoraproject.org/updates/FEDORA-2025-7d83f28cda Thanks for the review!
FEDORA-2025-899cbbd0c7 (faad2-2.11.2-3.fc42) has been submitted as an update to Fedora 42. https://bodhi.fedoraproject.org/updates/FEDORA-2025-899cbbd0c7
FEDORA-2025-fdc965aa2c (faad2-2.11.2-3.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2025-fdc965aa2c
FEDORA-2025-899cbbd0c7 has been pushed to the Fedora 42 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-899cbbd0c7 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-899cbbd0c7 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2025-fdc965aa2c has been pushed to the Fedora 41 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-fdc965aa2c \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-fdc965aa2c See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-EPEL-2025-3637b2295c (faad2-2.11.2-3.el9) has been submitted as an update to Fedora EPEL 9. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2025-3637b2295c
FEDORA-EPEL-2025-432c3df31b (faad2-2.11.2-3.el10_1) has been submitted as an update to Fedora EPEL 10.1. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2025-432c3df31b
FEDORA-EPEL-2025-3637b2295c has been pushed to the Fedora EPEL 9 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2025-3637b2295c See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-EPEL-2025-432c3df31b has been pushed to the Fedora EPEL 10.1 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2025-432c3df31b See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2025-899cbbd0c7 (faad2-2.11.2-3.fc42) has been pushed to the Fedora 42 stable repository. If problem still persists, please make note of it in this bug report.
Was this passed by fedora-legal? Last I knew some of the AAC patents may not expire for a few more years. fdk-aac was reviewed by legal for it's specific implementation(s), and approved, but that approval may not apply to faad2.
FEDORA-2025-fdc965aa2c (faad2-2.11.2-3.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report.