`systemctl try-reload-or-restart` leverages systemd's knowledge of the daemon's main PID, eliminating the need to rely on PID files or external tools like `killall` or `pkill`. The action of icecast.service's `ExecReload=` sends the same signal as currently sent by `kill`, making it a suitable replacement. This ensures precise signal sending to the intended process, reducing the risk of errors in process identification. Additionally, `systemctl try-reload-or-restart` is silent by default and returns zero if the daemon is inactive. It also logs the action in the service's journal, providing a record of actions taken. The logrotate configuration snippet: # cat /etc/logrotate.d/icecast /var/log/icecast/*log { missingok notifempty sharedscripts postrotate /bin/kill -HUP `cat /var/run/icecast/icecast.pid 2>/dev/null` 2> /dev/null || true endscript } In the postrotate script, kill can be replaced by: /usr/bin/systemctl try-reload-or-restart icecast.service Because: # systemctl show -P ExecReload icecast.service { path=/bin/kill ; argv[]=/bin/kill -HUP $MAINPID ; ignore_errors=no ; start_time=[n/a] ; stop_time=[n/a] ; pid=0 ; code=(null) ; status=0/0 } In addition to the fact that the PID file doesn't even exist, it wasn't working anyway: # systemctl is-active icecast.service ; cat /var/run/icecast/icecast.pid active cat: /var/run/icecast/icecast.pid: No such file or directory Reproducible: Always Additional Information: icecast-2.4.4-23.fc42.x86_64
Thanks for the bug report. It's a good idea.
FEDORA-2025-3ad202c6a1 (icecast-2.4.4-24.fc42) has been submitted as an update to Fedora 42. https://bodhi.fedoraproject.org/updates/FEDORA-2025-3ad202c6a1
FEDORA-2025-e37b80b0f3 (icecast-2.4.4-19.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2025-e37b80b0f3
Thank you. Cosmetic observation: `systemctl try-reload-or-restart` is silent by default and returns zero even when the daemon is inactive. It displays an error and returns non-zero when the unit file does not exist, which cannot happen, or when the `ExecReload=` command fails, whose error would be useful to indicate an issue with the unit file. Therefore, `1>/dev/null 2>/dev/null || true` at the end can be safely removed.
FEDORA-2025-3ad202c6a1 has been pushed to the Fedora 42 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-3ad202c6a1` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-3ad202c6a1 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2025-e37b80b0f3 has been pushed to the Fedora 41 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-e37b80b0f3` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-e37b80b0f3 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2025-3ad202c6a1 (icecast-2.4.4-24.fc42) has been pushed to the Fedora 42 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2025-e37b80b0f3 (icecast-2.4.4-19.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report.