Spec URL: https://in.waw.pl/~zbyszek/efitools.spec SRPM URL: https://in.waw.pl/~zbyszek/efitools-1.9.2-16.fc43.src.rpm Description: This package installs a variety of tools for manipulating keys and binary signatures on UEFI secure boot platforms. The tools provide access to the keys and certificates stored in the secure variables of the UEFI firmware, usually in the NVRAM area. Fedora Account System Username: zbyszek
There seems to be some problem with the following file. SRPM URL: https://in.waw.pl/~zbyszek/efitools-1.9.2-16.fc43.src.rpm Fetching it results in a 403 Forbidden error. Please make sure the URL is correct and publicly available. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://in.waw.pl/~zbyszek/fedora/efitools.spec https://in.waw.pl/~zbyszek/fedora/efitools-1.9.2-16.fc43.src.rpm
Copr build: https://copr.fedorainfracloud.org/coprs/build/9152990 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2372289-efitools/fedora-rawhide-x86_64/09152990-efitools/fedora-review/review.txt Found issues: - Not a valid SPDX expression 'GPLv2 and LGPLv2 and BSD'. It seems that you are using the old Fedora license abbreviations. Try `license-fedora2spdx' for converting it to SPDX. Read more: https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_1 - A package with this name already exists. Please check https://src.fedoraproject.org/rpms/efitools Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://in.waw.pl/~zbyszek/fedora/efitools.spec https://in.waw.pl/~zbyszek/fedora/efitools-1.9.2-17.fc43.src.rpm
Created attachment 2093660 [details] The .spec file difference from Copr build 9152990 to 9153029
Copr build: https://copr.fedorainfracloud.org/coprs/build/9153029 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2372289-efitools/fedora-rawhide-x86_64/09153029-efitools/fedora-review/review.txt Found issues: - A package with this name already exists. Please check https://src.fedoraproject.org/rpms/efitools Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Any update on reintroducing efitools? Thanks
Taking this review.
Neal?
Spec review: The main thing I see is the glob on man pages. Presuming the man pages are a 1:1 match for the executables, would something like this work in the files section? # Some small macro to list tools with manpages -- cribbed from libsolv %define efi_tool() \ %{_bindir}/%{1}\ %{_mandir}/man1/%{1}.1* %efi_tool cert-to-efi-hash-list %efi_tool cert-to-efi-sig-list %efi_tool efi-readvar %efi_tool efi-updatevar %efi_tool efitool-mkusb %efi_tool flash-var %efi_tool hash-to-efi-sig-list %efi_tool sig-list-to-certs %efi_tool sign-efi-sig-list
Two man pages were missing. But otherwise this works nicely. https://in.waw.pl/~zbyszek/fedora/efitools.spec https://in.waw.pl/~zbyszek/fedora/efitools-1.9.2-18.fc43.src.rpm
Created attachment 2103272 [details] The .spec file difference from Copr build 9153029 to 9397601
Copr build: https://copr.fedorainfracloud.org/coprs/build/9397601 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2372289-efitools/fedora-rawhide-x86_64/09397601-efitools/fedora-review/review.txt Found issues: - A package with this name already exists. Please check https://src.fedoraproject.org/rpms/efitools Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Review notes: * Package follows the Fedora packaging guidelines * Package licensing is correct and license data is installed * Package builds and installs * No serious issues from rpmlint PACKAGE APPROVED.
The Pagure repository was created at https://src.fedoraproject.org/rpms/efitools