Looking to submit a new package into Fedora. Successfully built in copr please review https://copr.fedorainfracloud.org/coprs/androniychuk/igsc SPEC Url: https://download.copr.fedorainfracloud.org/results/androniychuk/igsc/fedora-rawhide-x86_64/09153765-igsc/igsc.spec SRPM Url: https://download.copr.fedorainfracloud.org/results/androniychuk/igsc/fedora-rawhide-x86_64/09153765-igsc/igsc-0.9.5-1.fc43.src.rpm Additional Information: This package is needed for additional features in compute-runtime. https://github.com/intel/compute-runtime This package has a dependency on metee, which was already upgraded in rawhide to version 5.0.0
The ticket summary is not in the correct format. Expected: Review Request: <main package name here> - <short summary here> Found: New igsc package submitted As a consequence, the package name cannot be parsed and submitted to be automatically build. Please modify the ticket summary and trigger a build by typing [fedora-review-service-build]. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
SPEC Url: https://download.copr.fedorainfracloud.org/results/androniychuk/igsc/fedora-rawhide-x86_64/09153765-igsc/igsc.spec SRPM Url: https://download.copr.fedorainfracloud.org/results/androniychuk/igsc/fedora-rawhide-x86_64/09153765-igsc/igsc-0.9.5-1.fc43.src.rpm
Copr build: https://copr.fedorainfracloud.org/coprs/build/9153824 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2372339-igsc/fedora-rawhide-x86_64/09153824-igsc/fedora-review/review.txt Found issues: - Documentation size is 1368015 bytes in 86 files. Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_documentation Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
(In reply to Fedora Review Service from comment #3) > Found issues: > > - Documentation size is 1368015 bytes in 86 files. > Read more: > https://docs.fedoraproject.org/en-US/packaging-guidelines/#_documentation > > Please know that there can be false-positives. FWIW, I needed igsc for myself, and built it in my own copr. I decided to create a dedicated doc package to reduce the size(s) of main and devel package(s). The spec can be found at: https://download.copr.fedorainfracloud.org/results/gtb/igsc/fedora-rawhide-x86_64/09181564-igsc/igsc.spec Feel free to use any or none of the various spec file snippets.
@pavel.androniychuk please adjust the following: > %{_libdir}/libigsc.so.* Do not use wildcards here, in case there is a dependent package using the libraries, we want to avoid accidental shared object version bumps. > %{_libdir}/cmake/igsc/*.cmake Nothing owns the %{_libdir}/cmake/igsc folder. Please just use this to own all cmake files: %{_libdir}/cmake/igsc/ > %{_docdir} Your package does not own the entire _docdir, please own only the package folder. For example: %{_docdir}/%{name} I agree with the suggestion of using a separate doc package, the documentation is too big for the -devel subpackage. Please remember to include the %license tag also there, if the package will not require the base package in its chain of dependencies. > %{_mandir} Same as above, please own only your files, for example: %{_mandir}/man3/* > Requires: intel-gsc Please be more specific for the requirement, for example: Requires: %{name}%{?_isa} = %{version}-%{release} The same goes for the other requirements (intel-metee etc.) please use the same format with %{?_isa}. > BuildRequires: gcc gcc-c++ Please put BuildRequires each on its own line (not required, but definitely more readable).
@pavel please use this format for reviews: https://bugzilla.redhat.com/enter_bug.cgi?product=Fedora&format=fedora-review When posting the link to the updated src.rpm and spec file, please add again the "Spec URL" and "SRPM URL" lines in a bugzilla comment.
Are you planning to proceed with the review?
I am, just a few higher priority items were escalated, so I had to put this off for a little while. But I will proceed with adding igsc to fedora within 2-3 weeks is my best ETA
@negativo17 I was finally able to get back to this Spec URL: https://download.copr.fedorainfracloud.org/results/androniychuk/igsc/fedora-rawhide-x86_64/09598691-igsc/igsc.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/androniychuk/igsc/fedora-rawhide-x86_64/09598691-igsc/igsc-0.9.5-1.fc44.src.rpm Updated spec with above edits
Created attachment 2107493 [details] The .spec file difference from Copr build 9153824 to 9598695
Copr build: https://copr.fedorainfracloud.org/coprs/build/9598695 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2372339-igsc/fedora-rawhide-x86_64/09598695-igsc/fedora-review/review.txt Found issues: - Documentation size is 1368015 bytes in 86 files. Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_documentation Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
FWIW, Intel just released igsc 1.0.0 a few days ago (so it is probably worth rebasing to the latest upstream, although that is unlikely to impact the package review).
I would not be comfortable to promote 1.0.0 yet. Validation has completed with all the other applications and UMDs that use igsc.
*Validation has NOT been completed
Some changes: - Mixed uses of spaces and tabs, please use all spaces (igsc.spec:19: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 19)) - A Source0 URL that will generate the correct tarball name (in the lookaside cache the files are all together) - Split the BuildRequires on separate lines - Drop the `-n %{name}-%{version}` in the %autosetup line - A bit more white space for readability (optional)
Here is an attached diff for the points above: $ diff -Naur igsc.spec igsc.spec.new --- igsc.spec 2025-09-25 01:26:37.000000000 +0200 +++ igsc.spec.new 2025-10-17 13:17:07.143456395 +0200 @@ -2,14 +2,15 @@ Version: 0.9.5 Release: %autorelease Summary: Intel Graphics System Controller Firmware Update Library (IGSC FUL) - License: Apache-2.0 -URL: https://github.com/intel/igsc -Source0: %{url}/archive/V%{version}.tar.gz +URL: https://github.com/intel/igsc + +Source0: %{url}/archive/V%{version}/%{name}-%{version}.tar.gz Patch0: dont_hardcode_libdir.patch BuildRequires: cmake -BuildRequires: gcc gcc-c++ +BuildRequires: gcc +BuildRequires: gcc-c++ BuildRequires: doxygen BuildRequires: python3-sphinx BuildRequires: systemd-devel @@ -36,6 +37,7 @@ %package -n intel-gsc Summary: Intel Graphics System Controller Firmware Update Library (IGSC FUL) Requires: intel-metee >= 5.0.0 + %description -n intel-gsc The Intel Graphics System Firmware Update Library (IGSC FUL) is a pure C low level library that exposes a required API @@ -55,6 +57,7 @@ Summary: Development headers for igsc Requires: intel-gsc = %{version}-%{release} Requires: intel-metee-devel >= 5.0.0 + %description -n intel-gsc-devel The Intel Graphics System Firmware Update Library (IGSC FUL) is a pure C low level library that exposes a required API @@ -71,7 +74,7 @@ function for firmware update of those images to the device. %prep -%autosetup -p1 -n %{name}-%{version} +%autosetup -p1 %build %cmake \ @@ -82,7 +85,6 @@ %install %cmake_install - %files -n intel-gsc %license LICENSE.txt %{_bindir}/igsc
After the changes above, package will be approved. Thanks!
Changes made above and submitted. Build succeeded, available here https://copr.fedorainfracloud.org/coprs/androniychuk/igsc/build/9700131/
SPEC Url: https://download.copr.fedorainfracloud.org/results/androniychuk/intel-igc/fedora-rawhide-x86_64/09544229-intel-igc/intel-igc.spec SRPM Url: https://download.copr.fedorainfracloud.org/results/androniychuk/intel-igc/fedora-rawhide-x86_64/09544229-intel-igc/intel-igc-2.16.0-1.fc44.src.rpm
You pasted the wrong URLs, these are for the "igc" package instead of "igsc".
SPEC Url: https://download.copr.fedorainfracloud.org/results/androniychuk/igsc/fedora-rawhide-x86_64/09700131-igsc/igsc.spec SPRM Url: https://download.copr.fedorainfracloud.org/results/androniychuk/igsc/fedora-rawhide-x86_64/09700131-igsc/igsc-0.9.5-1.fc44.src.rpm
Package approved. Please sort BuildRequires.
The Pagure repository was created at https://src.fedoraproject.org/rpms/igsc
FEDORA-2025-e7e7325978 (igsc-0.9.5-1.fc44) has been submitted as an update to Fedora 44. https://bodhi.fedoraproject.org/updates/FEDORA-2025-e7e7325978
FEDORA-2025-e7e7325978 (igsc-0.9.5-1.fc44) has been pushed to the Fedora 44 stable repository. If problem still persists, please make note of it in this bug report.