Bug 2372539 - Use `systemctl kill` in logrotate postrotate script
Summary: Use `systemctl kill` in logrotate postrotate script
Keywords:
Status: NEW
Alias: None
Product: Fedora
Classification: Fedora
Component: tcmu-runner
Version: 42
Hardware: Unspecified
OS: Linux
unspecified
low
Target Milestone: ---
Assignee: Maurizio Lombardi
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2025-06-12 18:58 UTC by Marcos Mello
Modified: 2025-06-12 18:58 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed:
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Marcos Mello 2025-06-12 18:58:11 UTC
`systemctl kill` leverages systemd's knowledge of the daemon's main PID, eliminating the need to rely on PID files or external tools like `killall` or `pkill`. This ensures precise signal sending to the intended process, reducing the risk of errors in process identification. Additionally, using `systemctl kill` logs the signal sending in the service's journal, providing a record of actions taken. Requires selinux-policy-41.43 or higher (see https://bugzilla.redhat.com/show_bug.cgi?id=2369644), available as an update for F41, F42, and Rawhide.

https://bodhi.fedoraproject.org/updates/FEDORA-2025-eb98eb9e24 (F41 -- will go to stable in a few days)
https://bodhi.fedoraproject.org/updates/FEDORA-2025-f9f097f491 (F42 -- stable)
https://bodhi.fedoraproject.org/updates/FEDORA-2025-3db4c0ec1c (Rawhide)

The logrotate configuration snippet:

# cat /etc/logrotate.d/tcmu-runner
/var/log/tcmu-runner*.log {
    rotate 7
    size 10M
    compress
    missingok
    notifempty
    nodateext
    postrotate
        killall -q -s 1 tcmu-runner
    endscript
}

In the postrotate script, killall can be replaced by:

/usr/bin/systemctl kill --signal=HUP --kill-whom=main tcmu-runner.service 2>/dev/null || true

Because:

# systemctl show -P MainPID tcmu-runner.service
4255
# pgrep tcmu-runner
4255

Reproducible: Always




Additional Information:
tcmu-runner-1.5.4-11.fc42.x86_64


Note You need to log in before you can comment on or make changes to this bug.