Bug 2372765 - Use `systemctl kill` in logrotate postrotate script
Summary: Use `systemctl kill` in logrotate postrotate script
Keywords:
Status: NEW
Alias: None
Product: Fedora
Classification: Fedora
Component: iscsi-initiator-utils
Version: 42
Hardware: Unspecified
OS: Linux
unspecified
low
Target Milestone: ---
Assignee: Chris Leech
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2025-06-13 18:04 UTC by Marcos Mello
Modified: 2025-06-13 18:04 UTC (History)
1 user (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed:
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Marcos Mello 2025-06-13 18:04:50 UTC
`systemctl kill` leverages systemd's knowledge of the daemon's main PID, eliminating the need to rely on PID files or external tools like `killall` or `pkill`. This ensures precise signal sending to the intended process, reducing the risk of errors in process identification. Additionally, using `systemctl kill` logs the signal sending in the service's journal, providing a record of actions taken. Requires selinux-policy-41.43 or higher (see https://bugzilla.redhat.com/show_bug.cgi?id=2369644), available as an update for F41, F42, and Rawhide.

https://bodhi.fedoraproject.org/updates/FEDORA-2025-eb98eb9e24 (F41 -- will go to stable in a few days)
https://bodhi.fedoraproject.org/updates/FEDORA-2025-f9f097f491 (F42 -- stable)
https://bodhi.fedoraproject.org/updates/FEDORA-2025-3db4c0ec1c (Rawhide)

The logrotate configuration snippet:

# cat /etc/logrotate.d/iscsiuiolog
/var/log/iscsiuio.log {
    weekly
    missingok
    notifempty
    rotate 4
    sharedscripts
    postrotate
    pkill -USR1 iscsiuio 2> /dev/null || true
    endscript
}

In the postrotate script, pkill can be replaced by:

/usr/bin/systemctl kill --signal=USR1 --kill-whom=main iscsiuio.service 2>/dev/null || true

Because:

# systemctl show -P MainPID iscsiuio.service
4226
# pgrep iscsiuio
4226

Reproducible: Always




Additional Information:
iscsi-initiator-utils-iscsiuio-6.2.1.11-0.git4b3e853.fc42.x86_64


Note You need to log in before you can comment on or make changes to this bug.