Spec URL: https://github.com/pbiering/signal-cli-rpm/blob/main/signal-cli.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/pbiering/InternetServerExtensions/fedora-rawhide-x86_64/09161838-signal-cli/signal-cli-0.13.16-2.fc43.src.rpm Description: signal-cli commandline, dbus and JSON-RPC interface for the Signal messenger Fedora Account System Username: pbiering See also https://github.com/pbiering/signal-cli-rpm https://discussion.fedoraproject.org/t/request-package-signal-cli/155785/3
Hello, I do realize that this is possibly an old ticket. I am sorry that it hasn't been reviewed yet. Let me trigger the Fedora Review Service to see if the package builds successfully. Hopefully, a green check mark will attract some reviewer. If I am resurrecting an old ticket that you are not interested in anymore, my apologies, feel free to close it. [fedora-review-service-build]
There seems to be some problem with the following file. SRPM URL: https://download.copr.fedorainfracloud.org/results/pbiering/InternetServerExtensions/fedora-rawhide-x86_64/09161838-signal-cli/signal-cli-0.13.16-2.fc43.src.rpm Fetching it results in a 404 Not Found error. Please make sure the URL is correct and publicly available. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://copr.fedorainfracloud.org/coprs/pbiering/InternetServerExtensions/package/signal-cli/ https://copr.fedorainfracloud.org/coprs/pbiering/InternetServerExtensions/build/9800397/ Latest SRPM URL: https://download.copr.fedorainfracloud.org/results/pbiering/InternetServerExtensions/fedora-rawhide-x86_64/09800397-signal-cli/signal-cli-0.13.22-1.fc44.src.rpm
Copr build: https://copr.fedorainfracloud.org/coprs/build/9820247 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2373115-signal-cli/fedora-rawhide-x86_64/09820247-signal-cli/fedora-review/review.txt Found issues: - Not a valid SPDX expression 'GPLv3'. It seems that you are using the old Fedora license abbreviations. Try `license-fedora2spdx' for converting it to SPDX. Read more: https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_1 - No javadoc subpackage present. Note: Javadocs are optional for Fedora versions >= 21 Read more: https://fedoraproject.org/wiki/Packaging:Java#Javadoc_installation - No javadoc subpackage present Read more: https://fedoraproject.org/wiki/Packaging:Java#Javadoc_installation Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://copr.fedorainfracloud.org/coprs/pbiering/InternetServerExtensions/build/9820361/ https://download.copr.fedorainfracloud.org/results/pbiering/InternetServerExtensions/fedora-rawhide-x86_64/09820361-signal-cli/signal-cli-0.13.22-2.fc44.src.rpm license string adjusted
Created attachment 2115448 [details] The .spec file difference from Copr build 9820247 to 9820382
Copr build: https://copr.fedorainfracloud.org/coprs/build/9820382 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2373115-signal-cli/fedora-rawhide-x86_64/09820382-signal-cli/fedora-review/review.txt Found issues: - No javadoc subpackage present. Note: Javadocs are optional for Fedora versions >= 21 Read more: https://fedoraproject.org/wiki/Packaging:Java#Javadoc_installation - No javadoc subpackage present Read more: https://fedoraproject.org/wiki/Packaging:Java#Javadoc_installation Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
fixed some issues in the new build https://copr.fedorainfracloud.org/coprs/pbiering/InternetServerExtensions/build/9825118/ https://download.copr.fedorainfracloud.org/results/pbiering/InternetServerExtensions/fedora-rawhide-x86_64/09825118-signal-cli/signal-cli-0.13.22-3.fc44.src.rpm But unsure whether all can be fixed. Note also that precompiled Java application is taken as source from github release and not compiled itself at the moment from real source There is a statement in https://discussion.fedoraproject.org/t/request-package-signal-cli/155785/3 that complete compilation from original source is mandatory... ...if true, the spec file need major extension to build all from real source.