Spec URL: http://www.hardakers.net/FE/perl-Crypt-OpenSSL-Random.spec SRPM URL: http://www.hardakers.net/FE/perl-Crypt-OpenSSL-Random.spec Description: A Perl wrapper around OpenSSL's Random number generation library. (I don't currently have a sponsor, although there are other packages I've submitted as well tagged as needing a sponsor as well).
Fixed srpm url: Spec URL: http://www.hardakers.net/FE/perl-Crypt-OpenSSL-Random.spec SRPM URL: http://www.hardakers.net/FE/perl-Crypt-OpenSSL-Random-0.03-1.src.rpm
Spec URL: http://www.hardakers.net/FE/perl-Crypt-OpenSSL-Random.spec SRPM URL: http://www.hardakers.net/FE/perl-Crypt-OpenSSL-Random-0.03-2.src.rpm - Add BuildRequire openssl-devel - Don't manually require openssl - Use vendorarch instead of vendorlib
Buildrequires: perl(ExtUtils::MakeMaker) is needed to cope with the perl-devel split. I don't see any other requirements in Makefile.PL or the test suite. However, there's one very significant problem with this package: I can find no statement of the license anywhere. You've indicated "GPL or Artistic"; I'm curious where that comes from. Unfortunately packages with no license statements are simply not acceptable as-is; we at least need an email from the author indicating the license the package is under. * source files match upstream: eff9477303a70308596c0b41623294f9584855270ad9997a06354d6d6f9e87e8 Crypt-OpenSSL-Random-0.03.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * dist tag is present. * build root is OK. ? license field matches the actual license. ? license is open source-compatible. * license text not included upstream. * latest version is being packaged. * BuildRequires are proper. * compiler flags are appropriate. * %clean is present. * package builds in mock (development, x86_64). * package installs properly * debuginfo package looks complete. * rpmlint is silent. * final provides and requires are sane: Random.so()(64bit) perl(Crypt::OpenSSL::Random) = 0.03 perl-Crypt-OpenSSL-Random = 0.03-2.fc7 = libcrypto.so.6()(64bit) libssl.so.6()(64bit) perl(:MODULE_COMPAT_5.8.8) perl(AutoLoader) perl(Carp) perl(DynaLoader) perl(Exporter) perl(strict) perl(vars) * %check is present and all tests pass: 1..1 ok 1 ok 2 ok 3 ok 4 * no shared libraries are added to the regular linker search paths. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * no headers. * no pkgconfig files. * no static libraries. * no libtool .la droppings.
Spec URL: http://www.hardakers.net/FE/perl-Crypt-OpenSSL-Random.spec SRPM URL: http://www.hardakers.net/FE/perl-Crypt-OpenSSL-Random-0.03-3.src.rpm * Mon May 14 2007 Wes Hardaker <wjhns174> - 0.03-3 - BuildRequire perl(ExtUtils::MakeMaker)
(oh, and I'll work on the license issue)
This package is fine now except for the license issue; it is sufficient to obtain a simple email from the author stating the license terms (even "same as Perl" is fine) as long as you include the text of that email in the package as %doc.
When I get a response, I'll do so (or better yet... hopefully he'll republish it). thanks for the note about email verification being ok.
Spec URL: http://www.hardakers.net/FE/perl-Crypt-OpenSSL-Random.spec SRPM URL: http://www.hardakers.net/FE/perl-Crypt-OpenSSL-Random-0.04-1.src.rpm - Update to upstream 0.4 with proper license
Cool. Now, since there's a license file in the upstream source, it needs to be included in the package. Just add "LICENSE" after "%doc Changes" in your %files section. Other than that, this package is good to go; I'll go ahead and approve and trust you to add the LICENSE file when you check in. APPROVED
New Package CVS Request ======================= Package Name: perl-Crypt-OpenSSL-Random Short Description: Perl OpenSSL bindings for Random Number support Owners: wjhns174 Branches: FC-6 F-7 InitialCC:
cvs done
w00t. done!
Package Change Request ====================== Package Name: perl-Crypt-OpenSSL-Random New Branches: EL-4 EL-5
CVS Done