Bug 237340 - Review Request: python-BeautifulSoup - HTML/XML parser for quick-turnaround applications like screen-scraping
Summary: Review Request: python-BeautifulSoup - HTML/XML parser for quick-turnaround a...
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Bernard Johnson
QA Contact: Fedora Package Reviews List
Depends On:
TreeView+ depends on / blocked
Reported: 2007-04-20 21:24 UTC by Nicolas Chauvet (kwizart)
Modified: 2007-12-19 02:21 UTC (History)
0 users

Clone Of:
Last Closed: 2007-05-05 10:47:05 UTC
bjohnson: fedora-review+
kevin: fedora-cvs+

Attachments (Terms of Use)

Description Nicolas Chauvet (kwizart) 2007-04-20 21:24:26 UTC
Spec URL:
Description: HTML/XML parser for quick-turnaround applications like screen-scraping

Comment 1 Bernard Johnson 2007-04-30 19:04:14 UTC
Package Review

 - = N/A
 x = Check
 ! = Problem
 ? = Not evaluated

 [x] Package is named according to the Package Naming Guidelines.
 [x] Spec file name must match the base package %{name}, in the format %{name}.spec.
 [x] Package meets the Packaging Guidelines.
 [x] Package successfully compiles and builds into binary rpms on at least one
supported architecture.
     Tested on: FC-6 / i386
 [x] Rpmlint output: None
 [x] Package is not relocatable.
 [x] Buildroot is correct
(%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n))
 [x] Package is licensed with an open-source compatible license and meets other
legal requirements as defined in the legal section of Packaging Guidelines.
 [x] License field in the package spec file matches the actual license.
     License type: Python Software Foundation License
 [-] If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %doc.
 [x] Spec file is legible and written in American English.
 [x] Sources used to build the package matches the upstream source, as provided
in the spec URL.
     MD5SUM this package    : 13a7a16e7f3b8febaace13b1b2790550
     MD5SUM upstream package: 13a7a16e7f3b8febaace13b1b2790550
 [x] Package is not known to require ExcludeArch, OR:
     Arches excluded:
 [x] All build dependencies are listed in BuildRequires, except for any that are
listed in the exceptions section of Packaging Guidelines.
 [-] The spec file handles locales properly.
 [-] ldconfig called in %post and %postun if required.
 [x] Package must own all directories that it creates.
 [-] Package requires other packages for directories it uses.
 [x] Package does not contain duplicates in %files.
 [x] Permissions on files are set properly.
 [x] Package has a %clean section, which contains rm -rf %{buildroot} (or
 [x] Package consistently uses macros.
 [x] Package contains code, or permissable content.
 [-] Large documentation files are in a -doc subpackage, if required.
 [x] Package uses nothing in %doc for runtime.
 [-] Header files in -devel subpackage, if present.
 [-] Static libraries in -devel subpackage, if present.
 [-] Package requires pkgconfig, if .pc files are present.
 [-] Development .so files in -devel subpackage, if present.
 [-] Fully versioned dependency in subpackages, if present.
 [-] Package does not contain any libtool archives (.la).
 [-] Package contains a properly installed %{name}.desktop file if it is a GUI
 [x] Package does not own files or directories owned by other packages.

 [x] Latest version is packaged.
 [x] Package does not include license text files separate from upstream.
 [-] Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
 [x] Reviewer should test that the package builds in mock.
     Tested on: FC-6 / i386
 [-] Package should compile and build into binary rpms on all supported
     Tested on:
 [?] Package functions as described.
 [-] Scriptlets must be sane, if used.
 [-] The placement of pkgconfig(.pc) files are correct.
 [-] File based requires are sane.

=== Issues ===
=== Final Notes ===
1. I'm not sure that the PKG-INFO file in %doc is useful for a regular user.

*** APPROVED ***

Comment 2 Nicolas Chauvet (kwizart) 2007-04-30 23:07:36 UTC
Well Since there is no license file this PKG-INFO is the only one provinding
such information...That's why i've used it...

This package is needed by freevo which is a Multimedia system written in python:

I'm working on packaging it but since it "prefer" player that are not present in
Extras i will ask on the possibility to submit it on extras...

Comment 3 Nicolas Chauvet (kwizart) 2007-04-30 23:08:39 UTC
New Package CVS Request
Package Name: python-BeautifulSoup
Short Description: HTML/XML parser for quick-turnaround applications like
Owners: kwizart@gmail.com
Branches: FC-6 devel

Comment 4 Bernard Johnson 2007-04-30 23:34:31 UTC
(In reply to comment #2)
> Well Since there is no license file this PKG-INFO is the only one provinding
> such information...That's why i've used it...

Which is the only thing I noticed too, otherwise it would be useless :)

Comment 5 Nicolas Chauvet (kwizart) 2007-12-18 17:45:12 UTC
Package Change Request
Package Name: python-BeautifulSoup
New Branches: EL-5

Comment 6 Kevin Fenzi 2007-12-19 02:21:40 UTC
cvs done.

Note You need to log in before you can comment on or make changes to this bug.