Spec URL: https://solomoncyj.fedorapeople.org/reviews/python-zulip/python-zulip.spec SRPM URL: https://solomoncyj.fedorapeople.org/reviews/python-zulip/python-zulip-0.9.0-1.fc42.src.rpm Description: The Zulip API Python bindings Fedora Account System Username: solomoncyj
Build does not complete: error: File not found: /builddir/build/BUILD/python-zulip-0.9.0-build/BUILDROOT/usr/share/licenses/python3-zulip/THIRDPARTY error: File not found: /builddir/build/BUILD/python-zulip-0.9.0-build/BUILDROOT/usr/share/licenses/python3-zulip/LICENSE RPM build errors: File not found: /builddir/build/BUILD/python-zulip-0.9.0-build/BUILDROOT/usr/share/doc/python3-zulip/README.MD File not found: /builddir/build/BUILD/python-zulip-0.9.0-build/BUILDROOT/usr/share/licenses/python3-zulip/THIRDPARTY File not found: /builddir/build/BUILD/python-zulip-0.9.0-build/BUILDROOT/usr/share/licenses/python3-zulip/LICENSE Get sources from GitHub instead of PyPI.
https://solomoncyj.fedorapeople.org/reviews/python-zulip-api/python-zulip-api-0.9.0-1.20250627git0.9.0.fc42.src.rpm https://solomoncyj.fedorapeople.org/reviews/python-zulip-api/python-zulip.spec
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Dist tag is present. - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file license.txt is not marked as %license See: https://docs.fedoraproject.org/en-US/packaging- guidelines/LicensingGuidelines/#_license_text - Spec file name must match the spec package %{name}, in the format %{name}.spec. Note: python-zulip.spec should be python-zulip-api.spec See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_spec_file_naming ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: There is no build directory. Running licensecheck on vanilla upstream sources. No licenses found. Please check the source files for licenses manually. [ ]: License file installed when any subpackage combination is installed. [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/python3.14, /usr/lib/python3.14/site-packages [ ]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 2601 bytes in 1 files. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [-]: Binary eggs must be removed in %prep Note: Cannot find any build in BUILD directory (--prebuilt option?) [-]: Python eggs must not download any dependencies during the build process. [-]: A package which is used by another package via an egg interface should provide egg info. [ ]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files ===== SHOULD items ===== Generic: [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [!]: Final provides and requires are sane (see attachments). [ ]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python3-zulip , python3-zulip_bots , python3-zulip_botserver [ ]: Package functions as described. [ ]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [ ]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Spec file according to URL is the same as in SRPM. Note: Bad spec filename: /home/benson/Projects/fedora- packaging/reviews/python-zulip-api/2375144-python-zulip/srpm- unpacked/python-zulip.spec See: (this test has no URL) [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). Rpmlint ------- Checking: python3-zulip-0.9.0-1.20250627git0.9.0.fc43.noarch.rpm python3-zulip_bots-0.9.0-1.20250627git0.9.0.fc43.noarch.rpm python3-zulip_botserver-0.9.0-1.20250627git0.9.0.fc43.noarch.rpm python-zulip-api-0.9.0-1.20250627git0.9.0.fc43.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp7544r61o')] checks: 32, packages: 4 python3-zulip.noarch: E: zero-length /usr/lib/python3.14/site-packages/integrations/git/requirements.txt python3-zulip.noarch: E: zero-length /usr/lib/python3.14/site-packages/integrations/jira/requirements.txt python3-zulip.noarch: E: zero-length /usr/lib/python3.14/site-packages/integrations/nagios/requirements.txt python3-zulip.noarch: E: zero-length /usr/lib/python3.14/site-packages/integrations/openshift/requirements.txt python3-zulip.noarch: E: zero-length /usr/lib/python3.14/site-packages/integrations/perforce/requirements.txt python3-zulip.noarch: E: zero-length /usr/lib/python3.14/site-packages/integrations/trello/requirements.txt python3-zulip.noarch: E: zero-length /usr/share/zulip/integrations/git/requirements.txt python3-zulip.noarch: E: zero-length /usr/share/zulip/integrations/jira/requirements.txt python3-zulip.noarch: E: zero-length /usr/share/zulip/integrations/nagios/requirements.txt python3-zulip.noarch: E: zero-length /usr/share/zulip/integrations/openshift/requirements.txt python3-zulip.noarch: E: zero-length /usr/share/zulip/integrations/perforce/requirements.txt python3-zulip.noarch: E: zero-length /usr/share/zulip/integrations/trello/requirements.txt python3-zulip.noarch: E: non-executable-script /usr/lib/python3.14/site-packages/integrations/bridge_with_matrix/matrix_bridge.py 644 /usr/bin/env python3 python3-zulip.noarch: E: non-executable-script /usr/lib/python3.14/site-packages/integrations/trello/zulip_trello.py 644 /usr/bin/env python3 python3-zulip.noarch: E: non-executable-script /usr/lib/python3.14/site-packages/zulip/api_examples.py 644 /usr/bin/env python3 python3-zulip.noarch: E: non-executable-script /usr/lib/python3.14/site-packages/zulip/cli.py 644 /usr/bin/env python3 python3-zulip.noarch: E: non-executable-script /usr/lib/python3.14/site-packages/zulip/send.py 644 /usr/bin/env python3 python3-zulip_bots.noarch: E: non-executable-script /usr/lib/python3.14/site-packages/zulip_bots/bot_shell.py 644 /usr/bin/env python3 python3-zulip_bots.noarch: E: non-executable-script /usr/lib/python3.14/site-packages/zulip_bots/provision.py 644 /usr/bin/env python3 python3-zulip_bots.noarch: E: non-executable-script /usr/lib/python3.14/site-packages/zulip_bots/run.py 644 /usr/bin/env python3 python3-zulip_botserver.noarch: E: non-executable-script /usr/lib/python3.14/site-packages/zulip_botserver/server.py 644 /usr/bin/env python3 python3-zulip.noarch: W: no-manual-page-for-binary zulip-api python3-zulip.noarch: W: no-manual-page-for-binary zulip-api-examples python3-zulip.noarch: W: no-manual-page-for-binary zulip-bot-shell python3-zulip.noarch: W: no-manual-page-for-binary zulip-botserver python3-zulip.noarch: W: no-manual-page-for-binary zulip-matrix-bridge python3-zulip.noarch: W: no-manual-page-for-binary zulip-run-bot python3-zulip.noarch: W: no-manual-page-for-binary zulip-send python3-zulip_bots.noarch: W: no-documentation python3-zulip_botserver.noarch: W: no-documentation python-zulip-api.src: E: invalid-spec-name python3-zulip.noarch: W: files-duplicate /usr/share/zulip/integrations/log2zulip/requirements.txt /usr/lib/python3.14/site-packages/integrations/codebase/requirements.txt:/usr/lib/python3.14/site-packages/integrations/log2zulip/requirements.txt:/usr/share/zulip/integrations/codebase/requirements.txt 4 packages and 0 specfiles checked; 22 errors, 10 warnings, 13 filtered, 22 badness; has taken 1.8 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 3 python3-zulip.noarch: E: zero-length /usr/lib/python3.14/site-packages/integrations/git/requirements.txt python3-zulip.noarch: E: zero-length /usr/lib/python3.14/site-packages/integrations/jira/requirements.txt python3-zulip.noarch: E: zero-length /usr/lib/python3.14/site-packages/integrations/nagios/requirements.txt python3-zulip.noarch: E: zero-length /usr/lib/python3.14/site-packages/integrations/openshift/requirements.txt python3-zulip.noarch: E: zero-length /usr/lib/python3.14/site-packages/integrations/perforce/requirements.txt python3-zulip.noarch: E: zero-length /usr/lib/python3.14/site-packages/integrations/trello/requirements.txt python3-zulip.noarch: E: zero-length /usr/share/zulip/integrations/git/requirements.txt python3-zulip.noarch: E: zero-length /usr/share/zulip/integrations/jira/requirements.txt python3-zulip.noarch: E: zero-length /usr/share/zulip/integrations/nagios/requirements.txt python3-zulip.noarch: E: zero-length /usr/share/zulip/integrations/openshift/requirements.txt python3-zulip.noarch: E: zero-length /usr/share/zulip/integrations/perforce/requirements.txt python3-zulip.noarch: E: zero-length /usr/share/zulip/integrations/trello/requirements.txt python3-zulip_bots.noarch: E: non-executable-script /usr/lib/python3.14/site-packages/zulip_bots/bot_shell.py 644 /usr/bin/env python3 python3-zulip_bots.noarch: E: non-executable-script /usr/lib/python3.14/site-packages/zulip_bots/provision.py 644 /usr/bin/env python3 python3-zulip_bots.noarch: E: non-executable-script /usr/lib/python3.14/site-packages/zulip_bots/run.py 644 /usr/bin/env python3 python3-zulip.noarch: E: non-executable-script /usr/lib/python3.14/site-packages/integrations/bridge_with_matrix/matrix_bridge.py 644 /usr/bin/env python3 python3-zulip.noarch: E: non-executable-script /usr/lib/python3.14/site-packages/integrations/trello/zulip_trello.py 644 /usr/bin/env python3 python3-zulip.noarch: E: non-executable-script /usr/lib/python3.14/site-packages/zulip/api_examples.py 644 /usr/bin/env python3 python3-zulip.noarch: E: non-executable-script /usr/lib/python3.14/site-packages/zulip/cli.py 644 /usr/bin/env python3 python3-zulip.noarch: E: non-executable-script /usr/lib/python3.14/site-packages/zulip/send.py 644 /usr/bin/env python3 python3-zulip_botserver.noarch: E: non-executable-script /usr/lib/python3.14/site-packages/zulip_botserver/server.py 644 /usr/bin/env python3 python3-zulip.noarch: W: no-manual-page-for-binary zulip-api python3-zulip.noarch: W: no-manual-page-for-binary zulip-api-examples python3-zulip.noarch: W: no-manual-page-for-binary zulip-bot-shell python3-zulip.noarch: W: no-manual-page-for-binary zulip-botserver python3-zulip.noarch: W: no-manual-page-for-binary zulip-matrix-bridge python3-zulip.noarch: W: no-manual-page-for-binary zulip-run-bot python3-zulip.noarch: W: no-manual-page-for-binary zulip-send python3-zulip_bots.noarch: W: no-documentation python3-zulip_botserver.noarch: W: no-documentation python3-zulip.noarch: W: files-duplicate /usr/share/zulip/integrations/log2zulip/requirements.txt /usr/lib/python3.14/site-packages/integrations/codebase/requirements.txt:/usr/lib/python3.14/site-packages/integrations/log2zulip/requirements.txt:/usr/share/zulip/integrations/codebase/requirements.txt 3 packages and 0 specfiles checked; 21 errors, 10 warnings, 9 filtered, 21 badness; has taken 1.0 s Source checksums ---------------- https://github.com/zulip/python-zulip-api/archive/0.9.0/python-zulip-api-0.9.0.tar.gz : CHECKSUM(SHA256) this package : f2404728d1729eb2289166670c8c2d8369a29e59832729a1d4b9466687beb006 CHECKSUM(SHA256) upstream package : f2404728d1729eb2289166670c8c2d8369a29e59832729a1d4b9466687beb006 Requires -------- python3-zulip (rpmlib, GLIBC filtered): /usr/bin/python3 /usr/bin/sh python(abi) python3.14dist(click) python3.14dist(distro) python3.14dist(requests) python3.14dist(requests[security]) python3.14dist(typing-extensions) python3-zulip_bots (rpmlib, GLIBC filtered): python(abi) python3.14dist(beautifulsoup4) python3.14dist(html2text) python3.14dist(lxml) python3.14dist(pip) python3.14dist(typing-extensions) python3.14dist(zulip) python3-zulip_botserver (rpmlib, GLIBC filtered): python(abi) python3.14dist(flask) python3.14dist(typing-extensions) python3.14dist(zulip) python3.14dist(zulip-bots) Provides -------- python3-zulip: python-zulip python3-zulip python3.14-zulip python3.14dist(zulip) python3dist(zulip) python3-zulip_bots: python-zulip_bots python3-zulip_bots python3.14-zulip_bots python3.14dist(zulip-bots) python3dist(zulip-bots) python3-zulip_botserver: python-zulip_botserver python3-zulip_botserver python3.14-zulip_botserver python3.14dist(zulip-botserver) python3dist(zulip-botserver) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2375144 Buildroot used: fedora-rawhide-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: SugarActivity, C/C++, PHP, Java, Ocaml, fonts, R, Perl, Haskell Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH Comments: a) Great it builds now. b) Maybe it is worth having three separate packages? They come from one GitHub repo, but there are three separate pypi packages. Maybe it is worth asking on devel or python lists. This would allow using pyproject_save_files macro to ensure pypi parity on installed software. c) as zulip_bots does not have any tests, it would be good to add pyproject_check_import or a smoke test such as zulip-run-bot --help d) zulip-run-bot, zulip-bot-shell and zulip-botserver are not installed when using `pip install zulip`. zulip-run-bot and zulip-bot-shell are installed when using `pip install zulip-bots` and zulip-botserver is installed when using `pip install zulip-botserver` e) Expat license should also be listed https://github.com/zulip/python-zulip-api/blob/main/THIRDPARTY f) zulip-run-bot requires importlib-metadata but this does not appear. The installed version from pypi also needs this installed explicitly and does not pull it in on install.
Hello, I do realize that this is possibly an old ticket. I am sorry that it hasn't been reviewed yet. Let me trigger the Fedora Review Service to see if the package builds successfully. Hopefully, a green check mark will attract some reviewer. If I am resurrecting an old ticket that you are not interested in anymore, my apologies, feel free to close it. [fedora-review-service-build]
Copr build: https://copr.fedorainfracloud.org/coprs/build/9819892 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2375144-python-zulip/fedora-rawhide-x86_64/09819892-python-zulip-api/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.